feat(icon): add macaulay2 icon#3349
Conversation
PreviewThank you for creating a pull request. This preview shows you how your icon will look on the different themes: Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
|
@SepehrAkbari thanks for the PR. We have to align the icon to be more pixel perfect, you can see that the shapes of the SVG are not following our grid in this preview: Additionally, we should have at least one pixel whitespace around the icon |
|
@PKief Thanks for the comment. This version should be pixel perfect, and have a bigger margin. |
|
@SepehrAkbari thanks for the adjustments. However, based on the preview I can still see that some paths are cutting our grid lines although it looks like we could easily adjust it to follow the grid: 
Please make it possible that edges are not in the middle of a square/pixel but that the squares are completely filled |
|
let me know if you need some help, then I can fix it once I'm free. |
|
@PKief Thanks for clarifying. Does this work? Let me know if anything else needs modifying. |
PKief
left a comment
PKief
left a comment
There was a problem hiding this comment.
It looks ok, now! Thanks for the contribution.
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the Marketplace. |
2 participants
Description
This PR adds the official icon of Macaulay2, a software system for research in algebraic geometry, to files with ".m2" extension.
Macaulay2 Website
Macaulay2 Repository
The screenshot below shows the changes:
Contribution Guidelines