Skip to content

Commit 6de5199

Browse files
committed
fix jcesr warning
1 parent a78ac2f commit 6de5199

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

mp_api/client/mprester.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -396,15 +396,6 @@ def __getattr__(self, attr):
396396
f"{self.__class__.__name__!r} object has no attribute {attr!r}"
397397
)
398398

399-
def __getattribute__(self, attr):
400-
if "jcesr" in attr:
401-
warnings.warn(
402-
"NOTE: You are accessing the unmaintained legacy molecules data, "
403-
"please use MPRester.molecules.summary."
404-
)
405-
406-
return super().__getattribute__(attr)
407-
408399
def __dir__(self):
409400
return dir(MPRester) + self._deprecated_attributes + ["materials", "molecules"]
410401

mp_api/client/routes/molecules/molecules.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
from __future__ import annotations
22

3+
import warnings
4+
35
from emmet.core.mpid import MPculeID
46
from emmet.core.qchem.molecule import MoleculeDoc
57
from emmet.core.settings import EmmetSettings
@@ -202,5 +204,14 @@ class MoleculeRester(BaseMoleculeRester):
202204
suffix = "molecules/core"
203205
_sub_resters = ["summary", "jcesr"]
204206

207+
def __getattribute__(self, attr):
208+
if "jcesr" in attr:
209+
warnings.warn(
210+
"NOTE: You are accessing the unmaintained legacy molecules data, "
211+
"please use MPRester.molecules.summary."
212+
)
213+
214+
return super().__getattribute__(attr)
215+
205216
def __dir__(self):
206217
return dir(MoleculeRester) + self._sub_resters

0 commit comments

Comments
 (0)