Housekeeping (#1019)

Author: esoteric-ephemera

mp_api/client/core/client.py

@@ -21,9 +21,7 @@
 from typing import (
     TYPE_CHECKING,
     ForwardRef,
-    Generic,
     Optional,
-    TypeVar,
     get_args,
 )
 from urllib.parse import quote, urljoin
@@ -65,10 +63,8 @@
 
 SETTINGS = MAPIClientSettings()  # type: ignore
 
-T = TypeVar("T")
 
-
-class BaseRester(Generic[T]):
+class BaseRester:
     """Base client class with core stubs."""
 
     suffix: str = ""
@@ -140,15 +136,8 @@ def __init__(
         if not self.endpoint.endswith("/"):
             self.endpoint += "/"
 
-        if session:
-            self._session = session
-        else:
-            self._session = None  # type: ignore
-
-        if s3_client:
-            self._s3_client = s3_client
-        else:
-            self._s3_client = None
+        self._session = session
+        self._s3_client = s3_client
 
     @property
     def session(self) -> requests.Session:
@@ -596,7 +585,7 @@ def _submit_requests(  # noqa
             url: url used to make request
             use_document_model: if None, will defer to the self.use_document_model attribute
             parallel_param: parameter to parallelize requests with
-            num_chu: fieldsnky: Maximum number of chunks of data to yield. None will yield all possible.
+            num_chunks: Maximum number of chunks of data to yield. None will yield all possible.
             chunk_size: Number of data entries per chunk.
             timeout: Time in seconds to wait until a request timeout error is thrown
 
@@ -1077,7 +1066,9 @@ def _generate_returned_model(
         include_fields: dict[str, tuple[type, FieldInfo]] = {}
         for name in set_fields:
             field_copy = model_fields[name]._copy()
-            field_copy.default = None
+            if not field_copy.default_factory:
+                # Fields with a default_factory cannot also have a default in pydantic>=2.12.3
+                field_copy.default = None
             include_fields[name] = (
                 Optional[model_fields[name].annotation],
                 field_copy,
@@ -1097,8 +1088,6 @@ def _generate_returned_model(
             ),
             __module__=self.document_model.__module__,
         )
-        # if other_vars:
-        #     data_model.model_rebuild(_types_namespace=other_vars)
 
         orig_rester_name = self.document_model.__name__
 
@@ -1151,7 +1140,7 @@ def _query_resource_data(
         suburl: str | None = None,
         use_document_model: bool | None = None,
         timeout: int | None = None,
-    ) -> list[T] | list[dict]:
+    ) -> list[BaseModel] | list[dict]:
         """Query the endpoint for a list of documents without associated meta information. Only
         returns a single page of results.
 
@@ -1181,7 +1170,7 @@ def _search(
         all_fields: bool = True,
         fields: list[str] | None = None,
         **kwargs,
-    ) -> list[T] | list[dict]:
+    ) -> list[BaseModel] | list[dict]:
         """A generic search method to retrieve documents matching specific parameters.
 
         Arguments:
@@ -1216,7 +1205,7 @@ def get_data_by_id(
         self,
         document_id: str,
         fields: list[str] | None = None,
-    ) -> T | dict:
+    ) -> BaseModel | dict:
         warnings.warn(
             "get_data_by_id is deprecated and will be removed soon. Please use the search method instead.",
             DeprecationWarning,
@@ -1251,7 +1240,7 @@ def _get_all_documents(
         fields=None,
         chunk_size=1000,
         num_chunks=None,
-    ) -> list[T] | list[dict]:
+    ) -> list[BaseModel] | list[dict]:
         """Iterates over pages until all documents are retrieved. Displays
         progress using tqdm. This method is designed to give a common
         implementation for the search_* methods on various endpoints. See

mp_api/client/mprester.py

@@ -1203,10 +1203,11 @@ def get_entries_in_chemsys(
 
         elements_set = set(elements)  # remove duplicate elements
 
-        all_chemsyses = []
-        for i in range(len(elements_set)):
-            for els in itertools.combinations(elements_set, i + 1):
-                all_chemsyses.append("-".join(sorted(els)))
+        all_chemsyses = [
+            "-".join(sorted(els))
+            for i in range(len(elements_set))
+            for els in itertools.combinations(elements_set, i + 1)
+        ]
 
         entries = []
 

mp_api/client/routes/_general_store.py

@@ -5,7 +5,7 @@
 from mp_api.client.core import BaseRester
 
 
-class GeneralStoreRester(BaseRester[GeneralStoreDoc]):  # pragma: no cover
+class GeneralStoreRester(BaseRester):  # pragma: no cover
     suffix = "_general_store"
     document_model = GeneralStoreDoc  # type: ignore
     primary_key = "submission_id"

mp_api/client/routes/_messages.py

@@ -7,7 +7,7 @@
 from mp_api.client.core import BaseRester
 
 
-class MessagesRester(BaseRester[MessagesDoc]):  # pragma: no cover
+class MessagesRester(BaseRester):  # pragma: no cover
     suffix = "_messages"
     document_model = MessagesDoc  # type: ignore
     primary_key = "title"

mp_api/client/routes/_user_settings.py

@@ -5,7 +5,7 @@
 from mp_api.client.core import BaseRester
 
 
-class UserSettingsRester(BaseRester[UserSettingsDoc]):  # pragma: no cover
+class UserSettingsRester(BaseRester):  # pragma: no cover
     suffix = "_user_settings"
     document_model = UserSettingsDoc  # type: ignore
     primary_key = "consumer_id"

mp_api/client/routes/materials/absorption.py

@@ -8,7 +8,7 @@
 from mp_api.client.core.utils import validate_ids
 
 
-class AbsorptionRester(BaseRester[AbsorptionDoc]):
+class AbsorptionRester(BaseRester):
     suffix = "materials/absorption"
     document_model = AbsorptionDoc  # type: ignore
     primary_key = "material_id"

mp_api/client/routes/materials/alloys.py

@@ -8,7 +8,7 @@
 from mp_api.client.core.utils import validate_ids
 
 
-class AlloysRester(BaseRester[AlloyPairDoc]):
+class AlloysRester(BaseRester):
     suffix = "materials/alloys"
     document_model = AlloyPairDoc  # type: ignore
     primary_key = "pair_id"

mp_api/client/routes/materials/bonds.py

@@ -8,7 +8,7 @@
 from mp_api.client.core.utils import validate_ids
 
 
-class BondsRester(BaseRester[BondingDoc]):
+class BondsRester(BaseRester):
     suffix = "materials/bonds"
     document_model = BondingDoc  # type: ignore
     primary_key = "material_id"

mp_api/client/routes/materials/chemenv.py

@@ -14,7 +14,7 @@
 from mp_api.client.core.utils import validate_ids
 
 
-class ChemenvRester(BaseRester[ChemEnvDoc]):
+class ChemenvRester(BaseRester):
     suffix = "materials/chemenv"
     document_model = ChemEnvDoc  # type: ignore
     primary_key = "material_id"

mp_api/client/routes/materials/dielectric.py

@@ -8,7 +8,7 @@
 from mp_api.client.core.utils import validate_ids
 
 
-class DielectricRester(BaseRester[DielectricDoc]):
+class DielectricRester(BaseRester):
     suffix = "materials/dielectric"
     document_model = DielectricDoc  # type: ignore
     primary_key = "material_id"