Skip to content

Commit df55888

Browse files
committed
change name ForceFieldTaskDocument => ForceFieldStructureTaskDocument
1 parent 4f4b607 commit df55888

File tree

3 files changed

+27
-27
lines changed

3 files changed

+27
-27
lines changed

src/atomate2/forcefields/jobs.py

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
from atomate2.ase.jobs import AseRelaxMaker
1717
from atomate2.forcefields import MLFF, _get_formatted_ff_name
18-
from atomate2.forcefields.schemas import ForceFieldTaskDocument
18+
from atomate2.forcefields.schemas import ForceFieldStructureTaskDocument
1919
from atomate2.forcefields.utils import ase_calculator, revert_default_dtype
2020

2121
if TYPE_CHECKING:
@@ -48,7 +48,7 @@ def forcefield_job(method: Callable) -> job:
4848
This is a thin wrapper around :obj:`~jobflow.core.job.Job` that configures common
4949
settings for all forcefield jobs. For example, it ensures that large data objects
5050
(currently only trajectories) are all stored in the atomate2 data store.
51-
It also configures the output schema to be a ForceFieldTaskDocument :obj:`.TaskDoc`.
51+
It also configures the output schema to be a ForceFieldStructureTaskDocument :obj:`.TaskDoc`.
5252
5353
Any makers that return forcefield jobs (not flows) should decorate the
5454
``make`` method with @forcefield_job. For example:
@@ -73,7 +73,7 @@ def make(structure):
7373
A decorated version of the make function that will generate forcefield jobs.
7474
"""
7575
return job(
76-
method, data=_FORCEFIELD_DATA_OBJECTS, output_schema=ForceFieldTaskDocument
76+
method, data=_FORCEFIELD_DATA_OBJECTS, output_schema=ForceFieldStructureTaskDocument
7777
)
7878

7979

@@ -118,7 +118,7 @@ class ForceFieldRelaxMaker(AseRelaxMaker):
118118
tags : list[str] or None
119119
A list of tags for the task.
120120
task_document_kwargs : dict (deprecated)
121-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
121+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
122122
"""
123123

124124
name: str = "Force field relax"
@@ -147,7 +147,7 @@ def __post_init__(self) -> None:
147147
@forcefield_job
148148
def make(
149149
self, structure: Structure, prev_dir: str | Path | None = None
150-
) -> ForceFieldTaskDocument:
150+
) -> ForceFieldStructureTaskDocument:
151151
"""
152152
Perform a relaxation of a structure using a force field.
153153
@@ -170,7 +170,7 @@ def make(
170170
stacklevel=1,
171171
)
172172

173-
return ForceFieldTaskDocument.from_ase_compatible_result(
173+
return ForceFieldStructureTaskDocument.from_ase_compatible_result(
174174
str(self.force_field_name), # make mypy happy
175175
ase_result,
176176
self.steps,
@@ -212,7 +212,7 @@ class ForceFieldStaticMaker(ForceFieldRelaxMaker):
212212
calculator_kwargs : dict
213213
Keyword arguments that will get passed to the ASE calculator.
214214
task_document_kwargs : dict (deprecated)
215-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
215+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
216216
"""
217217

218218
name: str = "Force field static"
@@ -255,7 +255,7 @@ class CHGNetRelaxMaker(ForceFieldRelaxMaker):
255255
calculator_kwargs : dict
256256
Keyword arguments that will get passed to the ASE calculator.
257257
task_document_kwargs : dict (deprecated)
258-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
258+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
259259
"""
260260

261261
name: str = f"{MLFF.CHGNet} relax"
@@ -291,7 +291,7 @@ class CHGNetStaticMaker(ForceFieldStaticMaker):
291291
calculator_kwargs : dict
292292
Keyword arguments that will get passed to the ASE calculator.
293293
task_document_kwargs : dict (deprecated)
294-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
294+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
295295
"""
296296

297297
name: str = f"{MLFF.CHGNet} static"
@@ -334,7 +334,7 @@ class M3GNetRelaxMaker(ForceFieldRelaxMaker):
334334
calculator_kwargs : dict
335335
Keyword arguments that will get passed to the ASE calculator.
336336
task_document_kwargs : dict (deprecated)
337-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
337+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
338338
"""
339339

340340
name: str = f"{MLFF.M3GNet} relax"
@@ -372,7 +372,7 @@ class M3GNetStaticMaker(ForceFieldStaticMaker):
372372
calculator_kwargs : dict
373373
Keyword arguments that will get passed to the ASE calculator.
374374
task_document_kwargs : dict (deprecated)
375-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
375+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
376376
"""
377377

378378
name: str = f"{MLFF.M3GNet} static"
@@ -415,7 +415,7 @@ class NEPRelaxMaker(ForceFieldRelaxMaker):
415415
calculator_kwargs : dict
416416
Keyword arguments that will get passed to the ASE calculator.
417417
task_document_kwargs : dict (deprecated)
418-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
418+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
419419
"""
420420

421421
name: str = f"{MLFF.NEP} relax"
@@ -451,7 +451,7 @@ class NEPStaticMaker(ForceFieldStaticMaker):
451451
calculator_kwargs : dict
452452
Keyword arguments that will get passed to the ASE calculator.
453453
task_document_kwargs : dict (deprecated)
454-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
454+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
455455
"""
456456

457457
name: str = f"{MLFF.NEP} static"
@@ -494,7 +494,7 @@ class NequipRelaxMaker(ForceFieldRelaxMaker):
494494
calculator_kwargs : dict
495495
Keyword arguments that will get passed to the ASE calculator.
496496
task_document_kwargs : dict (deprecated)
497-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
497+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
498498
"""
499499

500500
name: str = f"{MLFF.Nequip} relax"
@@ -529,7 +529,7 @@ class NequipStaticMaker(ForceFieldStaticMaker):
529529
calculator_kwargs : dict
530530
Keyword arguments that will get passed to the ASE calculator.
531531
task_document_kwargs : dict (deprecated)
532-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
532+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
533533
"""
534534

535535
name: str = f"{MLFF.Nequip} static"
@@ -576,7 +576,7 @@ class MACERelaxMaker(ForceFieldRelaxMaker):
576576
trained for Matbench Discovery on the MPtrj dataset available at
577577
https://figshare.com/articles/dataset/22715158.
578578
task_document_kwargs : dict (deprecated)
579-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
579+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
580580
"""
581581

582582
name: str = f"{MLFF.MACE_MP_0} relax"
@@ -616,7 +616,7 @@ class MACEStaticMaker(ForceFieldStaticMaker):
616616
trained for Matbench Discovery on the MPtrj dataset available at
617617
https://figshare.com/articles/dataset/22715158.
618618
task_document_kwargs : dict (deprecated)
619-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
619+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
620620
"""
621621

622622
name: str = f"{MLFF.MACE_MP_0} static"
@@ -665,7 +665,7 @@ class SevenNetRelaxMaker(ForceFieldRelaxMaker):
665665
trained for Matbench Discovery on the MPtrj dataset available at
666666
https://figshare.com/articles/dataset/22715158.
667667
task_document_kwargs : dict (deprecated)
668-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
668+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
669669
"""
670670

671671
name: str = f"{MLFF.SevenNet} relax"
@@ -707,7 +707,7 @@ class SevenNetStaticMaker(ForceFieldStaticMaker):
707707
trained for Matbench Discovery on the MPtrj dataset available at
708708
https://figshare.com/articles/dataset/22715158.
709709
task_document_kwargs : dict (deprecated)
710-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
710+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
711711
"""
712712

713713
name: str = f"{MLFF.SevenNet} static"
@@ -747,7 +747,7 @@ class GAPRelaxMaker(ForceFieldRelaxMaker):
747747
calculator_kwargs : dict
748748
Keyword arguments that will get passed to the ASE calculator.
749749
task_document_kwargs : dict (deprecated)
750-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
750+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
751751
"""
752752

753753
name: str = f"{MLFF.GAP} relax"
@@ -783,7 +783,7 @@ class GAPStaticMaker(ForceFieldStaticMaker):
783783
calculator_kwargs : dict
784784
Keyword arguments that will get passed to the ASE calculator.
785785
task_document_kwargs : dict (deprecated)
786-
Additional keyword args passed to :obj:`.ForceFieldTaskDocument()`.
786+
Additional keyword args passed to :obj:`.ForceFieldStructureTaskDocument()`.
787787
"""
788788

789789
name: str = f"{MLFF.GAP} static"

src/atomate2/forcefields/md.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
_DEFAULT_CALCULATOR_KWARGS,
1616
_FORCEFIELD_DATA_OBJECTS,
1717
)
18-
from atomate2.forcefields.schemas import ForceFieldTaskDocument
18+
from atomate2.forcefields.schemas import ForceFieldStructureTaskDocument
1919
from atomate2.forcefields.utils import ase_calculator, revert_default_dtype
2020

2121
if TYPE_CHECKING:
@@ -126,13 +126,13 @@ def __post_init__(self) -> None:
126126

127127
@job(
128128
data=[*_FORCEFIELD_DATA_OBJECTS, "ionic_steps"],
129-
output_schema=ForceFieldTaskDocument,
129+
output_schema=ForceFieldStructureTaskDocument,
130130
)
131131
def make(
132132
self,
133133
structure: Structure,
134134
prev_dir: str | Path | None = None,
135-
) -> ForceFieldTaskDocument:
135+
) -> ForceFieldStructureTaskDocument:
136136
"""
137137
Perform MD on a structure using forcefields and jobflow.
138138
@@ -156,7 +156,7 @@ def make(
156156
stacklevel=1,
157157
)
158158

159-
return ForceFieldTaskDocument.from_ase_compatible_result(
159+
return ForceFieldStructureTaskDocument.from_ase_compatible_result(
160160
str(self.force_field_name), # make mypy happy
161161
md_result,
162162
relax_cell=(self.ensemble == MDEnsemble.npt),

src/atomate2/forcefields/schemas.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class ForcefieldObject(ValueEnum):
3636
TRAJECTORY = "trajectory"
3737

3838

39-
class ForceFieldTaskDocument(AseStructureTaskDoc):
39+
class ForceFieldStructureTaskDocument(AseStructureTaskDoc):
4040
"""Document containing information on structure manipulation using a force field."""
4141

4242
forcefield_name: Optional[str] = Field(
@@ -87,7 +87,7 @@ def from_ase_compatible_result(
8787
store_trajectory: StoreTrajectoryOption = StoreTrajectoryOption.NO,
8888
tags: list[str] | None = None,
8989
**task_document_kwargs,
90-
) -> ForceFieldTaskDocument:
90+
) -> ForceFieldStructureTaskDocument:
9191
"""Create an AseTaskDoc for a task that has ASE-compatible outputs.
9292
9393
Parameters

0 commit comments

Comments
 (0)