test changing unit cell choices in crystal_toolkit/apps/examples/tests/test_structure.py

Author: janosh

crystal_toolkit/apps/examples/tests/test_bandstructure.py

@@ -1,9 +1,10 @@
 import time
 
 from crystal_toolkit.apps.examples.bandstructure import app
+from crystal_toolkit.apps.examples.tests.typing import DashDuo
 
 
-def test_bs(dash_duo):
+def test_bs(dash_duo: DashDuo) -> None:
 
     dash_duo.start_server(app)
     dash_duo.clear_storage()

crystal_toolkit/apps/examples/tests/test_basic.py

@@ -7,8 +7,7 @@
     app as hello_structure_interactive_app,
 )
 from crystal_toolkit.apps.examples.basic_hello_world import app as hello_world_app
-
-from .typing import DashDuo
+from crystal_toolkit.apps.examples.tests.typing import DashDuo
 
 
 def test_hello_scientist(dash_duo: DashDuo):
@@ -19,18 +18,18 @@ def test_hello_scientist(dash_duo: DashDuo):
     dash_duo.percy_snapshot("hello_scientist")
 
     logs = dash_duo.get_logs()
-    assert bool(logs) is False, f"Browser console contains an error: {logs}"
+    assert logs == [], f"Browser console contains an error: {logs}"
 
 
-def test_hello_structure(dash_duo):
+def test_hello_structure(dash_duo: DashDuo) -> None:
     dash_duo.start_server(hello_structure_app)
     dash_duo.clear_storage()
 
     time.sleep(1)
     dash_duo.percy_snapshot("hello_structure")
 
     logs = dash_duo.get_logs()
-    assert bool(logs) is False, f"Browser console contains an error: {logs}"
+    assert logs == [], f"Browser console contains an error: {logs}"
 
 
 def test_hello_structure_interactive(dash_duo: DashDuo) -> None:

crystal_toolkit/apps/examples/tests/test_structure.py

@@ -1,30 +1,35 @@
-import time
+from time import sleep
 
 from crystal_toolkit.apps.examples.structure import app
+from crystal_toolkit.apps.examples.tests.typing import DashDuo
 
 
-def test_structure(dash_duo):
+def test_structure(dash_duo: DashDuo) -> None:
 
     dash_duo.start_server(app)
     dash_duo.clear_storage()
 
-    time.sleep(5)
     dash_duo.percy_snapshot("example_structure_on_load")
+    sleep(1)
 
     # click the settings button (second button in the button-bar) to show the settings panel
     # and test the settings options.
-    dash_duo.find_elements(".mpc-button-bar .button")[1].click()
+    dash_duo.find_element(".mpc-button-bar .button[data-for*=settings]").click()
+
+    # make sure changing unit cell works
+    for idx in range(3):
+        dash_duo.select_dcc_dropdown("#CTmy_structure_unit-cell-choice", index=idx)
+        dash_duo.percy_snapshot(f"example_structure_unit-cell_index_{idx}")
 
     # test changing radius
-    el = dash_duo.select_dcc_dropdown("#CTmy_structure_radius_strategy", index=0)
-    time.sleep(1)
+    dash_duo.select_dcc_dropdown("#CTmy_structure_radius_strategy", index=0)
     dash_duo.percy_snapshot("example_structure_radius_index_0")
+    sleep(1)
 
     # test changing radius again
-    el = dash_duo.select_dcc_dropdown("#CTmy_structure_radius_strategy", index=2)
-    time.sleep(1)
+    dash_duo.select_dcc_dropdown("#CTmy_structure_radius_strategy", index=2)
     dash_duo.percy_snapshot("example_structure_primitive_radius_index_2")
+    sleep(1)
 
-    assert (
-        bool(dash_duo.get_logs()) is False
-    ), f"Browser console contains an error: {dash_duo.get_logs()}"
+    logs = dash_duo.get_logs()
+    assert logs == [], f"Browser console contains an error: {logs}"