reactivate commented out basic tests

test_hello_scientist()
test_hello_structure()

Author: janosh

crystal_toolkit/apps/examples/tests/test_bandstructure.py

@@ -26,6 +26,5 @@ def test_bs(dash_duo):
     # time.sleep(3)
     # dash_duo.percy_snapshot("example_bsdos_projection_index_2")
 
-    assert (
-        bool(dash_duo.get_logs()) is False
-    ), f"Browser console contains an error: {dash_duo.get_logs()}"
+    logs = dash_duo.get_logs()
+    assert logs == [], f"Browser console should not contain errors: {logs}"

crystal_toolkit/apps/examples/tests/test_basic.py

@@ -1,44 +1,47 @@
 import time
 
+from crystal_toolkit.apps.examples.basic_hello_structure import (
+    app as hello_structure_app,
+)
 from crystal_toolkit.apps.examples.basic_hello_structure_interactive import (
     app as hello_structure_interactive_app,
 )
+from crystal_toolkit.apps.examples.basic_hello_world import app as hello_world_app
 
-#
-# def test_hello_scientist(dash_duo):
-#
-#     dash_duo.start_server(hello_world_app)
-#     dash_duo.clear_storage()
-#
-#     time.sleep(1)
-#     dash_duo.percy_snapshot("hello_scientist")
-#
-#     logs = dash_duo.get_logs()
-#     assert bool(logs) is False, f"Browser console contains an error: {logs}"
-#
-#
-# def test_hello_structure(dash_duo):
-#     dash_duo.start_server(hello_structure_app)
-#     dash_duo.clear_storage()
-#
-#     time.sleep(1)
-#     dash_duo.percy_snapshot("hello_structure")
-#
-#     logs = dash_duo.get_logs()
-#     assert bool(logs) is False, f"Browser console contains an error: {logs}"
-
-
-def test_hello_structure_interactive(dash_duo):
-    dash_duo.start_server(hello_structure_interactive_app)
+from .typing import DashDuo
+
+
+def test_hello_scientist(dash_duo: DashDuo):
+
+    dash_duo.start_server(hello_world_app)
+    dash_duo.clear_storage()
+
+    dash_duo.percy_snapshot("hello_scientist")
+
+    logs = dash_duo.get_logs()
+    assert bool(logs) is False, f"Browser console contains an error: {logs}"
+
+
+def test_hello_structure(dash_duo):
+    dash_duo.start_server(hello_structure_app)
     dash_duo.clear_storage()
 
     time.sleep(1)
+    dash_duo.percy_snapshot("hello_structure")
+
+    logs = dash_duo.get_logs()
+    assert bool(logs) is False, f"Browser console contains an error: {logs}"
+
+
+def test_hello_structure_interactive(dash_duo: DashDuo) -> None:
+    dash_duo.start_server(hello_structure_interactive_app)
+    dash_duo.clear_storage()
+
     dash_duo.percy_snapshot("hello_structure_interactive_on_load")
 
     dash_duo.multiple_click("#change_structure_button", 1)
 
-    time.sleep(1)
     dash_duo.percy_snapshot("hello_structure_interactive_on_click")
 
     logs = dash_duo.get_logs()
-    assert bool(logs) is False, f"Browser console contains an error: {logs}"
+    assert logs == [], f"Browser console should not contain errors: {logs}"

crystal_toolkit/apps/tests/test_main.py

@@ -1,9 +1,10 @@
 import time
 
+from crystal_toolkit.apps.examples.tests.typing import DashDuo
 from crystal_toolkit.apps.main import app
 
 
-def test_main_app_startup(dash_duo):
+def test_main_app_startup(dash_duo: DashDuo):
 
     dash_duo.start_server(app)
     # dash_duo.clear_storage()