use type() and repr() instead of __class__ and __repr__

Author: janosh

.github/workflows/url-check.yml

@@ -16,5 +16,5 @@ jobs:
       - name: Check for broken links
         uses: lycheeverse/lychee-action@v1
         with:
-          # exclude loopback to skip localhost URLs from checking
+          # --exclude-loopback ensures we don't check localhost URLs
           args: --exclude-loopback './**/*.md' './**/*.rst'

crystal_toolkit/__init__.py

@@ -68,15 +68,15 @@ def _repr_mimebundle_(self, include=None, exclude=None):
     if hasattr(self, "get_scene"):
         return {
             "application/vnd.mp.ctk+json": self.get_scene().to_json(),
-            "text/plain": help_text_ct + self.__repr__(),
+            "text/plain": help_text_ct + repr(self),
         }
     elif hasattr(self, "get_plot"):
         return {
             "application/vnd.plotly.v1+json": self.get_plot().to_plotly_json(),
-            "text/plain": help_text_plotly + self.__repr__(),
+            "text/plain": help_text_plotly + repr(self),
         }
     else:
-        return {"application/json": self.as_dict(), "text/plain": self.__repr__()}
+        return {"application/json": self.as_dict(), "text/plain": repr(self)}
 
 
 MSONable._repr_mimebundle_ = _repr_mimebundle_

crystal_toolkit/components/bandstructure.py

@@ -846,8 +846,8 @@ def update_select(elements, mpid):
                     + [{"label": "Orbital Projected - Total", "value": "op"}]
                     + [
                         {
-                            "label": "Orbital Projected - " + str(ele_label),
-                            "value": "orb" + str(ele_label),
+                            "label": f"Orbital Projected - {ele_label}",
+                            "value": f"orb{ele_label}",
                         }
                         for ele_label in elements
                     ]
@@ -863,8 +863,8 @@ def update_select(elements, mpid):
                     + [{"label": "Orbital Projected - Total", "value": "op"}]
                     + [
                         {
-                            "label": "Orbital Projected - " + str(ele_label),
-                            "value": "orb" + str(ele_label),
+                            "label": f"Orbital Projected - {ele_label}",
+                            "value": f"orb{ele_label}",
                         }
                         for ele_label in elements
                     ]

crystal_toolkit/components/diffraction.py

@@ -529,4 +529,4 @@ def pattern_from_struct(struct, rad_source):
         #     output = scope.transform(data, format="png", width=600, height=400, scale=4)
         #     image = b64encode(output).decode('ascii')
         #
-        #     return "data:image/png;base64," + image
+        #     return f"data:image/png;base64,{image}"

crystal_toolkit/components/transformations/core.py

@@ -183,7 +183,7 @@ def apply_transformation(transformation_data, struct):
                 struct = transformation.apply_transformation(struct)
             except Exception as exc:
                 error_title = (
-                    f'Failed to apply "{transformation.__class__.__name__}" '
+                    f'Failed to apply "{type(transformation).__name__}" '
                     f"transformation: {exc}"
                 )
                 traceback_info = Reveal(
@@ -281,7 +281,7 @@ def __init__(
         user-defined order.
 
         :param transformations: if provided, only offer a subset of available
-            transformaitons, provide as a string of the given transformation name
+            transformations, provide as a string of the given transformation name
         :param input_structure_component: will supply the structure to transform
         """
 
@@ -311,7 +311,7 @@ def __init__(
             t(input_structure_component_id=self.id("input_structure"))
             for t in transformations
         ]
-        self.transformations = {t.__class__.__name__: t for t in transformations}
+        self.transformations = {type(t).__name__: t for t in transformations}
 
     @property
     def _sub_layouts(self):
@@ -372,7 +372,7 @@ def apply_transformation(transformation_data, struct):
                 struct = transformation.apply_transformation(struct)
             except Exception as exc:
                 error_title = html.Span(
-                    f'Failed to apply "{transformation.__class__.__name__}" '
+                    f'Failed to apply "{type(transformation).__name__}" '
                     f"transformation: {exc}"
                 )
                 traceback_info = Reveal(

crystal_toolkit/core/scene.py

@@ -77,7 +77,7 @@ def _repr_mimebundle_(self, include=None, exclude=None):
         """
         return {
             "application/vnd.mp.ctk+json": self.to_json(),
-            "text/plain": self.__repr__(),
+            "text/plain": repr(self),
         }
 
     def to_json(self):