try/except imports below regular imports

Author: janosh

pymatgen/io/abinit/netcdf.py

@@ -18,6 +18,13 @@
 from pymatgen.core.units import ArrayWithUnit
 from pymatgen.core.xcfunc import XcFunc
 
+try:
+    import netCDF4
+except ImportError:
+    netCDF4 = None
+    warnings.warn("Can't import netCDF4. Some features will be disabled unless you pip install netCDF4.")
+
+
 logger = logging.getLogger(__name__)
 
 __author__ = "Matteo Giantomassi"
@@ -37,21 +44,6 @@
     "structure_from_ncdata",
 ]
 
-try:
-    import netCDF4
-except ImportError as exc:
-    netCDF4 = None
-    warnings.warn(
-        f"""\
-`import netCDF4` failed with the following error:
-
-{exc}
-
-Please install netcdf4 with `conda install netcdf4`
-If the conda version does not work, uninstall it with `conda uninstall hdf4 hdf5 netcdf4`
-and use `pip install netcdf4`"""
-    )
-
 
 def _asreader(file, cls):
     closeit = False

pymatgen/phonon/thermal_displacements.py

@@ -14,10 +14,6 @@
 from pymatgen.symmetry.groups import SYMM_DATA
 from pymatgen.util.due import Doi, due
 
-sub_spgrp = partial(re.sub, r"[\s_]", "")
-
-space_groups = {sub_spgrp(k): k for k in SYMM_DATA["space_group_encoding"]}  # type: ignore
-
 try:
     import phonopy
 except ImportError as exc:
@@ -32,6 +28,10 @@
 __status__ = "Testing"
 __date__ = "August 09, 2022"
 
+sub_spgrp = partial(re.sub, r"[\s_]", "")
+
+space_groups = {sub_spgrp(k): k for k in SYMM_DATA["space_group_encoding"]}  # type: ignore
+
 
 class ThermalDisplacementMatrices(MSONable):
     """Class to handle thermal displacement matrices

pymatgen/vis/structure_vtk.py

@@ -10,6 +10,13 @@
 from typing import Sequence
 
 import numpy as np
+from monty.dev import requires
+from monty.serialization import loadfn
+
+from pymatgen.core.periodic_table import Species
+from pymatgen.core.sites import PeriodicSite
+from pymatgen.core.structure import Structure
+from pymatgen.util.coord import in_coord_list
 
 try:
     import vtk
@@ -19,14 +26,6 @@
     vtk = None
     vtkInteractorStyleTrackballCamera = object
 
-from monty.dev import requires
-from monty.serialization import loadfn
-
-from pymatgen.core.periodic_table import Species
-from pymatgen.core.sites import PeriodicSite
-from pymatgen.core.structure import Structure
-from pymatgen.util.coord import in_coord_list
-
 module_dir = os.path.dirname(os.path.abspath(__file__))
 EL_COLORS = loadfn(f"{module_dir}/ElementColorSchemes.yaml")
 

tests/analysis/test_graphs.py

@@ -30,6 +30,7 @@
     from openbabel import openbabel
 except ImportError:
     openbabel = None
+
 try:
     import pygraphviz
 except ImportError:

tests/io/test_shengbte.py

@@ -8,15 +8,15 @@
 from pymatgen.io.shengbte import Control
 from pymatgen.util.testing import TEST_FILES_DIR, PymatgenTest
 
-test_dir = f"{TEST_FILES_DIR}/shengbte"
-
-this_dir = os.path.dirname(os.path.abspath(__file__))
-
 try:
     import f90nml
 except ImportError:
     f90nml = None
 
+test_dir = f"{TEST_FILES_DIR}/shengbte"
+
+this_dir = os.path.dirname(os.path.abspath(__file__))
+
 
 class TestShengBTE(PymatgenTest):
     def setUp(self):

tests/phonon/test_gruneisen.py

@@ -5,7 +5,10 @@
 import matplotlib.pyplot as plt
 from pytest import approx
 
-from pymatgen.util.testing import TEST_FILES_DIR
+from pymatgen.io.phonopy import get_gruneisen_ph_bs_symm_line, get_gruneisenparameter
+from pymatgen.phonon.gruneisen import GruneisenParameter
+from pymatgen.phonon.plotter import GruneisenPhononBandStructureSymmLine, GruneisenPhononBSPlotter, GruneisenPlotter
+from pymatgen.util.testing import TEST_FILES_DIR, PymatgenTest
 
 try:
     import phonopy
@@ -14,11 +17,6 @@
     print(exc)
     phonopy = TotalDos = None
 
-from pymatgen.io.phonopy import get_gruneisen_ph_bs_symm_line, get_gruneisenparameter
-from pymatgen.phonon.gruneisen import GruneisenParameter
-from pymatgen.phonon.plotter import GruneisenPhononBandStructureSymmLine, GruneisenPhononBSPlotter, GruneisenPlotter
-from pymatgen.util.testing import PymatgenTest
-
 
 class TestGruneisenPhononBandStructureSymmLine(PymatgenTest):
     def setUp(self) -> None:

tests/transformations/test_advanced_transformations.py

@@ -51,7 +51,6 @@
 except ImportError:
     hiphive = None
 
-
 try:
     import matgl
 except ImportError: