fix complete 0.8 test suite

Author: Nils Henning

.byebug_history

@@ -1,4 +1,38 @@
 continue
+save_screenshot
+continue
+context
+continue
+titleize 'foo'
+params
+self.class
+continue
+self.class.superclass.superclass
+self.class.superclass
+self.class
+continue
+@view_context.respond_to? :params
+@view_context.respond_to? :view_context
+@view_context.params
+@view_context
+self.get_instance_variable(:view_context)
+self.instance_variables
+self
+@view_context.send(:params)
+@view_context
+self.params
+params
+self.class.superclass.superclass.superclass
+self.class.superclass.superclass
+self.class.superclass
+params
+self.class
+self
+params
+defined? params
+continue
+self
+continue
 page.html
 all(:link_or_button, 'See Success')
 find(:link_or_button, 'See Success')
@@ -220,37 +254,3 @@ self.class.requires_properties
 continue
 Matestack::Ui::Core::Form::Form.instance_methods.include? :method
 Matestack::Ui::Core::Form::Form.instance_methods.contains? :method
-Matestack::Ui::Core::Form::Form.instance_methods
-Matestack::Ui::Core::Form::Form
-save_screenshot
-continue
-PropertyComponent.new(title: 'Test', foo: 'Foo').respond_to?(:title)
-PropertyComponent.new.respond_to?(:title)
-PropertyComponent.new.respond_to?(:title))
-continue
-self.class.requires_properties
-self.class.optional_properties
-continue
-self.class.optional_properties
-continue
-self.class.optional_properties
-self.class.requires_properties
-prop
-self.send(:options)[prop]
-self.send(:options)
-continue
-self
-self.class
-self.class.respond_to? :required_properties
-self.respond_to? :required_properties
-self.respond_to? :required_hooks
-self.respond_to? :puts
-self.responds_to? :puts
-self.defined?(:puts)
-self.defined(:puts=
-self.send(:singleton_method_undefined, :puts)
-self.send(:singleton_method_undefined)
-self.send(:singleton_method_defined?)
-self
-continue
-TestModel.destroy_all

app/concepts/matestack/ui/core/collection/helper.rb

@@ -112,8 +112,8 @@ def set_collection id: nil, init_offset: 0, init_limit: nil, base_count: nil, fi
     # try to get params from either controller params, when called in a rails legacy view or
     # from cells context when called in a matestack app/page/component
     def controller_params
-      return params.to_unsafe_h if defined? params
       return context[:params] if defined? context
+      return params.to_unsafe_h if defined? params
       raise 'collection component is missing access to params or context'
     end
 

spec/0.8/components/action_spec.rb

@@ -1,17 +1,7 @@
 require_relative "../../support/utils"
+require_relative "../../support/test_controller"
 include Utils
 
-class TestController < ActionController::Base
-  before_action :check_params
-
-  def check_params
-    expect_params(params.permit!.to_h)
-  end
-
-  def expect_params(params)
-  end
-end
-
 describe "Action Component", type: :feature, js: true do
   before :each do
     module Example

spec/0.8/components/dynamic/collection/pagination_spec.rb

@@ -155,6 +155,7 @@ def destroy_test_model
       Rails.application.reload_routes!
 
       class ExamplePage < Matestack::Ui::Page
+        include Matestack::Ui::Core::HasViewContext
         include Matestack::Ui::Core::Collection::Helper
 
         def prepare

spec/0.8/integrations/turbolinks_integration_spec.rb

@@ -1,17 +1,6 @@
-describe "Turbolinks integration", type: :feature, js: true do
-
-  class TestController < ActionController::Base
-
-    before_action :check_params
-
-    def check_params
-      expect_params(params.permit!.to_h)
-    end
-
-    def expect_params(params)
-    end
+require_relative "../../support/test_controller"
 
-  end
+describe "Turbolinks integration", type: :feature, js: true do
 
   it "Matestack can be used with turbolinks" do
 
@@ -37,6 +26,9 @@ def response
       end
     end
 
+    module Pages
+    end
+
     module Pages::TurbolinksTest
     end
 
@@ -77,10 +69,11 @@ def action_config
     end
     Rails.application.reload_routes!
 
-    class TurbolinksTestController < ActionController::Base
+    class TurbolinksTestController < ApplicationController
+      include Matestack::Ui::Core::ApplicationHelper
       layout "application_with_turbolinks"
+      matestack_app Apps::TurbolinksTest
 
-      include Matestack::Ui::Core::ApplicationHelper
 
       def page1
         render(Pages::TurbolinksTest::Page1)
@@ -106,7 +99,6 @@ def test
     visit "/turbolinks1"
 
     expect(page).to have_text "Hello from matestack with turbolinks - Page 1"
-
     click_button "Transition to Page 2"
 
     expect(page).to have_text "Hello from matestack with turbolinks - Page 2"