Skip to content

Commit 428600f

Browse files
authored
Merge pull request #464 from matestack/20201006_#462_fix-scroll-top-for-short-pages
Fix scroll top throwing error for short pages
2 parents a4d420a + fb5a196 commit 428600f

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

app/concepts/matestack/ui/core/app/store.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,11 @@ const store = new Vuex.Store({
4040
return getScrollParent(node.parentNode)
4141
}
4242
}
43-
getScrollParent(document.getElementsByClassName("matestack-page-root")[0]).scrollTop = 0
43+
var scrollParent = getScrollParent(document.getElementsByClassName("matestack-page-root")[0])
44+
if(scrollParent){
45+
scrollParent.scrollTop = 0;
46+
}
47+
// getScrollParent(document.getElementsByClassName("matestack-page-root")[0]).scrollTop = 0
4448
}
4549
},
4650
actions: {

vendor/assets/javascripts/dist/matestack-ui-core.js

Lines changed: 5 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/assets/javascripts/dist/matestack-ui-core.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)