iframe: Address review comments.

Author: mayanktap

app/concepts/matestack/ui/core/iframe/iframe.rb

@@ -1,5 +1,14 @@
 module Matestack::Ui::Core::Iframe
   class Iframe < Matestack::Ui::Core::Component::Static
 
+    def setup
+      @tag_attributes.merge!({
+        src: options[:src],
+        height: options[:height],
+        width: options[:width],
+        srcdoc: options[:srcdoc]
+      })
+    end
+
   end
 end

docs/components/iframe.md

@@ -14,10 +14,18 @@ Expects a string with all ids the `iframe` should have.
 #### # class (optional)
 Expects a string with all classes the `iframe` should have for styling purpose.
 
+#### # height (optional)
+Specifies the height of an `iframe`.
+
+#### # width (optional)
+Specifies the width of an `iframe`.
 
 #### # src
 Specifies the address of the document to embed in the `iframe` tag.
 
+#### # srcdoc
+Specifies the HTML content of the page to show in the inline frame.
+
 ## Example 1: Yield a given block
 
 ```ruby

spec/usage/components/iframe_spec.rb

@@ -15,7 +15,7 @@ def response
           end
 
           # enhanced iframe tag
-          iframe id: 'my-id', class: 'my-class', src="https://www.demopage.com" do
+          iframe id: 'my-id', class: 'my-class', src="https://www.demopage.com", srcdoc="<p>Mate Stack UI!</p>" do
             plain 'The browser does not support iframe.'
           end
         }
@@ -28,7 +28,7 @@ def response
 
     expected_static_output = <<~HTML
     <iframe src="https://www.demopage.com">The browser does not support iframe.</iframe>
-    <iframe id="my-id" class="my-class" src="https://www.demopage.com">The browser does not support iframe.</iframe>
+    <iframe id="my-id" class="my-class" src="https://www.demopage.com" srcdoc="<p>Mate Stack UI!</p>">The browser does not support iframe.</iframe>
     HTML
     expect(stripped(static_output)).to include(stripped(expected_static_output))
   end
@@ -43,7 +43,8 @@ def response
           iframe src="https://www.demopage.com", text: 'The browser does not support iframe.'
 
           # enhanced iframe tag
-          iframe id: 'my-id', class: 'my-class', src="https://www.demopage.com", text: 'The browser does not support iframe.'
+          iframe id: 'my-id', class: 'my-class', src="https://www.demopage.com",
+            srcdoc="<p>Mate Stack UI!</p>", text: 'The browser does not support iframe.'
         }
       end
 
@@ -55,7 +56,7 @@ def response
 
     expected_static_output = <<~HTML
     <iframe src="https://www.demopage.com">The browser does not support iframe.</iframe>
-    <iframe id="my-id" class="my-class" src="https://www.demopage.com">The browser does not support iframe.</iframe>
+    <iframe id="my-id" class="my-class" src="https://www.demopage.com" srcdoc="<p>Mate Stack UI!</p>">The browser does not support iframe.</iframe>
     HTML
 
     expect(stripped(static_output)).to include(stripped(expected_static_output))