Skip to content

Commit 9b52f2a

Browse files
author
Nils Henning
committed
update data, datalist, dd, del, details, dfn, dialog, div, dl, dt, summary components and specs
1 parent 70639ec commit 9b52f2a

File tree

11 files changed

+150
-242
lines changed

11 files changed

+150
-242
lines changed

lib/matestack/ui/core/components.rb

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,24 @@ def self.require_core_component(name)
4141
require_core_component "caption"
4242
require_core_component "cite"
4343
require_core_component "code"
44+
require_core_component "data"
45+
require_core_component "datalist"
46+
require_core_component "dd"
47+
require_core_component "del"
48+
require_core_component "details"
49+
require_core_component "dfn"
50+
require_core_component "dialog"
4451
require_core_component "div"
52+
require_core_component "dl"
53+
require_core_component "dt"
4554
require_core_component "heading"
4655
require_core_component "link"
4756
require_core_component "main"
4857
require_core_component "nav"
4958
require_core_component "paragraph"
5059
require_core_component "plain"
5160
require_core_component "span"
61+
require_core_component "summary"
5262
require_core_component "table"
5363
require_core_component "tbody"
5464
require_core_component "td"
@@ -80,14 +90,24 @@ def self.require_core_component(name)
8090
caption: Matestack::Ui::Core::Caption::Caption,
8191
cite: Matestack::Ui::Core::Cite::Cite,
8292
code: Matestack::Ui::Core::Code::Code,
93+
data: Matestack::Ui::Core::Data::Data,
94+
datalist: Matestack::Ui::Core::Datalist::Datalist,
95+
dd: Matestack::Ui::Core::Dd::Dd,
96+
del: Matestack::Ui::Core::Del::Del,
97+
details: Matestack::Ui::Core::Details::Details,
98+
dfn: Matestack::Ui::Core::Dfn::Dfn,
99+
dialog: Matestack::Ui::Core::Dialog::Dialog,
83100
div: Matestack::Ui::Core::Div::Div,
101+
dl: Matestack::Ui::Core::Dl::Dl,
102+
dt: Matestack::Ui::Core::Dt::Dt,
84103
heading: Matestack::Ui::Core::Heading::Heading,
85104
link: Matestack::Ui::Core::Link::Link,
86105
main: Matestack::Ui::Core::Main::Main,
87106
nav: Matestack::Ui::Core::Nav::Nav,
88107
paragraph: Matestack::Ui::Core::Paragraph::Paragraph,
89108
plain: Matestack::Ui::Core::Plain::Plain,
90109
span: Matestack::Ui::Core::Span::Span,
110+
summary: Matestack::Ui::Core::Summary::Summary,
91111
transition: Matestack::Ui::Core::Transition::Transition,
92112
table: Matestack::Ui::Core::Table::Table,
93113
tbody: Matestack::Ui::Core::Tbody::Tbody,

spec/0.8/components/data_spec.rb

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,17 @@
55
it 'Renders a simple and enhanced data tag on a page' do
66
class ExamplePage < Matestack::Ui::Page
77
def response
8-
components {
9-
# Simple data
10-
data id: 'foo', class: 'bar', value: '1301', text: 'Data example 1'
11-
12-
# Enhanced data
13-
data id: 'foo', class: 'bar', value: '1300' do
14-
plain 'Data example 2' # optional content
15-
end
16-
}
8+
# Simple data
9+
data id: 'foo', class: 'bar', value: '1301', text: 'Data example 1'
10+
# Enhanced data
11+
data id: 'foo', class: 'bar', value: '1300' do
12+
plain 'Data example 2' # optional content
13+
end
1714
end
1815
end
1916

2017
visit '/example'
21-
2218
static_output = page.html
23-
2419
expected_static_output = <<~HTML
2520
<data id="foo" value="1301" class="bar">
2621
Data example 1
@@ -29,7 +24,6 @@ def response
2924
Data example 2
3025
</data>
3126
HTML
32-
3327
expect(stripped(static_output)).to include(stripped(expected_static_output))
3428
end
3529
end

spec/0.8/components/datalist_spec.rb

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,18 @@
66
it 'Example 1 - yield' do
77

88
class ExamplePage < Matestack::Ui::Page
9-
109
def response
11-
components {
12-
datalist id: 'foo', class: 'bar' do
13-
plain 'Example Text'
14-
end
15-
}
10+
datalist id: 'foo', class: 'bar' do
11+
plain 'Example Text'
12+
end
1613
end
17-
1814
end
1915

2016
visit '/example'
21-
2217
static_output = page.html
23-
2418
expected_static_output = <<~HTML
25-
<datalist id="foo" class="bar">Example Text</datalist>
19+
<datalist id="foo" class="bar">Example Text</datalist>
2620
HTML
27-
2821
expect(stripped(static_output)).to include(stripped(expected_static_output))
2922
end
3023

spec/0.8/components/dd_spec.rb

Lines changed: 16 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -6,58 +6,44 @@
66
it 'Example 1 - yield, no options[:text]' do
77

88
class ExamplePage < Matestack::Ui::Page
9-
109
def response
11-
components {
12-
# simple dd tag
13-
dd do
14-
plain 'This is simple dd text'
15-
end
16-
17-
# enhanced dd tag
18-
dd id: 'my-id', class: 'my-class' do
19-
plain 'This is a enhanced dd with text'
20-
end
21-
}
10+
# simple dd tag
11+
dd do
12+
plain 'This is simple dd text'
13+
end
14+
# enhanced dd tag
15+
dd id: 'my-id', class: 'my-class' do
16+
plain 'This is a enhanced dd with text'
17+
end
2218
end
23-
2419
end
2520

2621
visit '/example'
2722
static_output = page.html
28-
2923
expected_static_output = <<~HTML
30-
<dd>This is simple dd text</dd>
31-
<dd id="my-id" class="my-class">This is a enhanced dd with text</dd>
24+
<dd>This is simple dd text</dd>
25+
<dd id="my-id" class="my-class">This is a enhanced dd with text</dd>
3226
HTML
3327
expect(stripped(static_output)).to include(stripped(expected_static_output))
3428
end
3529

3630
it 'Example 2 - render options[:text]' do
3731

3832
class ExamplePage < Matestack::Ui::Page
39-
4033
def response
41-
components {
42-
# simple dd tag
43-
dd text: 'This is simple dd text'
44-
45-
# enhanced dd tag
46-
dd id: 'my-id', class: 'my-class', text: 'This is a enhanced dd with text'
47-
}
34+
# simple dd tag
35+
dd text: 'This is simple dd text'
36+
# enhanced dd tag
37+
dd id: 'my-id', class: 'my-class', text: 'This is a enhanced dd with text'
4838
end
49-
5039
end
5140

5241
visit '/example'
53-
5442
static_output = page.html
55-
5643
expected_static_output = <<~HTML
57-
<dd>This is simple dd text</dd>
58-
<dd id="my-id" class="my-class">This is a enhanced dd with text</dd>
44+
<dd>This is simple dd text</dd>
45+
<dd id="my-id" class="my-class">This is a enhanced dd with text</dd>
5946
HTML
60-
6147
expect(stripped(static_output)).to include(stripped(expected_static_output))
6248
end
6349

spec/0.8/components/del_spec.rb

Lines changed: 16 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -6,60 +6,44 @@
66
it 'Example 1 - yield, no options[:text]' do
77

88
class ExamplePage < Matestack::Ui::Page
9-
109
def response
11-
components {
12-
# simple del
13-
del cite: 'http://citeurl.com', datetime: '2019-01-01T00:00:00Z' do
14-
plain 'I am simple'
15-
end
16-
17-
# enhanced del
18-
del id: 'my-id', class: 'my-class', cite: 'http://citeurl.com', datetime: '2019-01-01T00:00:00Z' do
19-
plain 'I am enhanced'
20-
end
21-
}
10+
# simple del
11+
del cite: 'http://citeurl.com', datetime: '2019-01-01T00:00:00Z' do
12+
plain 'I am simple'
13+
end
14+
# enhanced del
15+
del id: 'my-id', class: 'my-class', cite: 'http://citeurl.com', datetime: '2019-01-01T00:00:00Z' do
16+
plain 'I am enhanced'
17+
end
2218
end
23-
2419
end
2520

2621
visit '/example'
27-
2822
static_output = page.html
29-
3023
expected_static_output = <<~HTML
31-
<del cite=\"http://citeurl.com\" datetime=\"2019-01-01T00:00:00Z\">I am simple</del>
32-
<del cite=\"http://citeurl.com\" datetime=\"2019-01-01T00:00:00Z\" id=\"my-id\" class=\"my-class\">I am enhanced</del>
24+
<del cite=\"http://citeurl.com\" datetime=\"2019-01-01T00:00:00Z\">I am simple</del>
25+
<del cite=\"http://citeurl.com\" datetime=\"2019-01-01T00:00:00Z\" id=\"my-id\" class=\"my-class\">I am enhanced</del>
3326
HTML
34-
3527
expect(stripped(static_output)).to include(stripped(expected_static_output))
3628
end
3729

3830
it 'Example 2 - render options[:text]' do
3931

4032
class ExamplePage < Matestack::Ui::Page
41-
4233
def response
43-
components {
44-
# simple del
45-
del cite: 'http://citeurl.com', datetime: '2019-01-01T00:00:00Z', text: 'I am simple'
46-
47-
# enhanced del
48-
del id: 'my-id', class: 'my-class', cite: 'http://citeurl.com', datetime: '2019-01-01T00:00:00Z', text: 'I am enhanced'
49-
}
34+
# simple del
35+
del cite: 'http://citeurl.com', datetime: '2019-01-01T00:00:00Z', text: 'I am simple'
36+
# enhanced del
37+
del id: 'my-id', class: 'my-class', cite: 'http://citeurl.com', datetime: '2019-01-01T00:00:00Z', text: 'I am enhanced'
5038
end
51-
5239
end
5340

5441
visit '/example'
55-
5642
static_output = page.html
57-
5843
expected_static_output = <<~HTML
59-
<del cite=\"http://citeurl.com\" datetime=\"2019-01-01T00:00:00Z\">I am simple</del>
60-
<del cite=\"http://citeurl.com\" datetime=\"2019-01-01T00:00:00Z\" id=\"my-id\" class=\"my-class\">I am enhanced</del>
44+
<del cite=\"http://citeurl.com\" datetime=\"2019-01-01T00:00:00Z\">I am simple</del>
45+
<del cite=\"http://citeurl.com\" datetime=\"2019-01-01T00:00:00Z\" id=\"my-id\" class=\"my-class\">I am enhanced</del>
6146
HTML
62-
6347
expect(stripped(static_output)).to include(stripped(expected_static_output))
6448
end
6549

spec/0.8/components/details_summary_spec.rb

Lines changed: 26 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -5,47 +5,38 @@
55
it 'Example 1' do
66
class ExamplePage < Matestack::Ui::Page
77
def response
8-
components {
9-
# basic
10-
details do
11-
summary text: 'Hello'
12-
paragraph text: 'World!'
13-
end
14-
15-
# without summary
16-
details id: 'foo' do
17-
plain "Hello World!"
18-
end
19-
20-
# enhanced
21-
details id: 'detail_id', class: 'detail_class' do
22-
summary id: 'summary_id', class: 'summary_class', text: 'Hello'
23-
paragraph text: 'World!'
24-
end
25-
}
8+
# basic
9+
details do
10+
summary text: 'Hello'
11+
paragraph text: 'World!'
12+
end
13+
# without summary
14+
details id: 'foo' do
15+
plain "Hello World!"
16+
end
17+
# enhanced
18+
details id: 'detail_id', class: 'detail_class' do
19+
summary id: 'summary_id', class: 'summary_class', text: 'Hello'
20+
paragraph text: 'World!'
21+
end
2622
end
2723
end
28-
visit '/example'
2924

25+
visit '/example'
3026
static_output = page.html
31-
3227
expected_static_output = <<~HTML
33-
34-
<details>
35-
<summary>Hello</summary>
36-
<p>World!</p>
37-
</details>
38-
39-
<details id="foo">
40-
Hello World!
41-
</details>
42-
43-
<details id="detail_id" class="detail_class">
44-
<summary id="summary_id" class="summary_class">Hello</summary>
45-
<p>World!</p>
46-
</details>
28+
<details>
29+
<summary>Hello</summary>
30+
<p>World!</p>
31+
</details>
32+
<details id="foo">
33+
Hello World!
34+
</details>
35+
<details id="detail_id" class="detail_class">
36+
<summary id="summary_id" class="summary_class">Hello</summary>
37+
<p>World!</p>
38+
</details>
4739
HTML
48-
4940
expect(stripped(static_output)).to include(stripped(expected_static_output))
5041
end
5142
end

0 commit comments

Comments
 (0)