Merge pull request #451 from matestack/20200824_use-html-attributes-and-properties-everywhere

Use html attributes and properties implementation everywhere

Author: NdotHenning

CHANGELOG.md

@@ -1,4 +1,4 @@
-%abbr{@tag_attributes}
+%abbr{ html_attributes }
   - if text.blank? && block_given?
     = yield
   - else

app/concepts/matestack/ui/core/abbr/abbr.haml

@@ -1,13 +1,5 @@
 module Matestack::Ui::Core::Abbr
   class Abbr < Matestack::Ui::Core::Component::Static
-    requires :title
     optional :text
-
-    def setup
-      @tag_attributes.merge!({
-        "title": title
-      })
-    end
-
   end
 end

app/concepts/matestack/ui/core/abbr/abbr.rb

@@ -1,3 +1,3 @@
-%a{@tag_attributes, "@click.prevent": "perform", "href": action_path}
+%a{ html_attributes, "@click.prevent": "perform", "href": action_path }
   - if block_given?
     = yield

app/concepts/matestack/ui/core/action/action.haml

@@ -1,6 +1,6 @@
-%component{dynamic_tag_attributes}
+%component{ dynamic_tag_attributes }
   %div
-    %div{"v-if": "asyncTemplate == null"}
+    %div{ "v-if": "asyncTemplate == null" }
       = render_content
-    %div{"v-if": "asyncTemplate != null"}
-      %v-runtime-template{":template":"asyncTemplate"}
+    %div{ "v-if": "asyncTemplate != null" }
+      %v-runtime-template{ ":template":"asyncTemplate" }

app/concepts/matestack/ui/core/actionview/dynamic.haml

@@ -1,5 +1,5 @@
-%address{@tag_attributes}
-  - if text.nil? && block_given?
+%address{ html_attributes }
+  - if text.blank? && block_given?
     = yield
   - else
     = text

app/concepts/matestack/ui/core/address/address.haml

@@ -1 +1 @@
-%area{@tag_attributes}
+%area{ html_attributes, "coords": coords.join(',') }

app/concepts/matestack/ui/core/area/area.haml

@@ -1,20 +1,6 @@
 module Matestack::Ui::Core::Area
   class Area < Matestack::Ui::Core::Component::Static
-    optional :alt, :coords, :download, :href, :hreflang, :media, :rel, :shape, :target, :type
-    
-    def setup
-      @tag_attributes.merge!({
-        alt: alt,
-        coords: coords.join(','),
-        download: download,
-        href: href,
-        hreflang: hreflang,
-        media: media,
-        rel: rel,
-        shape: shape,
-        target: target,
-        type: type
-      })
-    end
+    html_attributes :alt, :download, :href, :hreflang, :media, :rel, :shape, :target, :type
+    optional :coords
   end
 end

app/concepts/matestack/ui/core/area/area.rb

@@ -1,5 +1,5 @@
-%article{@tag_attributes}
-  - if options[:text].nil? && block_given?
+%article{ html_attributes }
+  - if text.nil? && block_given?
     = yield
   - else
-    = options[:text]
+    = text

app/concepts/matestack/ui/core/article/article.haml

@@ -1,5 +1,5 @@
 module Matestack::Ui::Core::Article
   class Article < Matestack::Ui::Core::Component::Static
-
+    optional :text
   end
 end