[REFACTOR] refactor vue_js_component_name implementation, make it inheritable

Author: Nils Henning

app/concepts/matestack/ui/core/component/dynamic.rb

@@ -24,14 +24,15 @@ def dynamic_tag_attributes
     end
 
     def get_vue_js_name
-      if @vue_js_component_name.present?
-        @vue_js_component_name
-      else
-        self.class.vue_js_name
-      end
+      self.class.vue_js_name
     end
 
     class << self
+
+      def inherited(subclass)
+        subclass.vue_js_component_name vue_js_name unless self == Matestack::Ui::Core::Component::Dynamic
+      end
+
       def vue_js_component_name(name)
         @vue_js_name = name.to_s
       end

app/concepts/matestack/ui/core/isolate/isolate.rb

@@ -6,10 +6,6 @@ class Isolate < Matestack::Ui::Core::Component::Dynamic
     def initialize(*args)
       super
       @public_options = args.map { |hash| hash[:public_options] }[0]
-      # using this instance var here as users inherit from this class and would need
-      # to use `vue_js_component_name "matestack-ui-core-isolate"` in their components
-      # which is not convinient
-      @vue_js_component_name = "matestack-ui-core-isolate"
     end
 
     def public_options

spec/test/components/dynamic/isolate/isolate_spec.rb

@@ -70,7 +70,6 @@ def response
     end
 
     visit "/example"
-
     # used on page
     expect(page).to have_xpath('//div[@id="page-div"]/div[@class="matestack-isolated-component-container"]/div[@class="matestack-isolated-component-wrapper"]/div[@class="some-isolated-component"]/span[@id="text" and contains(.,"some isolated compenent")]')
 
@@ -161,7 +160,7 @@ def response
     class SomeNonAuthorizedIsolatedComponent < Matestack::Ui::IsolatedComponent
 
       def response
-        span text: "should't work, because authorized? method is not implemented"
+        span text: "shouldn't work, because authorized? method is not implemented"
       end
 
 
@@ -182,19 +181,19 @@ def response
     visit "/example"
 
     expect(page).to have_content("page!") # rest of the page still works
-    expect(page).not_to have_content("should't work, because authorized? method is not implemented")
+    expect(page).not_to have_content("shouldn't work, because authorized? method is not implemented")
     expect(page).not_to have_content("please implement the `authorized? method") # async request gets that error, so it's not visible
 
     visit "/example?component_class=SomeNonAuthorizedIsolatedComponent"
 
     expect(page).not_to have_content("page!") # page is not requested
-    expect(page).not_to have_content("should't work, because authorized? method is not implemented")
+    expect(page).not_to have_content("shouldn't work, because authorized? method is not implemented")
     expect(page).to have_content("please implement the `authorized? method")
 
     class SomeForbiddenIsolatedComponent < Matestack::Ui::IsolatedComponent
 
       def response
-        span text: "should't work, because authorized? method is returning false"
+        span text: "shouldn't work, because authorized? method is returning false"
       end
 
       def authorized?
@@ -218,13 +217,13 @@ def response
     visit "/example"
 
     expect(page).to have_content("page!") # rest of the page still works
-    expect(page).not_to have_content("should't work, because authorized? method is returning false")
+    expect(page).not_to have_content("shouldn't work, because authorized? method is returning false")
     expect(page).not_to have_content("not authorized") # async request gets that error, so it's not visible
 
     visit "/example?component_class=SomeForbiddenIsolatedComponent"
 
     expect(page).not_to have_content("page!") # page is not requested
-    expect(page).not_to have_content("should't work, because authorized? method is returning false")
+    expect(page).not_to have_content("shouldn't work, because authorized? method is returning false")
     expect(page).to have_content("not authorized")
 
 
@@ -302,7 +301,6 @@ def response
 
     visit "/example"
 
-    # sleep
     page_timestamp = page.find('#page-timestamp').text.to_i
     component_timestamp = page.find('#isolated-component-timestamp').text.to_i