Merge pull request #445 from matestack/adjust_params_access_for_components

Add params method to base component

Author: jonasjabari

app/concepts/matestack/ui/core/component/base.rb

@@ -67,6 +67,7 @@ def initialize(model = nil, options = {})
 
       # TODO: no idea why this is called `url_params` it contains
       # much more than this e.g. almost all params so maybe rename it?
+      # will be deprecated in future releases. use the `params` method in order to access query params
       @url_params = context&.[](:params)&.except(:action, :controller, :component_key, :matestack_context)
 
       # used when creating the child component tree
@@ -156,6 +157,11 @@ def prepare
       true
     end
 
+    # access params like you would do on rails views and controllers
+    def params
+      context[:params]
+    end
+
     ## ------------------ Rendering ----------------
     # Invoked by Cell::ViewModel from Rendering#call
     #

app/concepts/matestack/ui/core/component/dynamic.rb

@@ -15,7 +15,7 @@ def dynamic_tag_attributes
       attrs = {
         "is": self.class.vue_js_name,
         "ref": component_id,
-        ":params":  @url_params.to_json,
+        ":params":  params.except(:controller, :action).to_json,
         ":component-config": @component_config.to_json,
         "inline-template": true,
       }
@@ -32,6 +32,6 @@ def vue_js_name
         @vue_js_name ||= self.name.split(/(?=[A-Z])/).join("-").downcase.gsub("::", "")
       end
     end
-    
+
   end
 end

spec/0.8/base/core/component/url_params_access_spec.rb

@@ -35,7 +35,7 @@ def response
             div id: "my-component" do
               # TODO: rather than accessing plain instance variables
               # I'd recommend a method based interface (easier to adjust, test, maintain if state is moved elsewhere etc.)
-              plain @url_params[:foo]
+              plain params[:foo]
             end
         end
 

spec/0.8/base/core/page/url_params_access_spec.rb

@@ -29,15 +29,15 @@ class ExamplePage < Matestack::Ui::Page
 
       def response
         div do
-          plain "Request Params: #{@url_params}"
+          plain "foo: #{params[:foo]}"
         end
       end
 
     end
 
     visit "page_url_params_access_spec/page_test/?foo=bar"
 
-    expect(page).to have_content('Request Params: {"foo"=>"bar"}')
+    expect(page).to have_content("foo: bar")
 
   end