Skip to content

Commit dfad7db

Browse files
committed
fixed some wording and added some information
1 parent b066ec4 commit dfad7db

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

CHANGELOG.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,12 @@
1414
* added `hr` component, pull #49, (@michaelrevans)
1515
* allow actions to accept id and class attributes, issue #44, pull #50 (@michaelrevans)
1616

17-
1817
### Breaking changes for core developers
1918

20-
* namespaced core components using `Matestack::Ui::Core` module/folder
19+
* namespaced core components using `Matestack::Ui::Core` module/folder, pull #64 (@jonasjabari)
2120
* simplified core components folder structure, (aligned with issue #39), pull #64 (@jonasjabari)
22-
* changed vue.js component naming
23-
* add-on engine components now need `Matestack::Ui` namespacing
21+
* changed vue.js component naming, (aligned with issue #41), pull #64 (@jonasjabari)
22+
* add-on engine components now need `Matestack::Ui` namespacing, pull #64 (@jonasjabari)
2423

2524
### Improvements for core developers
2625

@@ -197,13 +196,13 @@ class Pages::ExampleApp::ExamplePage < Matestack::Ui::Page
197196
end
198197
```
199198

200-
The reasons why decide to resolve core components a bit different than custom components are simple:
199+
The reasons why we decided to resolve core components a bit different than custom components are simple:
201200
* we want to make it as easy as possible to create custom components
202201
* we therefore removed the obligatory `Cell` module
203202
* we do not want to force the user to create a subfolder (and therefore module/namespace) in their `components` folder resulting in a class like:
204203
`Components::Card::Card`. It should be as simple as `Components::Card` which is good and intuitive!
205204
* if we would use that simple approach for all our core components, it would lead to a messy code base, as all component cells, views and javascripts live in one big folder.
206-
* we therefore enforce more structure inside the core, using a subfolder for each components within `app/concepts/matestack/ui/core` resulting in class name for component like: `Matestack::Ui::Core::Div::Div` (double DIV at the end --> subfolder(module name) :: class)
205+
* we therefore enforce more structure inside the core, using a subfolder for each component within `app/concepts/matestack/ui/core` resulting in a class name for a component like: `Matestack::Ui::Core::Div::Div` (double DIV at the end --> subfolder(module name) :: class)
207206

208207
#### Changed vue.js component naming
209208

0 commit comments

Comments
 (0)