|
14 | 14 | * added `hr` component, pull #49, (@michaelrevans)
|
15 | 15 | * allow actions to accept id and class attributes, issue #44, pull #50 (@michaelrevans)
|
16 | 16 |
|
17 |
| - |
18 | 17 | ### Breaking changes for core developers
|
19 | 18 |
|
20 |
| -* namespaced core components using `Matestack::Ui::Core` module/folder |
| 19 | +* namespaced core components using `Matestack::Ui::Core` module/folder, pull #64 (@jonasjabari) |
21 | 20 | * simplified core components folder structure, (aligned with issue #39), pull #64 (@jonasjabari)
|
22 |
| -* changed vue.js component naming |
23 |
| -* add-on engine components now need `Matestack::Ui` namespacing |
| 21 | +* changed vue.js component naming, (aligned with issue #41), pull #64 (@jonasjabari) |
| 22 | +* add-on engine components now need `Matestack::Ui` namespacing, pull #64 (@jonasjabari) |
24 | 23 |
|
25 | 24 | ### Improvements for core developers
|
26 | 25 |
|
@@ -197,13 +196,13 @@ class Pages::ExampleApp::ExamplePage < Matestack::Ui::Page
|
197 | 196 | end
|
198 | 197 | ```
|
199 | 198 |
|
200 |
| -The reasons why decide to resolve core components a bit different than custom components are simple: |
| 199 | +The reasons why we decided to resolve core components a bit different than custom components are simple: |
201 | 200 | * we want to make it as easy as possible to create custom components
|
202 | 201 | * we therefore removed the obligatory `Cell` module
|
203 | 202 | * we do not want to force the user to create a subfolder (and therefore module/namespace) in their `components` folder resulting in a class like:
|
204 | 203 | `Components::Card::Card`. It should be as simple as `Components::Card` which is good and intuitive!
|
205 | 204 | * if we would use that simple approach for all our core components, it would lead to a messy code base, as all component cells, views and javascripts live in one big folder.
|
206 |
| - * we therefore enforce more structure inside the core, using a subfolder for each components within `app/concepts/matestack/ui/core` resulting in class name for component like: `Matestack::Ui::Core::Div::Div` (double DIV at the end --> subfolder(module name) :: class) |
| 205 | + * we therefore enforce more structure inside the core, using a subfolder for each component within `app/concepts/matestack/ui/core` resulting in a class name for a component like: `Matestack::Ui::Core::Div::Div` (double DIV at the end --> subfolder(module name) :: class) |
207 | 206 |
|
208 | 207 | #### Changed vue.js component naming
|
209 | 208 |
|
|
0 commit comments