Merge pull request #263 from bdlb77/label_component_bug

Label component bug

Author: pascalwengerter

app/concepts/matestack/ui/core/label/label.rb

@@ -1,5 +1,10 @@
 module Matestack::Ui::Core::Label
   class Label < Matestack::Ui::Core::Component::Static
-
+    def setup
+      @tag_attributes.merge!({
+        for: options[:for],
+        form: options[:form]
+      })
+    end
   end
 end

docs/components/label.md

@@ -1,3 +1,45 @@
 # matestack core component: Label
 
 Show [specs](/spec/usage/components/label_spec.rb)
+
+
+The HTML label tag implemented in ruby.
+
+## Parameters
+
+This component can take 3 optional configuration params and optional content.
+
+#### # id (optional)
+Expects a string with all ids the div should have.
+
+#### # class (optional)
+Expects a string with all classes the div should have.
+
+#### # for (optional)
+Expects a string that binds the label to a given form element (To match `id` of form element)
+
+#### # form (optional)
+Expects a string that specifies which form or forms the label belongs to.
+
+## Example
+
+```ruby
+label id: "foo", class: "bar", for: 'input_id', form: 'form1' do
+  plain 'Label For Element' # optional content
+end
+
+label id: 'foo', form: 'form1', text: "Label for form with id='form1'"
+
+```
+
+returns
+
+```html
+<label for="input_id" id="foo" class="bar">
+  Label For Element
+</label>
+
+<label form="form1" id="foo">Label for form with id='form1'</label>
+
+```
+

spec/usage/components/label_spec.rb

@@ -13,9 +13,12 @@ def response
           label text: 'I am simple'
 
           # enhanced label
-          label id: 'my-id', class: 'my-class' do
+          label id: 'my-id', for: 'label for something', class: 'my-class' do
             plain 'I am enhanced'
           end
+
+          # with form attribute
+          label id: 'form_label', for: "form", form: 'form1', text: 'Label for Form1'
         }
       end
 
@@ -27,7 +30,9 @@ def response
 
     expected_static_output = <<~HTML
     <label>I am simple</label>
-    <label id="my-id" class="my-class">I am enhanced</label>
+    <label for="label for something" id="my-id" class="my-class">I am enhanced</label>
+
+    <label for="form" form="form1" id="form_label" >Label for Form 1</label>
     HTML
 
     expect(stripped(static_output)).to include(stripped(expected_static_output))