Skip to content

Commit 9a73ede

Browse files
authored
Merge pull request #34 from math-comp/fix-9.0
fix: s/9.00/9.0/ and (input Docker image, output Docker tag) for (coqorg/coq, rocq/rocq-prover)
2 parents ac3b402 + 5e05f20 commit 9a73ede

File tree

2 files changed

+39
-16
lines changed

2 files changed

+39
-16
lines changed

images.yml

Lines changed: 37 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,39 +4,61 @@ active: true
44
gitlab_ci_tags:
55
- 'large'
66
args:
7-
COQ_TAG: '{matrix[coq]}-ocaml-4.14-flambda'
7+
COQ_TAG: 'coqorg/coq:{matrix[coq]}-ocaml-4.14-flambda'
88
MATHCOMP_VERSION: '{matrix[mathcomp]}'
99
docker_repo: 'mathcomp/mathcomp'
1010
images:
1111
# TODO: Copy and Uncomment at next mathcomp (beta or stable) release
1212
# - matrix:
13-
# coq: ['dev', '8.16', '8.15', '8.14', '8.13']
13+
# rocq: ['dev', '8.16', '8.15', '8.14', '8.13']
1414
# mathcomp: ['1.16+beta1']
1515
# build:
16-
# # keyword for docker-keeper's trigger (from docker-coq CI)
16+
# # keyword for docker-keeper's trigger (from docker-rocq CI)
1717
# keywords:
18-
# - '{matrix[coq]}'
18+
# - '{matrix[rocq]}'
1919
# context: './mathcomp'
2020
# dockerfile: './single/Dockerfile'
21+
# args:
22+
# # Use docker-keeper/bash_formatter.py syntax to achieve the following:
23+
# # If matrix[rocq] matches "8.*", prepend the version with "coqorg/coq:",
24+
# # otherwise, prepend the version with "rocq/rocq-prover:"
25+
# COQ_TAG: '{matrix[rocq][/#/,][//,8.*/coqorg/coq:][//,*/rocq/rocq-prover:]}{matrix[rocq]}-ocaml-4.14-flambda'
2126
# tags:
22-
# - tag: '{matrix[mathcomp][//+/-]}-coq-{matrix[coq]}'
23-
# # TODO at release time: Uncomment "latest-coq-*" and Remove "[//+/-]"
24-
# # TODO after next release: Remove "latest-coq-*"
25-
# # - tag: 'latest-coq-{matrix[coq]}'
27+
# - tag: '{matrix[mathcomp][//+/-]}-rocq-prover-{matrix[rocq]}'
28+
# if: '{matrix[rocq][.*]} != 8'
29+
# - tag: '{matrix[mathcomp][//+/-]}-coq-{matrix[rocq]}'
30+
# if: '{matrix[rocq][.*]} == 8'
31+
# # TODO at release time: Remove "[//+/-]" and Uncomment "latest-*"
32+
# # TODO after next release: Remove "latest-*"
33+
# # - tag: 'latest-rocq-prover-{matrix[rocq]}'
34+
# # if: '{matrix[rocq][.*]} != 8'
35+
# # - tag: 'latest-coq-{matrix[rocq]}'
36+
# # if: '{matrix[rocq][.*]} == 8'
2637

2738
- matrix:
28-
coq: ['dev', '9.00', '8.20', '8.19']
39+
rocq: ['dev', '9.0', '8.20', '8.19']
2940
mathcomp: ['2.4.0']
3041
build:
31-
# keyword for docker-keeper's trigger (from docker-coq CI)
42+
# keyword for docker-keeper's trigger (from docker-rocq CI)
3243
keywords:
33-
- '{matrix[coq]}'
44+
- '{matrix[rocq]}'
3445
context: './mathcomp'
3546
dockerfile: './single/Dockerfile'
47+
args:
48+
# Use docker-keeper/bash_formatter.py syntax to achieve the following:
49+
# If matrix[rocq] matches "8.*", prepend the version with "coqorg/coq:",
50+
# otherwise, prepend the version with "rocq/rocq-prover:"
51+
COQ_TAG: '{matrix[rocq][/#/,][//,8.*/coqorg/coq:][//,*/rocq/rocq-prover:]}{matrix[rocq]}-ocaml-4.14-flambda'
3652
tags:
37-
- tag: '{matrix[mathcomp][//+/-]}-coq-{matrix[coq]}'
38-
# TODO after next release: Remove "latest-coq-*"
39-
- tag: 'latest-coq-{matrix[coq]}'
53+
- tag: '{matrix[mathcomp]}-rocq-prover-{matrix[rocq]}'
54+
if: '{matrix[rocq][%.*]} != 8'
55+
- tag: '{matrix[mathcomp]}-coq-{matrix[rocq]}'
56+
if: '{matrix[rocq][%.*]} == 8'
57+
# TODO after next release: Remove "latest-*"
58+
- tag: 'latest-rocq-prover-{matrix[rocq]}'
59+
if: '{matrix[rocq][%.*]} != 8'
60+
- tag: 'latest-coq-{matrix[rocq]}'
61+
if: '{matrix[rocq][%.*]} == 8'
4062

4163
- matrix:
4264
coq: ['dev', '8.20', '8.19', '8.18', '8.17', '8.16']
@@ -75,7 +97,7 @@ images:
7597
- tag: '{matrix[mathcomp]}-coq-{matrix[coq]}'
7698

7799
- matrix:
78-
coq: ['dev', '8.20', '8.19', '8.18', '8.17', '8.16']
100+
coq: ['8.20', '8.19', '8.18', '8.17', '8.16']
79101
mathcomp: ['1.19.0']
80102
build:
81103
# keyword for docker-keeper's trigger (from docker-coq CI)

mathcomp/single/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
ARG COQ_TAG="dev"
2-
FROM coqorg/coq:${COQ_TAG}
2+
# hadolint ignore=DL3006
3+
FROM ${COQ_TAG}
34

45
ARG MATHCOMP_VERSION="dev"
56
ENV MATHCOMP_VERSION=${MATHCOMP_VERSION}

0 commit comments

Comments
 (0)