Codacy

Author: FilippoOlivo

pina/condition/condition.py

@@ -73,14 +73,14 @@ def __new__(cls, *args, **kwargs):
         sorted_keys = sorted(kwargs.keys())
         if sorted_keys == sorted(InputTargetCondition.__slots__):
             return InputTargetCondition(**kwargs)
-        elif sorted_keys == sorted(InputEquationCondition.__slots__):
+        if sorted_keys == sorted(InputEquationCondition.__slots__):
             return InputEquationCondition(**kwargs)
-        elif sorted_keys == sorted(DomainEquationCondition.__slots__):
+        if sorted_keys == sorted(DomainEquationCondition.__slots__):
             return DomainEquationCondition(**kwargs)
-        elif (
+        if (
             sorted_keys == sorted(DataCondition.__slots__)
             or sorted_keys[0] == DataCondition.__slots__[0]
         ):
             return DataCondition(**kwargs)
-        else:
-            raise ValueError(f"Invalid keyword arguments {kwargs.keys()}.")
+
+        raise ValueError(f"Invalid keyword arguments {kwargs.keys()}.")

pina/condition/data_condition.py

@@ -1,10 +1,9 @@
 import torch
-
+from torch_geometric.data import Data
 from . import ConditionInterface
 from ..label_tensor import LabelTensor
 from ..graph import Graph
 from ..utils import check_consistency
-from torch_geometric.data import Data
 
 
 class DataCondition(ConditionInterface):
@@ -66,26 +65,22 @@ def _get_subclass(input, conditional_variables):
         )
         if is_tensor_input:
             return TensorDataCondition
-        elif is_graph_input:
+        if is_graph_input:
             return GraphDataCondition
-        else:
-            raise ValueError(
-                "Invalid input types. "
-                "Please provide either torch.Tensor or Graph objects."
-            )
+
+        raise ValueError(
+            "Invalid input types. "
+            "Please provide either torch.Tensor or Graph objects."
+        )
 
 
 class TensorDataCondition(DataCondition):
     """
     DataCondition for torch.Tensor input data
     """
 
-    pass
-
 
 class GraphDataCondition(DataCondition):
     """
     DataCondition for Graph/Data input data
     """
-
-    pass

pina/condition/input_equation_condition.py

@@ -3,13 +3,12 @@
 """
 
 import torch
-
+from torch_geometric.data import Data
 from .condition_interface import ConditionInterface
 from ..label_tensor import LabelTensor
 from ..graph import Graph
 from ..utils import check_consistency
 from ..equation.equation_interface import EquationInterface
-from torch_geometric.data import Data
 
 
 class InputEquationCondition(ConditionInterface):
@@ -60,26 +59,21 @@ def _get_subclass(input, equation):
         )
         if is_tensor_input:
             return InputTensorEquationCondition
-        elif is_graph_input:
+        if is_graph_input:
             return InputGraphEquationCondition
-        else:
-            raise ValueError(
-                "Invalid input types. "
-                "Please provide either torch.Tensor or Graph objects."
-            )
+        raise ValueError(
+            "Invalid input types. "
+            "Please provide either torch.Tensor or Graph objects."
+        )
 
 
 class InputTensorEquationCondition(InputEquationCondition):
     """
     InputEquationCondition subclass for torch.Tensor input data.
     """
 
-    pass
-
 
 class InputGraphEquationCondition(InputEquationCondition):
     """
     InputEquationCondition subclass for Graph input data.
     """
-
-    pass

pina/condition/input_target_condition.py

@@ -3,11 +3,10 @@
 """
 
 import torch
-
+from torch_geometric.data import Data
 from .condition_interface import ConditionInterface
 from ..label_tensor import LabelTensor
 from ..graph import Graph
-from torch_geometric.data import Data
 
 
 class InputTargetCondition(ConditionInterface):
@@ -66,56 +65,39 @@ def _get_subclass(input, target):
 
         if is_tensor_input and is_tensor_target:
             return TensorInputTensorTargetCondition
-        elif is_tensor_input and is_graph_target:
+        if is_tensor_input and is_graph_target:
             return TensorInputGraphTargetCondition
-        elif is_graph_input and is_tensor_target:
+        if is_graph_input and is_tensor_target:
             return GraphInputTensorTargetCondition
-        elif is_graph_input and is_graph_target:
+        if is_graph_input and is_graph_target:
             return GraphInputGraphTargetCondition
-        else:
-            raise ValueError(
-                "Invalid input and target types. "
-                "Please provide either torch.Tensor or Graph objects."
-            )
-
-    def __init__(self, input, target):
-        """
-        TODO : add docstring
-        """
-        super().__init__()
-        self.input = input
-        self.target = target
+        raise ValueError(
+            "Invalid input and target types. "
+            "Please provide either torch.Tensor or Graph objects."
+        )
 
 
 class TensorInputTensorTargetCondition(InputTargetCondition):
     """
     InputTargetCondition subclass for torch.Tensor input and target data.
     """
 
-    pass
-
 
 class TensorInputGraphTargetCondition(InputTargetCondition):
     """
     InputTargetCondition subclass for torch.Tensor input and Graph/Data target
     data.
     """
 
-    pass
-
 
 class GraphInputTensorTargetCondition(InputTargetCondition):
     """
     InputTargetCondition subclass for Graph/Data input and torch.Tensor target
     data.
     """
 
-    pass
-
 
 class GraphInputGraphTargetCondition(InputTargetCondition):
     """
     InputTargetCondition subclass for Graph/Data input and target data.
     """
-
-    pass

pina/problem/abstract_problem.py

@@ -4,7 +4,6 @@
 from ..utils import check_consistency
 from ..domain import DomainInterface, CartesianDomain
 from ..condition.domain_equation_condition import DomainEquationCondition
-from ..condition import InputEquationCondition
 from copy import deepcopy
 from .. import LabelTensor
 from ..utils import merge_tensors