Incorporating review feedback

- Now use the `tmp_path` fixture to place the test netcdfs in the temp
  directory, removing the need for a tear down.
- Made one of the indexing operations use linspace for clarity.
- Manually blacked meta.py

Author: klapo

pydmd/costs.py

@@ -325,7 +325,8 @@ def calculate_lv_kern(window_length, corner_sharpness=None):
 
         lv_kern = (
             np.tanh(
-                corner_sharpness * np.arange(0, window_length) / window_length
+                corner_sharpness
+                * np.linspace(0, 1, window_length, endpoint=False)
             )
             - np.tanh(
                 corner_sharpness

pydmd/meta.py

@@ -12,7 +12,9 @@
 
 __project__ = "PyDMD"
 __title__ = "pydmd"
-__author__ = "Nicola Demo, Marco Tezzele, Francesco Andreuzzi, Sara Ichinaga, Karl Lapo"
+__author__ = (
+    "Nicola Demo, Marco Tezzele, Francesco Andreuzzi, Sara Ichinaga, Karl Lapo"
+)
 __copyright__ = "Copyright 2017-2024, PyDMD contributors"
 __license__ = "MIT"
 __version__ = "1.0.0"

tests/test_mrcosts.py

@@ -286,11 +286,13 @@ def test_omega_transforms():
         )
 
 
-def test_netcdf():
+def test_netcdf(tmp_path):
     """
     Test the round trip conversion of the mrCOSTS object to file in
     netcdf format and back to mrCOSTS.
     """
+    # Move the I/O tests to the temporary test directory.
+    os.chdir(tmp_path)
     mrc.to_netcdf("tests")
     file_list = glob.glob("*tests*.nc")
     mrc_from_file = mrCOSTS()
@@ -358,10 +360,3 @@ def test_plot_local_time_series():
 
     with raises(ValueError):
         _ = mrc.plot_local_time_series(0, 0, data=data.T)
-
-
-def test_tear_down():
-    """Remove the files generated in `test_netcdf`"""
-    file_list = glob.glob("*tests*.nc")
-    for f in file_list:
-        os.remove(f)