some slight corrections

Author: fsalmoir

pygem/igeshandler.py

@@ -32,7 +32,7 @@ class IgesHandler(fh.FileHandler):
 	:cvar list control_point_position: index of the first NURBS control point (or pole)
 		of each face of the iges file.
 	:cvar float tolerance: tolerance for the construction of the faces and wires 
-		in the write function.
+		in the write function. Default value is 1e-6.
 		
 	.. warning::
 
@@ -129,9 +129,7 @@ def write(self, mesh_points, filename, tolerance=None):
 
 		self.outfile = filename
 
-		if tolerance is None:
-			tolerance = self.tolerance
-		else:
+		if tolerance is not None:
 			self.tolerance = tolerance
 
 		# init the ouput file writer
@@ -180,7 +178,7 @@ def write(self, mesh_points, filename, tolerance=None):
 			# construct the deformed wire for the trimmed surfaces
 			wire_maker = BRepBuilderAPI_MakeWire()
 			tol = ShapeFix_ShapeTolerance()
-			brep = BRepBuilderAPI_MakeFace(occ_face.GetHandle(), tolerance).Face()
+			brep = BRepBuilderAPI_MakeFace(occ_face.GetHandle(), self.tolerance).Face()
 			brep_face = BRep_Tool.Surface(brep)
 
 			# cycle on the edges
@@ -192,7 +190,7 @@ def write(self, mesh_points, filename, tolerance=None):
 				# evaluating the new edge: same (u,v) coordinates, but different (x,y,x) ones
 				edge_phis_coordinates_aux = BRepBuilderAPI_MakeEdge(edge_uv_coordinates[0], brep_face)
 				edge_phis_coordinates = edge_phis_coordinates_aux.Edge()
-				tol.SetTolerance(edge_phis_coordinates, tolerance)
+				tol.SetTolerance(edge_phis_coordinates, self.tolerance)
 				wire_maker.Add(edge_phis_coordinates)
 				edge_explorer.Next()
 

tests/test_igeshandler.py

@@ -145,16 +145,16 @@ def test_iges_write_outfile_tolerance(self):
 		iges_handler = ih.IgesHandler()
 		mesh_points = iges_handler.parse('tests/test_datasets/test_pipe.iges')
 		outfilename = 'tests/test_datasets/test_pipe_out.iges'
-		iges_handler.write(mesh_points, outfilename, 1e-4)
-		assert iges_handler.tolerance == 1e-4
+		iges_handler.write(mesh_points, outfilename, 1e-3)
+		assert iges_handler.tolerance == 1e-3
 		os.remove(outfilename)
 
 
 	def test_iges_write_modified_tolerance(self):
 		iges_handler = ih.IgesHandler()
 		mesh_points = iges_handler.parse('tests/test_datasets/test_pipe.iges')
 		outfilename = 'tests/test_datasets/test_pipe_out.iges'
-		iges_handler.write(mesh_points, outfilename, 1e-4)
+		iges_handler.write(mesh_points, outfilename, 1e-3)
 		assert iges_handler.outfile == outfilename
 		os.remove(outfilename)