more tests

Author: galabovaa

.bazelrc

@@ -11,3 +11,17 @@ build:tsan --copt -O1
 build:tsan --copt -g
 build:tsan --copt -fno-omit-frame-pointer
 build:tsan --linkopt -fsanitize=thread
+
+build:lsan --strip=never
+build:lsan --copt -fsanitize=leak
+build:lsan --copt -O1
+build:lsan --copt -g
+build:lsan --copt -fno-omit-frame-pointer
+build:lsan --linkopt -fsanitize=leak
+
+build:ubsan --strip=never
+build:ubsan --copt -fsanitize=undefined
+build:ubsan --copt -O1
+build:ubsan --copt -g
+build:ubsan --copt -fno-omit-frame-pointer
+build:ubsan --linkopt -fsanitize=undefined

.github/workflows/sanitizers-bazel.yml

@@ -3,7 +3,33 @@ name: sanitizers-bazel
 on: [push, pull_request]
 
 jobs:
-  bazel:
+  asan:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: bazelbuild/setup-bazelisk@v3
+
+      - name: Bazel clean
+        run: bazel clean
+      
+      - name: Bazel build
+        run: bazel build -c dbg --config=asan //...
+      
+      - name: Bazel test
+        run: bazel test -c dbg --config=asan --runs_per_test 100 //...
+
+      - name: Upload bazel-testlogs
+        uses: actions/upload-artifact@v4
+        with:
+          name: bazel-testlogs-asan
+          path: bazel-testlogs/
+
+  tsan:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -26,5 +52,57 @@ jobs:
       - name: Upload bazel-testlogs
         uses: actions/upload-artifact@v4
         with:
-          name: bazel-testlogs
+          name: bazel-testlogs-tsan
+          path: bazel-testlogs/
+          
+  lsan:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: bazelbuild/setup-bazelisk@v3
+
+      - name: Bazel clean
+        run: bazel clean
+      
+      - name: Bazel build
+        run: bazel build -c dbg --config=lsan //...
+      
+      - name: Bazel test
+        run: bazel test -c dbg --config=lsan --runs_per_test 100 //...
+
+      - name: Upload bazel-testlogs
+        uses: actions/upload-artifact@v4
+        with:
+          name: bazel-testlogs-lsan
+          path: bazel-testlogs/
+          
+  ubsan:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: bazelbuild/setup-bazelisk@v3
+
+      - name: Bazel clean
+        run: bazel clean
+      
+      - name: Bazel build
+        run: bazel build -c dbg --config=ubsan //...
+      
+      - name: Bazel test
+        run: bazel test -c dbg --config=ubsan --runs_per_test 100 //...
+
+      - name: Upload bazel-testlogs
+        uses: actions/upload-artifact@v4
+        with:
+          name: bazel-testlogs-ubsan
           path: bazel-testlogs/

CMakeLists.txt

@@ -585,7 +585,22 @@ elseif (DEBUG_MEMORY STREQUAL "Leak")
     set (CMAKE_EXE_LINKER_FLAGS_DEBUG "${CMAKE_EXE_LINKER_FLAGS_DEBUG} -fsanitize=leak,undefined \
         -fno-omit-frame-pointer ")
   endif()
+elseif (DEBUG_MEMORY STREQUAL "Memory")
+  if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+    set (CMAKE_CXX_FLAGS_RELWITHDEBINFO "${CMAKE_CXX_FLAGS_RELWITHDEBINFO} \
+        -fsanitize=memory \
+        -fno-omit-frame-pointer")
+    set (CMAKE_EXE_LINKER_FLAGS_RELWITHDEBINFO "${CMAKE_EXE_LINKER_FLAGS_RELWITHDEBINFO} \
+        -fsanitize=memory \
+        -fno-omit-frame-pointer")
+    set (CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -fsanitize=memory \
+        -fno-omit-frame-pointer ")
+    set (CMAKE_EXE_LINKER_FLAGS_DEBUG "${CMAKE_EXE_LINKER_FLAGS_DEBUG} -fsanitize=memory \
+        -fno-omit-frame-pointer ")
 
+  else()
+    message(FATAL_ERROR "Memory sanitizer only available with clang.")
+  endif()
 endif()
 
 # HiGHS coverage update in progress

check/TestHighsParallel.cpp

@@ -24,10 +24,18 @@ int64_t fib(const int64_t n) {
   if (n <= 20) return fib_sequential(n);
 
   int64_t n1;
-  parallel::spawn([&]() { n1 = fib(n - 1); });
+  parallel::spawn([&]() { 
+    n1 = fib(n - 1); 
+    TSAN_ANNOTATE_HAPPENS_BEFORE(&n1);
+  });
+
   int64_t n2 = fib(n - 2);
+  TSAN_ANNOTATE_HAPPENS_BEFORE(&n2);
+
   parallel::sync();
 
+  TSAN_ANNOTATE_HAPPENS_AFTER(&n1);
+  TSAN_ANNOTATE_HAPPENS_AFTER(&n2);
   // printf("fib(%ld) = %ld + %ld = %ld\n", n, n1, n2, n1 + n2);
   return n1 + n2;
 }