Merge pull request ERGO-Code#2295 from ERGO-Code/valgrind-ipx

valgrind tests

Author: galabovaa

.github/workflows/valgrind.yml

@@ -0,0 +1,104 @@
+name: valgrind
+
+on: [push, pull_request]
+
+jobs:
+  unit_tests:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+
+    steps:
+      - uses: actions/checkout@v4
+      
+      - name: Install Valgrind
+        run: sudo apt-get update && sudo apt-get install valgrind
+
+      - name: Create Build Environment
+        run: cmake -E make_directory ${{runner.workspace}}/build
+
+      - name: Configure CMake
+        shell: bash
+        working-directory: ${{runner.workspace}}/build
+        run: cmake $GITHUB_WORKSPACE -DCMAKE_BUILD_TYPE=Debug -DALL_TESTS=ON
+
+      - name: Build
+        working-directory: ${{runner.workspace}}/build
+        shell: bash
+        run: |
+          cmake --build . --parallel 
+
+      - name: Test
+        working-directory: ${{runner.workspace}}/build
+        shell: bash
+        run: |
+          valgrind \
+          --leak-check=full \
+          --show-leak-kinds=all \
+          --track-origins=yes \
+          -s \
+          ./bin/unit_tests \
+          2>&1 | tee logfile
+
+      - name: Check log for Errors
+        working-directory: ${{runner.workspace}}/build
+        shell: bash
+        run: |
+          cat logfile
+          OUTPUT='ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)'
+          if grep -q "$OUTPUT" logfile; then
+            exit 0
+          fi
+          exit 1
+
+  instance_tests:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Valgrind
+        run: sudo apt-get update && sudo apt-get install valgrind
+      
+      - name: Create Build Environment
+        run: cmake -E make_directory ${{runner.workspace}}/build
+
+      - name: Configure CMake All
+        shell: bash
+        working-directory: ${{runner.workspace}}/build
+        run: cmake $GITHUB_WORKSPACE -DCMAKE_BUILD_TYPE=Debug -DALL_TESTS=ON
+
+      - name: Build All
+        working-directory: ${{runner.workspace}}/build
+        shell: bash
+        run: |
+          cmake --build . --parallel 
+
+      - name: Test
+        working-directory: ${{runner.workspace}}/build
+        shell: bash
+        run: |
+          valgrind \
+          --leak-check=full \
+          --show-leak-kinds=all \
+          --track-origins=yes \
+          -s \
+          ctest -E unit.* \
+          --timeout 1000 \
+          --output-on-failure \
+          2>&1 | tee logfile2
+
+      - name: Check log for Errors
+        working-directory: ${{runner.workspace}}/build
+        shell: bash
+        run: |
+          cat logfile2
+          OUTPUT='ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)'
+          if grep -q "$OUTPUT" logfile2; then
+            exit 0
+          fi
+          exit 1

check/TestIpx.cpp

@@ -8,6 +8,8 @@
 #include "lp_data/HighsStatus.h"
 #include "parallel/HighsParallel.h"
 
+#include "Highs.h"
+
 // Example for using IPX from its C++ interface. The program solves the Netlib
 // problem afiro.
 
@@ -45,6 +47,7 @@ TEST_CASE("test-ipx", "[highs_ipx]") {
   ipx::Parameters parameters;
   if (!dev_run) parameters.display = 0;
   parameters.highs_logging = false;
+  parameters.timeless_log = false;
   lps.SetParameters(parameters);
 
   // Solve the LP.
@@ -87,4 +90,8 @@ TEST_CASE("test-ipx", "[highs_ipx]") {
   REQUIRE(fabs(ipx_col_value[11] - 339.9) < 1);
 
   (void)(info);  // surpress unused variable.
+
+  // hack to reset global scheduler
+  Highs h;
+  h.resetGlobalScheduler(true);
 }

check/TestPresolve.cpp

@@ -258,9 +258,10 @@ HighsStatus zeroCostColSing() {
   assert(status == HighsStatus::kOk);
 
   status = highs.run();
-  return status;
 
   highs.resetGlobalScheduler(true);
+
+  return status;
 }
 
 // handled by doubleton equality
@@ -317,9 +318,9 @@ HighsStatus colSingDoubletonEquality() {
   assert(status == HighsStatus::kOk);
 
   status = highs.run();
-  return status;
 
   highs.resetGlobalScheduler(true);
+  return status;
 }
 
 HighsStatus colSingDoubletonInequality() {
@@ -375,9 +376,9 @@ HighsStatus colSingDoubletonInequality() {
   assert(status == HighsStatus::kOk);
 
   status = highs.run();
-  return status;
 
   highs.resetGlobalScheduler(true);
+  return status;
 }
 
 // handled by doubleton equality
@@ -414,9 +415,9 @@ HighsStatus twoColSingDoubletonEquality() {
   assert(status == HighsStatus::kOk);
 
   status = highs.run();
-  return status;
 
   highs.resetGlobalScheduler(true);
+  return status;
 }
 
 // handled by special case.
@@ -454,9 +455,9 @@ HighsStatus twoColSingDoubletonInequality() {
 
   highs.run();
   status = highs.run();
-  return status;
 
   highs.resetGlobalScheduler(true);
+  return status;
 }
 
 // No commas in test case name.
@@ -543,9 +544,9 @@ HighsStatus issue425() {
   assert(status == HighsStatus::kOk);
 
   status = highs.run();
-  return status;
 
   highs.resetGlobalScheduler(true);
+  return status;
 }
 
 TEST_CASE("presolve-issue-425", "[highs_test_presolve]") {