Added better logging (including warnings) for HPresolve::removeDependentEquations

Author: jajhall

src/presolve/HPresolve.cpp

@@ -4540,10 +4540,6 @@ HPresolve::Result HPresolve::removeDependentEquations(
 
   HighsSparseMatrix matrix;
   matrix.num_col_ = equations.size();
-  highsLogDev(options->log_options, HighsLogType::kInfo,
-              "HPresolve::removeDependentEquations Got %d equations, checking "
-              "for dependent equations\n",
-              (int)matrix.num_col_);
   matrix.num_row_ = model->num_col_ + 1;
   matrix.start_.resize(matrix.num_col_ + 1);
   matrix.start_[0] = 0;
@@ -4588,26 +4584,32 @@ HPresolve::Result HPresolve::removeDependentEquations(
       std::max(1.0, std::min(0.01 * options->time_limit, 1000.0));
   factor.setTimeLimit(time_limit);
   // Determine rank deficiency of the equations
+  highsLogUser(options->log_options, HighsLogType::kInfo,
+               "Dependent equations search running on %d equations with time "
+               "limit of %.2fs\n",
+               int(matrix.num_col_), time_limit);
   double time_taken = -this->timer->read();
   HighsInt build_return = factor.build();
   time_taken += this->timer->read();
   if (build_return == kBuildKernelReturnTimeout) {
     // HFactor::build has timed out, so just return
     highsLogUser(options->log_options, HighsLogType::kInfo,
-                 "Presolve dependent equations timed out after limit of %gs\n",
-                 time_limit);
+                 "Dependent equations search terminated after %.3gs due to "
+                 "expected time exceeding limit\n",
+                 time_taken);
     analysis_.logging_on_ = logging_on;
     if (logging_on)
       analysis_.stopPresolveRuleLog(kPresolveRuleDependentFreeCols);
     return Result::kOk;
   } else {
-    double pct_off_timeout = std::fabs(time_taken - time_limit) / time_limit;
+    double pct_off_timeout =
+        1e2 * std::fabs(time_taken - time_limit) / time_limit;
     if (pct_off_timeout < 1.0)
-      highsLogUser(
-          options->log_options, HighsLogType::kWarning,
-          "Presolve dependent equations finished within %g\% of limit of %gs: "
-          "risk of non-deterministic behaviour if solve is repeated\n",
-          pct_off_timeout, time_limit);
+      highsLogUser(options->log_options, HighsLogType::kWarning,
+                   "Dependent equations search finished within %.2f%% of limit "
+                   "of %.2fs: "
+                   "risk of non-deterministic behaviour if solve is repeated\n",
+                   pct_off_timeout, time_limit);
   }
   // build_return as rank_deficiency must be valid
   assert(build_return >= 0);
@@ -4629,8 +4631,8 @@ HPresolve::Result HPresolve::removeDependentEquations(
   }
 
   highsLogUser(options->log_options, HighsLogType::kInfo,
-               "Presolve dependent equations removed %d rows and %d nonzeros "
-               "in %gs (limit = %gs)",
+               "Dependent equations search removed %d rows and %d nonzeros "
+               "in %.2fs (limit = %.2fs)\n",
                int(num_removed_row), int(num_removed_nz), time_taken,
                time_limit);