Skip to content

Commit 48f08ad

Browse files
committed
dont normalize field-mappings config-keys
1 parent 35f2a79 commit 48f08ad

File tree

5 files changed

+10
-5
lines changed

5 files changed

+10
-5
lines changed

DependencyInjection/Configuration.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ public function getConfigTreeBuilder()
9696
->end()
9797

9898
->arrayNode('mappings')
99+
->normalizeKeys(false) //do not change - to _ with field names
99100
->useAttributeAsKey('from')
100101
->prototype('array')
101102
->beforeNormalization()

DependencyInjection/MathielenImportEngineExtension.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ private function generateImporterDef(array $importConfig, Definition $objectFact
117117
}
118118

119119
//add converters?
120-
if (array_key_exists('mappings', $importConfig)) {
120+
if (isset($importConfig['mappings'])) {
121121
$this->generateTransformerDef($importConfig['mappings'], $importerDef);
122122
}
123123

@@ -131,11 +131,11 @@ private function generateTransformerDef(array $mappingOptions, Definition $impor
131131
//set converters
132132
foreach ($mappingOptions as $field=>$fieldMapping) {
133133
$converter = null;
134-
if (array_key_exists('converter', $fieldMapping)) {
134+
if (isset($fieldMapping['converter'])) {
135135
$converter = $fieldMapping['converter'];
136136
}
137137

138-
if (array_key_exists('to', $fieldMapping)) {
138+
if (isset($fieldMapping['to'])) {
139139
$mappingsDef->addMethodCall('add', array(
140140
$field,
141141
$fieldMapping['to'],

Resources/config/services.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
<service id="mathielen_importengine.converter.contextmerge" class="Mathielen\DataImport\ItemConverter\ContextMergeConverter">
1919
<tag name="kernel.event_subscriber" />
2020
</service>
21+
<service id="mathielen_importengine.converter.fieldlowercase" class="Mathielen\DataImport\ItemConverter\FieldLowercaseConverter" />
2122

2223
<service id="mathielen_importengine.importer.format_discoverer" class="Mathielen\ImportEngine\Storage\Format\Discovery\MimeTypeDiscoverStrategy" />
2324

Tests/Command/ImportCommandTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,10 @@ public function testRunLimit()
5858
->expects($this->exactly(2))
5959
->method('addListener')
6060
->withConsecutive(
61-
array(ImportConfigureEvent::AFTER_BUILD . '.abc', $this->anything())
61+
array(
62+
ImportConfigureEvent::AFTER_BUILD,
63+
$this->anything()
64+
)
6265
);
6366

6467
$this->container->get('mathielen_importengine.import.runner')

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
],
1717
"require": {
1818
"php": ">=5.4.0",
19-
"mathielen/import-engine": "dev-master",
19+
"mathielen/import-engine": ">=0.8.1",
2020
"symfony/framework-bundle": "~2.4"
2121
},
2222
"require-dev": {

0 commit comments

Comments
 (0)