minor fixes

Author: mathielen

DependencyInjection/MathielenImportEngineExtension.php

@@ -1,6 +1,7 @@
 <?php
 namespace Mathielen\ImportEngineBundle\DependencyInjection;
 
+use Mathielen\ImportEngine\Exception\InvalidConfigurationException;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\DependencyInjection\Extension\Extension;
@@ -217,6 +218,8 @@ private function addStorageProviderDef(Definition $storageLocatorDef, $config, $
                     array($config['queries'])
                 ));
                 break;
+            default:
+                throw new InvalidConfigurationException('Unknown type for storage provider: '.$config['type']);
         }
 
         $storageLocatorDef->addMethodCall('register', array(
@@ -256,6 +259,8 @@ private function getStorageDef(array $config, Definition $objectFactoryDef=null)
                 ));
 
                 break;
+            default:
+                throw new InvalidConfigurationException('Unknown type for storage: '.$config['type']);
         }
 
         return $storageDef;

Tests/DependencyInjection/AbstractExtensionTest.php

@@ -2,7 +2,6 @@
 namespace Mathielen\ImportEngineBundle\Tests\DependencyInjection;
 
 use Mathielen\ImportEngineBundle\DependencyInjection\MathielenImportEngineExtension;
-use MyProject\Proxies\__CG__\stdClass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 
 abstract class AbstractExtensionTest extends \PHPUnit_Framework_TestCase
@@ -46,7 +45,7 @@ public function testWithoutConfiguration()
 
     public function testFullConfiguration()
     {
-        $this->container->register('import_service', new \stdClass()); //target service
+        $this->container->register('import_service', new MyImportService()); //target service
         $this->container->register('jms_serializer', $this->getMock('JMS\Serializer\SerializerInterface'));
         $this->container->register('validator', $this->getMock('Symfony\Component\Validator\ValidatorInterface'));
         $this->container->register('doctrine.orm.entity_manager', $this->getMock('Doctrine\ORM\EntityManagerInterface'));
@@ -64,3 +63,7 @@ public function testMinimumConfiguration()
     }
 
 }
+
+class MyImportService
+{
+}