Skip to content

Commit 6be5b2b

Browse files
committed
Fix errors with inheritance to and from mtr nodes. (mtr should not inherit column or row align from mtable, and mtd should not inherit from mtr at all. The spec is a bit misleading about this, in that these attributes are not actually inherited per se, but their values are taken from the corresponding position within the parent mtable (or mtr) attribute. So no actual inheritance is needed from mtables or mtrs.)
1 parent 69f0166 commit 6be5b2b

File tree

3 files changed

+0
-18
lines changed

3 files changed

+0
-18
lines changed

mathjax3-ts/core/MmlTree/MmlNode.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -222,22 +222,6 @@ export abstract class AbstractMmlNode extends AbstractNode implements MmlNode {
222222
mpadded: {width: true, height: true, depth: true, lspace: true, voffset: true},
223223
mtable: {width: true, height: true, depth: true, align: true}
224224
},
225-
mtable: {
226-
mover: {align: true},
227-
munder: {align: true},
228-
munderover: {align: true},
229-
mtable: {
230-
align: true, rowalign: true, columnalign: true, groupalign: true,
231-
alignmentscope: true, columnwidth: true, width: true, rowspacing: true,
232-
columnspacing: true, rowlines: true, columnlines: true, frame: true,
233-
framespacing: true, equalrows: true, equalcolumns: true, displaystyle: true,
234-
side: true, minlabelspacing: true
235-
}
236-
},
237-
mtr: {
238-
mrow: {rowalign: true, columnalign: true, groupalign: true},
239-
mtable: {rowalign: true, columnalign: true, groupalign: true}
240-
},
241225
maligngroup: {
242226
mrow: {groupalign: true},
243227
mtable: {groupalign: true}

mathjax3-ts/core/MmlTree/MmlNodes/mtable.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ export class MmlMtable extends AbstractMmlNode {
8484
}
8585
}
8686
display = !!(this.attributes.getExplicit('displaystyle') || this.attributes.getDefault('displaystyle'));
87-
attributes = this.addInheritedAttributes(attributes, this.attributes.getAllAttributes());
8887
super.setChildInheritedAttributes(attributes, display, level, prime);
8988
}
9089

mathjax3-ts/core/MmlTree/MmlNodes/mtr.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ export class MmlMtr extends AbstractMmlNode {
6464
.appendChild(child);
6565
}
6666
}
67-
attributes = this.addInheritedAttributes(attributes, this.attributes.getAllAttributes());
6867
super.setChildInheritedAttributes(attributes, display, level, prime);
6968
}
7069

0 commit comments

Comments
 (0)