Make constants for indent attribute names and for 100%, as per Volker's review

Author: dpvc

mathjax3-ts/core/MmlTree/MmlNode.ts

@@ -67,6 +67,14 @@ const TEXSPACE = [
     [ 1, -1,  2,  3,  1,  0,  1,  1]  // INNER
 ];
 
+/*
+ * Attributes used to determine indentation and shifting
+ */
+export const indentAttributes = [
+    'indentalign', 'indentalignfirst',
+    'indentshift', 'indentshiftfirst'
+];
+
 
 /*****************************************************************/
 /*

mathjax3-ts/core/MmlTree/MmlNodes/mtable.ts

@@ -22,7 +22,7 @@
  */
 
 import {PropertyList, Node} from '../../Tree/Node.js';
-import {MmlNode, AbstractMmlNode, AttributeList, TEXCLASS} from '../MmlNode.js';
+import {MmlNode, AbstractMmlNode, AttributeList, TEXCLASS, indentAttributes} from '../MmlNode.js';
 import {split} from '../../../util/string.js';
 
 /*****************************************************************/
@@ -79,7 +79,7 @@ export class MmlMtable extends AbstractMmlNode {
         // Force inheritance of shift and align values (since they are needed to output tables with labels)
         //   but make sure they are not given explicitly on the <mtable> tag.
         //
-        for (const name of ['indentalign', 'indentalignfirst', 'indentshift', 'indentshiftfirst']) {
+        for (const name of indentAttributes) {
             if (attributes[name]) {
                 this.attributes.setInherited(name, attributes[name][1]);
             }

mathjax3-ts/output/chtml/BBox.ts

@@ -52,6 +52,11 @@ export type BBoxData = {
  */
 
 export class BBox {
+    /*
+     * Constant for pwidth of full width box
+     */
+    public static fullWidth = '100%';
+
     /*
      *  These are the data stored for a bounding box
      */

mathjax3-ts/output/chtml/Wrapper.ts

@@ -23,7 +23,7 @@
 
 import {AbstractWrapper} from '../../core/Tree/Wrapper.js';
 import {Node, PropertyList} from '../../core/Tree/Node.js';
-import {MmlNode, TextNode, AbstractMmlNode, AttributeList} from '../../core/MmlTree/MmlNode.js';
+import {MmlNode, TextNode, AbstractMmlNode, AttributeList, indentAttributes} from '../../core/MmlTree/MmlNode.js';
 import {Property} from '../../core/Tree/Node.js';
 import {OptionList} from '../../util/Options.js';
 import {unicodeChars} from '../../util/string.js';
@@ -279,7 +279,7 @@ export class CHTMLWrapper<N, T, D> extends AbstractWrapper<MmlNode, CHTMLWrapper
         this.childNodes = node.childNodes.map((child: Node) => {
             const wrapped = this.wrap(child as MmlNode);
             if (wrapped.bbox.pwidth) {
-                this.bbox.pwidth = '100%';
+                this.bbox.pwidth = BBox.fullWidth;
             }
             return wrapped;
         });
@@ -622,7 +622,7 @@ export class CHTMLWrapper<N, T, D> extends AbstractWrapper<MmlNode, CHTMLWrapper
      */
     protected handlePWidth() {
         if (this.bbox.pwidth) {
-            if (this.bbox.pwidth === '100%') {
+            if (this.bbox.pwidth === BBox.fullWidth) {
                 this.adaptor.setAttribute(this.chtml, 'width', 'full');
             } else {
                 this.adaptor.setStyle(this.chtml, 'width', this.bbox.pwidth);
@@ -683,8 +683,7 @@ export class CHTMLWrapper<N, T, D> extends AbstractWrapper<MmlNode, CHTMLWrapper
      */
     protected getAlignShift() {
         let {indentalign, indentshift, indentalignfirst, indentshiftfirst} =
-            this.node.attributes.getList('indentalign', 'indentshift',
-                                    'indentalignfirst', 'indentshiftfirst') as StringMap;
+            this.node.attributes.getList(...indentAttributes) as StringMap;
         if (indentalignfirst !== 'indentalign') {
             indentalign = indentalignfirst;
         }
@@ -702,7 +701,7 @@ export class CHTMLWrapper<N, T, D> extends AbstractWrapper<MmlNode, CHTMLWrapper
     }
 
     /*
-     * @param{N} chtml       The HTML node whose indenting is to be adjusted
+     * @param{N} chtml       The HTML node whose indentation is to be adjusted
      * @param{string} align  The alignment for the node
      * @param{number} shift  The indent (positive or negative) for the node
      */

mathjax3-ts/output/chtml/Wrappers/mrow.ts

@@ -48,7 +48,7 @@ export class CHTMLmrow<N, T, D> extends CHTMLWrapper<N, T, D> {
         this.stretchChildren();
         for (const child of this.childNodes) {
             if (child.bbox.pwidth) {
-                this.bbox.pwidth = '100%';
+                this.bbox.pwidth = BBox.fullWidth;
                 break;
             }
         }

mathjax3-ts/output/chtml/Wrappers/mtable.ts

@@ -181,7 +181,7 @@ export class CHTMLmtable<N, T, D> extends CHTMLWrapper<N, T, D> {
     protected getPercentageWidth() {
         for (const row of this.childNodes) {
             if (row.node.isKind('mlabeledtr')) {
-                this.bbox.pwidth = '100%';
+                this.bbox.pwidth = BBox.fullWidth;
                 return;
             }
         }