Skip to content

Commit 70d4561

Browse files
authored
Merge pull request #963 from Arlofin/culture
Explicitly specify invariant culture in some unit tests
2 parents c48f994 + 3567a29 commit 70d4561

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/Data.Tests/Text/DelimitedWriterTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ public void CanWriteSpaceDelimitedData()
142142
{
143143
var matrix = SparseMatrix.OfArray(new[,] {{1.1, 0, 0}, {0, 5.5, 0}, {0, 0, 9.9}});
144144
var stream = new MemoryStream();
145-
DelimitedWriter.Write(stream, matrix, " ");
145+
DelimitedWriter.Write(stream, matrix, " ", formatProvider: CultureInfo.InvariantCulture);
146146
var data = stream.ToArray();
147147
var reader = new StreamReader(new MemoryStream(data));
148148
var text = reader.ReadToEnd();
@@ -160,7 +160,7 @@ public void CanWriteCommaDelimitedDataWithMissingValues()
160160
{
161161
var matrix = SparseMatrix.OfArray(new[,] { { 1.1, 0, 0 }, { 0, 5.5, 0 }, { 0, 0, 9.9 } });
162162
var stream = new MemoryStream();
163-
DelimitedWriter.Write(stream, matrix, ",", missingValue: 0);
163+
DelimitedWriter.Write(stream, matrix, ",", missingValue: 0, formatProvider: CultureInfo.InvariantCulture);
164164
var data = stream.ToArray();
165165
var reader = new StreamReader(new MemoryStream(data));
166166
var text = reader.ReadToEnd();
@@ -179,7 +179,7 @@ public void CanWriteTabDelimitedDataWithMissingValues()
179179
{
180180
var matrix = DenseMatrix.OfArray(new[,] { { 1.1, double.NaN, 0 }, { 0, 5.5, 0 }, { double.NaN, double.NaN, 9.9 } });
181181
var stream = new MemoryStream();
182-
DelimitedWriter.Write(stream, matrix, "\t", missingValue: double.NaN);
182+
DelimitedWriter.Write(stream, matrix, "\t", missingValue: double.NaN, formatProvider: CultureInfo.InvariantCulture);
183183
var data = stream.ToArray();
184184
var reader = new StreamReader(new MemoryStream(data));
185185
var text = reader.ReadToEnd();

src/Numerics.Tests/LinearAlgebraTests/MatrixHelpers.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
// </copyright>
2929

3030
using System;
31+
using System.Globalization;
3132
using System.IO;
3233
using MathNet.Numerics.LinearAlgebra;
3334
using MathNet.Numerics.LinearAlgebra.Double;
@@ -136,7 +137,7 @@ public static Matrix<double> ReadTestDataSparseMatrixDoubleCoordinateFormat(stri
136137
if (!int.TryParse(split[1], out cooCols[i]))
137138
throw new InvalidDataException($"Could not parse column integer on line {i + 1}");
138139

139-
if (!double.TryParse(split[2], out cooVals[i]))
140+
if (!double.TryParse(split[2], NumberStyles.Float, CultureInfo.InvariantCulture, out cooVals[i]))
140141
throw new InvalidDataException($"Could not parse double value on line {i + 1}");
141142

142143
nRows = Math.Max(nRows, cooRows[i] + 1);

0 commit comments

Comments
 (0)