Reverse orientation are now managed in config.yaml by the user.

Theme only sets landscape or portrait.

Author: mathoudebine

config.yaml

@@ -2,15 +2,18 @@
 config:
   # Configuration values to set up basic communication
   # Set your COM port e.g. COM3 for Windows, /dev/ttyACM0 for Linux...
+  # Use AUTO for COM port auto-discovery (may not work on every setup)
   # COM_PORT: "/dev/ttyACM0"
   # COM_PORT: "COM3"
   COM_PORT: "AUTO"
 
   # Theme to use (located in res/themes)
-  # THEME: Terminal
-  # THEME: Landscape6Grid
-  # THEME: Cyberpunk
-  # THEME: bash-dark-green
+  # Available themes:
+  # - 3.5inchTheme2
+  # - Terminal
+  # - Landscape6Grid
+  # - Cyberpunk
+  # - bash-dark-green
   THEME: 3.5inchTheme2
 
   # Hardware sensors reading
@@ -29,16 +32,23 @@ config:
   WLO: "wlan0" # Wi-Fi Card
 
 display:
-  # Display resolution in portrait orientation
-  # Do not use this setting to rotate display! Display orientation is managed by themes
-  DISPLAY_WIDTH: 320
-  DISPLAY_HEIGHT: 480
+  # Display revision: A or B (for "flagship" version, use B) or SIMU for simulated LCD (image written in screencap.png)
+  # To identify your revision: https://github.com/mathoudebine/turing-smart-screen-python/wiki/Hardware-revisions
+  REVISION: A
 
   # Display Brightness
   # Set this as the desired %, 0 being completely dark and 100 being max brightness
-  # Warning: screen can get very hot at high brightness!
+  # Warning: revision A display can get hot at high brightness!
   BRIGHTNESS: 20
 
-  # Display revision: A or B (for "flagship" version, use B) or SIMU for simulated LCD (image written in screencap.png)
-  # To identify your revision: https://github.com/mathoudebine/turing-smart-screen-python/wiki/Hardware-revisions
-  REVISION: A
+  # Display reverse: true/false
+  # Set to true to reverse display orientation (landscape <-> reverse landscape, portrait <-> reverse portrait)
+  # Note: Display basic orientation (portrait or landscape) is defined by the theme you have selected
+  DISPLAY_REVERSE: false
+
+  # Display resolution in portrait orientation
+  # Do not use this setting to rotate display! Use DISPLAY_REVERSE
+  DISPLAY_WIDTH: 320  # Do not change unless you have a good reason
+  DISPLAY_HEIGHT: 480  # Do not change unless you have a good reason
+
+

library/display.py

@@ -18,12 +18,22 @@ def _get_full_path(path, name):
 
 def _get_theme_orientation() -> Orientation:
     if THEME_DATA["display"]["DISPLAY_ORIENTATION"] == 'portrait':
-        return Orientation.PORTRAIT
+        if CONFIG_DATA["display"].get("DISPLAY_REVERSE", False):
+            return Orientation.REVERSE_PORTRAIT
+        else:
+            return Orientation.PORTRAIT
     elif THEME_DATA["display"]["DISPLAY_ORIENTATION"] == 'landscape':
-        return Orientation.LANDSCAPE
+        if CONFIG_DATA["display"].get("DISPLAY_REVERSE", False):
+            return Orientation.REVERSE_LANDSCAPE
+        else:
+            return Orientation.LANDSCAPE
     elif THEME_DATA["display"]["DISPLAY_ORIENTATION"] == 'reverse_portrait':
+        logger.warn("'reverse_portrait' is deprecated as DISPLAY_ORIENTATION value in the theme."
+                    "Use 'portrait' instead, and use DISPLAY_REVERSE in config.yaml to reverse orientation.")
         return Orientation.REVERSE_PORTRAIT
     elif THEME_DATA["display"]["DISPLAY_ORIENTATION"] == 'reverse_landscape':
+        logger.warn("'reverse_landscape' is deprecated as DISPLAY_ORIENTATION value in the theme."
+                    "Use 'landscape' instead, and use DISPLAY_REVERSE in config.yaml to reverse orientation.")
         return Orientation.REVERSE_LANDSCAPE
     else:
         logger.warning("Orientation '", THEME_DATA["display"]["DISPLAY_ORIENTATION"], "' unknown, using portrait")

res/themes/3.5inchTheme2/theme.yaml

@@ -1,6 +1,6 @@
 ---
 display:
-  # Specify the display orientation for this theme: portrait, landscape, reverse_portrait, reverse_landscape
+  # Specify the display orientation for this theme: portrait or landscape
   DISPLAY_ORIENTATION: portrait
 
   # Backplate RGB LED color (for HW revision 'flagship' devices only)

res/themes/Cyberpunk/theme.yaml

@@ -1,6 +1,6 @@
 ---
 display:
-  # Specify the display orientation for this theme: portrait, landscape, reverse_portrait, reverse_landscape
+  # Specify the display orientation for this theme: portrait or landscape
   DISPLAY_ORIENTATION: portrait
 
   # Backplate RGB LED color (for HW revision 'flagship' devices only)

res/themes/Landscape6Grid/theme.yaml

@@ -1,6 +1,6 @@
 ---
 display:
-  # Specify the display orientation for this theme: portrait, landscape, reverse_portrait, reverse_landscape
+  # Specify the display orientation for this theme: portrait or landscape
   DISPLAY_ORIENTATION: landscape
 
   # Backplate RGB LED color (for HW revision 'flagship' devices only)

res/themes/Terminal/theme.yaml

@@ -1,6 +1,6 @@
 ---
 display:
-  # Specify the display orientation for this theme: portrait, landscape, reverse_portrait, reverse_landscape
+  # Specify the display orientation for this theme: portrait or landscape
   DISPLAY_ORIENTATION: portrait
 
   # Backplate RGB LED color (for HW revision 'flagship' devices only)

res/themes/bash-dark-green/theme.yaml

@@ -1,6 +1,6 @@
 ---
 display:
-  # Specify the display orientation for this theme: portrait, landscape, reverse_portrait, reverse_landscape
+  # Specify the display orientation for this theme: portrait or landscape
   DISPLAY_ORIENTATION: portrait
 
   # Backplate RGB LED color (for HW revision 'flagship' devices only)

simple-program.py

@@ -67,8 +67,8 @@ def sighandler(signum, frame):
     # Send initialization commands
     lcd_comm.InitializeComm()
 
-    # Set brightness in % (warning: screen can get very hot at high brightness!)
-    lcd_comm.SetBrightness(level=25)
+    # Set brightness in % (warning: revision A display can get hot at high brightness!)
+    lcd_comm.SetBrightness(level=10)
 
     # Set backplate RGB LED color (for supported HW only)
     lcd_comm.SetBackplateLedColor(led_color=(255, 255, 255))