-
Notifications
You must be signed in to change notification settings - Fork 165
XML edit #1640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EJMFarrow
commented
Dec 17, 2025
- Adds a page to edit the XML of a question, accessible from STACK dashboard.
- Requires latest version of importasversion to save the new version of the question.
- Adds default values for many STACK fields on XML import to allow use of question fragments on XML edit page.
- Adds validation output display on importasversion, Gitsync import and XML edit page save.
version.php
Outdated
| 'qbehaviour_dfexplicitvaildate' => 2018080600, | ||
| 'qbehaviour_dfcbmexplicitvaildate' => 2018080600, | ||
| // TO-DO - We will need an updated version of this. | ||
| 'qbank_importasversion' => 2025041400, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @EJMFarrow that's sensible to have as well. I've bumped the version number of STACK in dev ahead again to make sure any development server upgrades prompt for this plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something odd has happened here. 'qbank_importasversion' should be '2025121600' without the to-do comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! OK, yes, that's the version in the metadata version.php
https://github.com/maths/moodle-qtype_stack/blob/iss1171/version.php#L38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that was me switching between versions. Sorry. Hopefully fixed now. If you weren't using that version of importasversion before you should see better validation messages when submitting invalid XML.