Add a new exception: Forbidden, when a 403 is thrown but the response is not an invalid token. This occurs when the token does not grant access to the given resource, for eg. when trying to get the warlog or current war of a clan with a private warlog

Author: mathsman5133

coc/__init__.py

@@ -39,6 +39,7 @@
     NotFound,
     InvalidArgument,
     InvalidToken,
+    Forbidden,
     Maitenance
 )
 from .http import HTTPClient

coc/errors.py

@@ -55,9 +55,8 @@ def __init__(self, response, message):
         self.response = response
         self.status = response.status
         try:
-            self.reason = message.get('reason', '')
+            self.reason = message.get('reason', 'Unknown')
             self.message = message.get('message', '')
-
         except Exception:
             self.reason = 'Unknown'
             self.message = ''
@@ -81,17 +80,24 @@ class InvalidArgument(ClashOfClansException):
 
 
 class InvalidToken(HTTPException):
-    """Thrown when an error status 403 occurs.
-
-    Missing/incorrect credentials, or API token does not
-    grant access to the requested resource.
+    """Thrown when an error status 403 occurs and the reason is an invalid token.
 
+    Special Exception thrown when missing/incorrect credentials
+    were passed. This is most likely an invalid token.
     Subclass of :exc:`HTTPException`
     """
 
     pass
 
 
+class Forbidden(HTTPException):
+    """Thrown when an error status 403 occurs.
+
+    API token does not grant access to the requested resource.
+
+    Subclass of :exc:`HTTPException`"""
+
+
 class NotFound(HTTPException):
     """Thrown when an error status 404 occurs.
 

docs/api.rst

@@ -187,6 +187,8 @@ The following exceptions are thrown by the library.
 
 .. autoexception:: InvalidToken
 
+.. autoexception:: Forbidden
+
 .. autoexception:: NotFound
 
 .. autoexception:: Maitenance