Skip to content

{Key, Keyring}::new should (probably) not be unsafe #56

@Nemo157

Description

@Nemo157

As far as I can tell inventing an invalid key id will just cause errors on future API calls, there is no way to trigger memory unsafety, so this function should not be marked unsafe. To reduce the chance of users using this incorrectly it could be renamed to new_unchecked to highlight that it's up to the user to ensure they use a valid id.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions