Finishing add resource property to metrics

Author: dnarula-mw

sdk/metrics/+opentelemetry/+sdk/+metrics/MeterProvider.m

@@ -10,9 +10,6 @@
 
     properties (Access=public)
         MetricReader
-    end
-
-    properties (Access=public)
         Resource
     end
 

sdk/metrics/include/opentelemetry-matlab/sdk/metrics/MeterProviderProxy.h

@@ -22,6 +22,8 @@
 #include "opentelemetry/sdk/metrics/meter_provider_factory.h"
 #include "opentelemetry/sdk/metrics/push_metric_exporter.h"
 #include "opentelemetry/sdk/resource/resource.h"
+#include "opentelemetry/sdk/metrics/view/view_registry.h"
+#include "opentelemetry/sdk/metrics/view/view_registry_factory.h"
 
 
 #include "opentelemetry-matlab/metrics/MeterProxy.h"

sdk/metrics/src/MeterProviderProxy.cpp

@@ -36,10 +36,12 @@ libmexclass::proxy::MakeResult MeterProviderProxy::make(const libmexclass::proxy
 
         auto reader = std::static_pointer_cast<PeriodicExportingMetricReaderProxy>(
 	            libmexclass::proxy::ProxyManager::getProxy(readerid))->getInstance();
-        auto p = metrics_sdk::MeterProviderFactory::Create();
+        
+        auto view = metrics_sdk::ViewRegistryFactory::Create();
+        auto p = metrics_sdk::MeterProviderFactory::Create(std::move(view), resource_custom);
         auto *p_sdk = static_cast<metrics_sdk::MeterProvider *>(p.get());
         p_sdk->AddMetricReader(std::move(reader));
-      
+
         auto p_out = nostd::shared_ptr<metrics_api::MeterProvider>(std::move(p));
         out = std::make_shared<MeterProviderProxy>(p_out);
     }

test/myoutput.json

@@ -0,0 +1,69 @@
+classdef tmetrics_sdk < matlab.unittest.TestCase
+    % tests for metrics SDK
+
+    % Copyright 2023 The MathWorks, Inc.
+
+    properties
+        OtelConfigFile
+        JsonFile
+        PidFile
+        OtelcolName
+        Otelcol
+        ListPid
+        ReadPidList
+        ExtractPid
+        Sigint
+        Sigterm
+    end
+
+    methods (TestClassSetup)
+        function setupOnce(testCase)
+            commonSetupOnce(testCase);
+        end
+    end
+
+    methods (TestMethodTeardown)
+        function teardown(testCase)
+            commonTeardown(testCase);
+        end
+    end
+
+    methods (Test)
+        function testCustomResource(testCase)
+            % testCustomResource: check custom resources are included in
+            % emitted metrics
+            commonSetup(testCase)
+
+            customkeys = ["foo" "bar"];
+            customvalues = [1 5];
+            exporter = opentelemetry.exporters.otlp.OtlpHttpMetricExporter();
+            reader = opentelemetry.sdk.metrics.PeriodicExportingMetricReader(exporter, ...
+                "Interval", seconds(2), "Timeout", seconds(1));
+            mp = opentelemetry.sdk.metrics.MeterProvider(reader, ...
+                "Resource", dictionary(customkeys, customvalues)); 
+            
+            m = getMeter(mp, "mymeter");
+            c = createCounter(m, "mycounter");
+
+            % create testing value 
+            val = 10;
+
+            % add value and attributes
+            c.add(val);
+
+            pause(2.5);
+
+            % perform test comparisons
+            results = readJsonResults(testCase);
+            results = results{1};
+
+            resourcekeys = string({results.resourceMetrics.resource.attributes.key});
+            for i = length(customkeys)
+                idx = find(resourcekeys == customkeys(i));
+                verifyNotEmpty(testCase, idx);
+                verifyEqual(testCase, results.resourceMetrics.resource.attributes(idx).value.doubleValue, customvalues(i));
+            end
+        end
+
+    end
+end