Skip to content

Commit 5df8f72

Browse files
committed
Minor changes for PR
1 parent f035171 commit 5df8f72

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

sdk/metrics/src/MeterProviderProxy.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// Copyright 2023 The MathWorks, Inc.
22

3-
#include "opentelemetry/sdk/metrics/instruments.h"
43
#include "opentelemetry-matlab/sdk/metrics/MeterProviderProxy.h"
54
#include "opentelemetry-matlab/sdk/metrics/PeriodicExportingMetricReaderProxy.h"
65
#include "opentelemetry-matlab/sdk/metrics/ViewProxy.h"

sdk/metrics/src/ViewProxy.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,26 +75,26 @@ libmexclass::proxy::MakeResult ViewProxy::make(const libmexclass::proxy::Functio
7575
}
7676

7777
matlab::data::StringArray instrument_name_mda = constructor_arguments[3];
78-
auto instrument_name_view = static_cast<std::string>(instrument_name_mda[0]);
78+
auto instrument_name = static_cast<std::string>(instrument_name_mda[0]);
7979

8080
auto unit_str = static_cast<std::string>(unit);
8181

8282
auto instrumentSelector = metrics_sdk::InstrumentSelectorFactory::Create(instrument_type,
83-
instrument_name_view, unit_str);
83+
instrument_name, unit_str);
8484

8585

8686
// Create Meter Selector
8787
matlab::data::StringArray meter_name_mda = constructor_arguments[5];
88-
auto meter_name_view = static_cast<std::string>(meter_name_mda[0]);
88+
auto meter_name = static_cast<std::string>(meter_name_mda[0]);
8989

9090
matlab::data::StringArray meter_version_mda = constructor_arguments[6];
91-
auto meter_version_view = static_cast<std::string>(meter_version_mda[0]);
91+
auto meter_version = static_cast<std::string>(meter_version_mda[0]);
9292

9393
matlab::data::StringArray meter_schema_mda = constructor_arguments[7];
94-
auto meter_schema_view = static_cast<std::string>(meter_schema_mda[0]);
94+
auto meter_schema = static_cast<std::string>(meter_schema_mda[0]);
9595

96-
auto meterSelector = metrics_sdk::MeterSelectorFactory::Create(meter_name_view,
97-
meter_version_view, meter_schema_view);
96+
auto meterSelector = metrics_sdk::MeterSelectorFactory::Create(meter_name,
97+
meter_version, meter_schema);
9898

9999

100100
// Call View Proxy Constructor

test/tmetrics_sdk.m

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,8 @@ function testViewHistogram(testCase)
215215
dp = results.resourceMetrics.scopeMetrics.metrics.histogram.dataPoints;
216216

217217
% verify histogram sum
218-
verifyEqual(testCase, dp.sum, 1204);
218+
expected_sum = 1204;
219+
verifyEqual(testCase, dp.sum, expected_sum);
219220

220221
% verify histogram bounds
221222
verifyEqual(testCase, dp.explicitBounds, bin_edges);

0 commit comments

Comments
 (0)