Fix a bug in span/setStatus #20

Author: duncanpo

api/trace/+opentelemetry/+trace/Span.m

@@ -132,7 +132,11 @@ function setStatus(obj, status, description)
                 % new status is not valid, ignore
                 return
             end
-            description = opentelemetry.common.mustBeScalarString(description);
+            if nargin < 3
+                description = "";
+            else
+                description = opentelemetry.common.mustBeScalarString(description);
+            end
     	    obj.Proxy.setStatus(status, description);
     	end
 
@@ -181,8 +185,7 @@ function setStatus(obj, status, description)
         function attrs = processAttributes(attrsin)
             import opentelemetry.trace.Span.processAttribute
 
-            nin = length(attrsin);
-            if nin == 1 && isa(attrsin{1}, "dictionary")
+            if isscalar(attrsin) && isa(attrsin{1}, "dictionary")
                 % dictionary case
       	       attrtbl = entries(attrsin{1});
                nattr = height(attrtbl);
@@ -203,6 +206,7 @@ function setStatus(obj, status, description)
                attrs = attrs(:);
             else
                 % NV pairs
+                nin = length(attrsin);
                 if rem(nin,2) ~= 0
                     % Mismatched name-value pairs. Ignore all attributes.
                     attrs = cell(1,0);

test/ttrace.m

@@ -262,6 +262,28 @@ function testTime(testCase)
                 "convertFrom", "posixtime") - endtime), seconds(2));
         end
 
+        function testStatus(testCase)
+            % testStatus: setting status
+            tp = opentelemetry.sdk.trace.TracerProvider();
+            tr = getTracer(tp, "foo");
+            sp = startSpan(tr, "bar");
+            setStatus(sp, "ok");
+            endSpan(sp);
+
+            sp1 = startSpan(tr, "quz");
+            setStatus(sp1, "Error", "Something went wrong.")  % with description
+            endSpan(sp1);
+
+            % perform test comparisons
+            results = readJsonResults(testCase);
+            % status codes
+            %   Unset: 0
+            %   Ok:    1
+            %   Error: 2
+            verifyEqual(testCase, results{1}.resourceSpans.scopeSpans.spans.status.code, 1);
+            verifyEqual(testCase, results{2}.resourceSpans.scopeSpans.spans.status.code, 2);
+        end
+
         function testAttributes(testCase)
             % testAttributes: specifying attributes when starting spans