Updated review comments

Author: Nikhil Bhoski

src/main/java/com/mathworks/ci/RunMatlabTestsBuilder.java

@@ -1,5 +1,13 @@
 package com.mathworks.ci;
 
+/** 
+ * Copyright 2019-2020 The MathWorks, Inc.  
+ *  
+ * MATLAB test run builder used to run all MATLAB & Simulink tests automatically and generate   
+ * selected test artifacts. 
+ *  
+ */
+
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
@@ -142,7 +150,7 @@ public StmResultsChkBx getStmResultsChkBx() {
     } 
 
     public String getStmResultsFilePath() {
-        return stmResultsFilePath;
+        return this.stmResultsFilePath;
     }
 
     public boolean getIsStmChecked() {

src/main/resources/com/mathworks/ci/RunMatlabTestsBuilder/runMatlabTests.m

@@ -2,14 +2,15 @@
 
 function failed = runMatlabTests(varargin)
 
-
 p = inputParser;
-p.addParameter('PDFReportPath', '', @ischar);
-p.addParameter('TAPResultsPath', '', @ischar);
-p.addParameter('JUnitResultsPath', '', @ischar);
-p.addParameter('SimulinkTestResultsPath', '', @ischar);
-p.addParameter('CoberturaCodeCoveragePath', '', @ischar);
-p.addParameter('CoberturaModelCoveragePath', '', @ischar);
+validationFcn = @(c)ischar(c) && (isempty(c) || isrow(c));
+
+p.addParameter('PDFReportPath', '', validationFcn);
+p.addParameter('TAPResultsPath', '', validationFcn);
+p.addParameter('JUnitResultsPath', '', validationFcn);
+p.addParameter('SimulinkTestResultsPath', '', validationFcn);
+p.addParameter('CoberturaCodeCoveragePath', '', validationFcn);
+p.addParameter('CoberturaModelCoveragePath', '', validationFcn);
 
 p.parse(varargin{:});
 
@@ -43,8 +44,8 @@
         warning('MATLAB:testArtifact:junitReportNotSupported', 'Producing JUnit xml results is not supported in this release.');
     else
         import('matlab.unittest.plugins.XMLPlugin');
-        xmlFile = getFullFileForReport(junitReportPath);
-        runner.addPlugin(XMLPlugin.producingJUnitFormat(xmlFile));
+        preparePath(junitReportPath);
+        runner.addPlugin(XMLPlugin.producingJUnitFormat(junitReportPath));
     end
 end
 
@@ -77,10 +78,10 @@
          warning('MATLAB:testArtifact:coberturaReportNotSupported', 'Producing Cobertura code coverage results is not supported in this release.');
     else 
         import('matlab.unittest.plugins.CodeCoveragePlugin');
-        coverageFile = getFullFileForReport(coberturaReportPath);
+        preparePath(coberturaReportPath);
         workSpace = fullfile(pwd);
         runner.addPlugin(CodeCoveragePlugin.forFolder(workSpace,'IncludingSubfolders',true,...
-        'Producing', CoberturaFormat(coverageFile)));
+        'Producing', CoberturaFormat(coberturaReportPath)));
     end
 end
 
@@ -92,8 +93,8 @@
     else 
         import('sltest.plugins.ModelCoveragePlugin');
 
-        coverageFile = getFullFileForReport(modelCoveragePath);
-        runner.addPlugin(ModelCoveragePlugin('Producing',CoberturaFormat(coverageFile)));
+        preparePath(modelCoveragePath);
+        runner.addPlugin(ModelCoveragePlugin('Producing',CoberturaFormat(modelCoveragePath)));
     end
 end
 
@@ -104,8 +105,8 @@
     if ~stmResultsPluginPresent || ~exportSTMResultsSupported
         issueExportSTMResultsUnsupportedWarning;
     else
-        stmResultFile = getFullFileForReport(stmReportPath);
-        runner.addPlugin(TestManagerResultsPlugin('ExportToFile', stmResultFile));
+        preparePath(stmReportPath);
+        runner.addPlugin(TestManagerResultsPlugin('ExportToFile', stmReportPath));
         stmResultsPluginAddedToRunner = true;
     end
 end
@@ -118,9 +119,9 @@
     elseif ~testReportPluginPresent
         issuePDFReportUnsupportedWarning;
     else
-        pdfReportFile = getFullFileForReport(pdfReportPath);
+        preparePath(pdfReportPath);
         import('matlab.unittest.plugins.TestReportPlugin');
-        runner.addPlugin(TestReportPlugin.producingPDF(pdfReportFile));
+        runner.addPlugin(TestReportPlugin.producingPDF(pdfReportPath));
 
         if ~stmResultsPluginAddedToRunner && stmResultsPluginPresent
             runner.addPlugin(TestManagerResultsPlugin);
@@ -131,20 +132,18 @@
 results = runner.run(suite);
 failed = any([results.Failed]);
 
-function fileName = getFullFileForReport(filePath)
-[filepath,name,ext] = fileparts(filePath);
-if (filepath == "")
-    fileName = fullfile(pwd,strcat(name,ext));
-else
-    mkdirIfNeeded(filepath)
-    fileName = fullfile(filepath, strcat(name,ext));
+function preparePath(path)
+dir = fileparts(path);
+dirExists = isempty(dir) || exist(dir,'dir') == 7;
+if ~dirExists		
+    mkdir(dir);		    
 end
 
 function tapToFile = getTapResultFile(resultsDir)
 import('matlab.unittest.plugins.ToFile');
-tapFile = getFullFileForReport(resultsDir);
-fclose(fopen(tapFile,'w'));
-tapToFile = matlab.unittest.plugins.ToFile(tapFile);
+preparePath(resultsDir);
+fclose(fopen(resultsDir,'w'));
+tapToFile = matlab.unittest.plugins.ToFile(resultsDir);
 
 function suite = getTestSuite()
 import('matlab.unittest.TestSuite');
@@ -155,12 +154,6 @@
     suite = testsuite(pwd,'IncludeSubfolders',true);
 end
 
-
-function mkdirIfNeeded(dir)
-if exist(dir,'dir') ~= 7
-    mkdir(dir);
-end
-
 function plugin = CoberturaFormat(varargin)
 plugin = matlab.unittest.plugins.codecoverage.CoberturaFormat(varargin{:});