2.1.3 snapshot qualification temp path (#131)

* Temp path issue (#128)

* Fix Java temp path discrepancy

* Fix Java temp path discrepancy

* Fix Java temp dir discrepancy

* Fix test for temp dir discrepancy

* Fix Java temp path discrepancy

* Fix Java temp dir path discrepancy

* Fix temp path issue_Incorporate reviews

* Fix temp path discrepancy_use computer channel

* Change code coverage tool to JaCoCo (#129)

* Unit Test failure induced to check Azure Build

* Removing induces test failure

* Removed induced test failure

Co-authored-by: Sangavi Jayagopi <[email protected]>

Author: abhargav-mw

azure-pipelines.yml

@@ -25,7 +25,7 @@ steps:
       mavenOptions: '-Xmx3072m -Dmaven.javadoc.skip=true'
       publishJUnitResults: true
       testResultsFiles: '**/surefire-reports/TEST-*.xml'
-      codeCoverageToolOption: 'cobertura'
+      codeCoverageToolOption: 'JaCoCo'
       goals: 'verify'
     displayName: 'Build $(imageName)'
 

src/main/java/com/mathworks/ci/MatlabBuild.java

@@ -76,16 +76,21 @@ default FilePath getFilePathForUniqueFolder(Launcher launcher, String uniqueName
          * https://javadoc.jenkins-ci.org/jenkins/tasks/SimpleBuildStep.html */
 
         String tmpDir = getNodeSpecificTmpFolderPath(workspace);
-        return new FilePath(launcher.getChannel(), tmpDir+"/"+uniqueName);
+
+        return new FilePath(launcher.getChannel(), tmpDir + "/" + uniqueName);
     }
 
     default String getNodeSpecificTmpFolderPath(FilePath workspace) throws IOException, InterruptedException {
         Computer cmp = workspace.toComputer();
         if (cmp == null) {
             throw new IOException(Message.getValue("build.workspace.computer.not.found"));
         }
-        String tmpDir = (String) cmp.getSystemProperties().get("java.io.tmpdir");
-        return tmpDir;
+        
+        String tmpDirPath = (String) cmp.getSystemProperties().get("java.io.tmpdir");
+
+        // Invoke FilePath.normalize for clean file path on any channel.
+        FilePath tmpDir = new FilePath(cmp.getChannel(), tmpDirPath);
+        return tmpDir.getRemote();
     }
 
     default String getUniqueNameForRunnerFile() {

src/test/java/com/mathworks/ci/RunMatlabCommandBuilderTest.java

@@ -187,7 +187,7 @@ public void verifyBuildFailureWhenMatlabCommandFails() throws Exception {
      */
 
     @Test
-    public void verifyBuildFailureWhenMatlabCommandPasses() throws Exception {
+    public void verifyBuildPassesWhenMatlabCommandPasses() throws Exception {
         this.buildWrapper.setMatlabRootFolder(getMatlabroot("R2018b"));
         project.getBuildWrappersList().add(this.buildWrapper);
         RunMatlabCommandBuilderTester tester =
@@ -196,6 +196,7 @@ public void verifyBuildFailureWhenMatlabCommandPasses() throws Exception {
         project.getBuildersList().add(tester);
         FreeStyleBuild build = project.scheduleBuild2(0).get();
         jenkins.assertBuildStatus(Result.SUCCESS, build);
+
     }
 
     /*
@@ -249,6 +250,9 @@ public void verifyCommandSupportsEnvVar() throws Exception {
 
     /*
      * Test to verify if appropriate MATALB runner file is copied in workspace.
+     * 
+     * NOTE: This test assumes there is no MATLAB installed and is not on System Path.
+     * 
      */
     @Test
     public void verifyMATLABrunnerFileGenerated() throws Exception {
@@ -262,6 +266,9 @@ public void verifyMATLABrunnerFileGenerated() throws Exception {
 
 	/*
 	 * Test to verify if Matrix build fails when MATLAB is not available.
+     * 
+     * NOTE: This test assumes there is no MATLAB installed and is not on System Path.
+     * 
 	 */
 	@Test
 	public void verifyMatrixBuildFails() throws Exception {

src/test/java/com/mathworks/ci/RunMatlabTestsBuilderTest.java

@@ -334,6 +334,9 @@ public void veriyEmptyParameters() throws Exception {
 
     /*
      * Test to verify if appropriate MATALB runner file is copied in workspace.
+     * 
+     * NOTE: This test assumes there is no MATLAB installed and is not on System Path.
+     *
      */
     @Test
     public void verifyMATLABrunnerFileGeneratedForAutomaticOption() throws Exception {
@@ -346,6 +349,9 @@ public void verifyMATLABrunnerFileGeneratedForAutomaticOption() throws Exception
 
 	/*
 	 * Test to verify if Matrix build fails when MATLAB is not available.
+     * 
+     * NOTE: This test assumes there is no MATLAB installed and is not on System Path.
+     *
 	 */
 	@Test
 	public void verifyMatrixBuildFails() throws Exception {