Fixed findbug issue and FileCopy issue for Matlab test builder.

Author: Nikhil Bhoski

src/main/java/com/mathworks/ci/MatlabBuild.java

@@ -9,8 +9,6 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.UUID;
-import javax.annotation.Nonnull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import hudson.EnvVars;
 import hudson.FilePath;
 import hudson.Launcher;
@@ -72,15 +70,12 @@ default void copyFileInWorkspace(String sourceFile, String targetFile, FilePath
         targetFilePath.chmod(0755);
     }
 
-    @SuppressFBWarnings(value = "NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE",
-            justification = "workspace is passed through perform method, which will always have NonNull FilePath")
     default FilePath getFilePathForUniqueFolder(Launcher launcher, String uniqueName, FilePath workspace)
             throws IOException, InterruptedException {
         /*Use of Computer is not recommended as jenkins hygeine for pipeline support
          * https://javadoc.jenkins-ci.org/jenkins/tasks/SimpleBuildStep.html */
 
-        Computer cmp = workspace.toComputer();
-        String tmpDir = (String) cmp.getSystemProperties().get("java.io.tmpdir");
+        String tmpDir = getNodeSpecificTmpFolderPath(workspace);
         if (launcher.isUnix()) {
             tmpDir = tmpDir + "/" + uniqueName;
         } else {
@@ -89,16 +84,16 @@ default FilePath getFilePathForUniqueFolder(Launcher launcher, String uniqueName
         return new FilePath(launcher.getChannel(), tmpDir);
     }
 
-    @SuppressFBWarnings(value = "NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE",
-            justification = "workspace is passed through perform method, which will always have NonNull FilePath")
     default String getNodeSpecificTmpFolderPath(FilePath workspace) throws IOException, InterruptedException {
         Computer cmp = workspace.toComputer();
+        if (cmp == null) {
+            throw new IOException(Message.getValue("build.workspace.computer.not.found"));
+        }
         String tmpDir = (String) cmp.getSystemProperties().get("java.io.tmpdir");
         return tmpDir;
     }
 
     default String getUniqueNameForRunnerFile() {
         return UUID.randomUUID().toString();
     }
-
 }

src/main/resources/config.properties

@@ -16,4 +16,5 @@ Builder.matlab.modelcoverage.support.warning = To generate a Cobertura model cov
 Builder.matlab.exportstmresults.support.warning = To export Simulink Test Manager results, use MATLAB R2019a or a newer release.
 Builder.matlab.runner.script.target.file.linux.name = run_matlab_command.sh
 Builder.matlab.runner.script.target.file.windows.name = run_matlab_command.bat
+build.workspace.computer.not.found = Unable to get the current computer for this build.