Merge pull request #140 from mathworks/hot_fixes_issue_132

Hot fixes issue 132

Author: abhargav-mw

src/main/java/com/mathworks/ci/RunMatlabTestsBuilder.java

@@ -9,11 +9,7 @@
  */
 
 import java.io.IOException;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
 import javax.annotation.Nonnull;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.DataBoundSetter;
@@ -137,7 +133,12 @@ public Artifact getPdfReportArtifact() {
 
     public String getPdfReportFilePath() {
         return this.getPdfReportArtifact().getFilePath();
-    }  
+    }
+
+    private Artifact getArtifactObject(boolean isChecked, Artifact returnVal)  {
+        // If previously checked assign valid artifact object else NullArtifact.
+        return (isChecked) ? returnVal : new NullArtifact();
+    }
 
     private void setEnv(EnvVars env) {
         this.env = env;
@@ -149,35 +150,35 @@ private EnvVars getEnv() {
 
     // To retain Backward compatibility
     protected Object readResolve() {
-        // Assign default values to new elements.
-        this.pdfReportArtifact = new NullArtifact();
-        this.tapArtifact = new NullArtifact();
-        this.junitArtifact = new NullArtifact();
-        this.coberturaArtifact = new NullArtifact();
-        this.stmResultsArtifact = new NullArtifact();
-        this.modelCoverageArtifact = new NullArtifact();
-
-        // Assign appropriate artifact type if it was selected earlier.
-        if (pdfReportChkBx) {
-            this.pdfReportArtifact = new PdfArtifact("matlabTestArtifacts/testreport.pdf");
-        }
-        if (tapChkBx) {
-            this.tapArtifact = new TapArtifact("matlabTestArtifacts/taptestresults.tap");
-        }
-        if (junitChkBx) {
-            this.junitArtifact = new JunitArtifact("matlabTestArtifacts/junittestresults.xml");
-        }
-        if (coberturaChkBx) {
-            this.coberturaArtifact = new CoberturaArtifact("matlabTestArtifacts/cobertura.xml");
-        }
-        if (stmResultsChkBx) {
-            this.stmResultsArtifact =
-                    new StmResultsArtifact("matlabTestArtifacts/simulinktestresults.mldatx");
-        }
-        if (modelCoverageChkBx) {
-            this.modelCoverageArtifact =
-                    new ModelCovArtifact("matlabTestArtifacts/coberturamodelcoverage.xml");
-        }
+
+        /*
+        * Assign appropriate artifact objects if it was selected in release 2.0.0 or earlier.
+        * If using a later plugin release, check if artifact objects were previously serialized.
+        * */
+        this.pdfReportArtifact = Optional.ofNullable(this.pdfReportArtifact).orElseGet(() ->
+                this.getArtifactObject(pdfReportChkBx, new PdfArtifact("matlabTestArtifacts/testreport.pdf"))
+        );
+
+        this.tapArtifact = Optional.ofNullable(this.tapArtifact).orElseGet(() ->
+                this.getArtifactObject(tapChkBx, new TapArtifact("matlabTestArtifacts/taptestresults.tap"))
+        );
+
+        this.junitArtifact = Optional.ofNullable(this.junitArtifact).orElseGet(() ->
+                this.getArtifactObject(junitChkBx, new JunitArtifact("matlabTestArtifacts/junittestresults.xml"))
+        );
+
+        this.coberturaArtifact = Optional.ofNullable(this.coberturaArtifact).orElseGet(() ->
+                this.getArtifactObject(coberturaChkBx, new CoberturaArtifact("matlabTestArtifacts/cobertura.xml"))
+        );
+
+        this.stmResultsArtifact = Optional.ofNullable(this.stmResultsArtifact).orElseGet(() ->
+                this.getArtifactObject(stmResultsChkBx, new StmResultsArtifact("matlabTestArtifacts/simulinktestresults.mldatx"))
+        );
+
+        this.modelCoverageArtifact = Optional.ofNullable(this.modelCoverageArtifact).orElseGet(() ->
+                this.getArtifactObject(modelCoverageChkBx, new ModelCovArtifact("matlabTestArtifacts/coberturamodelcoverage.xml"))
+        );
+
         return this;
     }
 

src/test/java/com/mathworks/ci/RunMatlabCommandBuilderTest.java

@@ -187,7 +187,7 @@ public void verifyBuildFailureWhenMatlabCommandFails() throws Exception {
      */
 
     @Test
-    public void verifyBuildFailureWhenMatlabCommandPasses() throws Exception {
+    public void verifyBuildPassesWhenMatlabCommandPasses() throws Exception {
         this.buildWrapper.setMatlabRootFolder(getMatlabroot("R2018b"));
         project.getBuildWrappersList().add(this.buildWrapper);
         RunMatlabCommandBuilderTester tester =
@@ -196,6 +196,7 @@ public void verifyBuildFailureWhenMatlabCommandPasses() throws Exception {
         project.getBuildersList().add(tester);
         FreeStyleBuild build = project.scheduleBuild2(0).get();
         jenkins.assertBuildStatus(Result.SUCCESS, build);
+
     }
 
     /*