Switch to using a temporary directory on the agent external to the workspace.

Author: sameagen-MW

src/main/java/com/mathworks/ci/utilities/MatlabCommandRunner.java

@@ -18,6 +18,7 @@
 import hudson.Launcher;
 import hudson.Launcher.ProcStarter;
 import hudson.model.Computer;
+import hudson.slaves.WorkspaceList;
 import hudson.util.ArgumentListBuilder;
 
 import com.mathworks.ci.Utilities;
@@ -43,11 +44,11 @@ public MatlabCommandRunner(MatlabActionParameters params) throws IOException, In
         }
 
         // Create MATLAB folder
-        FilePath matlabFolder = new FilePath(workspace, ".matlab");
-        matlabFolder.mkdirs();
+        FilePath tmpRoot = WorkspaceList.tempDir(workspace);
+        tmpRoot.mkdirs();
 
         // Create temp folder
-        this.tempFolder = matlabFolder.createTempDir("tempDir", null);
+        this.tempFolder = tmpRoot.createTempDir("matlab", null);
     }
 
     /** 

src/test/java/integ/com/mathworks/ci/RunMatlabBuildBuilderTest.java

@@ -356,18 +356,4 @@ public void verifyMatrixBuildPasses() throws Exception {
 		jenkins.assertLogContains("R2018b completed", build);
 		jenkins.assertBuildStatus(Result.SUCCESS, build);
 	}
-	
-    /*
-     * Test to verify if .matlab temp folder generated in workspace.
-     */
-    @Test
-    public void verifyMATLABtmpFolderGenerated() throws Exception {
-        this.buildWrapper.setMatlabBuildWrapperContent(new MatlabBuildWrapperContent(Message.getValue("matlab.custom.location"), getMatlabroot("R2018b")));
-        project.getBuildWrappersList().add(this.buildWrapper);
-        scriptBuilder.setTasks("");
-        project.getBuildersList().add(this.scriptBuilder);
-        FreeStyleBuild build = project.scheduleBuild2(0).get();
-        File matlabRunner = new File(build.getWorkspace() + File.separator + ".matlab");
-        Assert.assertTrue(matlabRunner.exists());
-    }
 }

src/test/java/integ/com/mathworks/ci/RunMatlabBuildStepTest.java

@@ -176,16 +176,4 @@ public void verifyExceptionStackTraceForNonZeroExitCode() throws Exception {
         j.assertBuildStatus(Result.FAILURE, build);
         j.assertLogContains(String.format(Message.getValue("matlab.execution.exception.prefix"), 1), build);
     }
-    
-    /*
-     * Verify .matlab folder is generated 
-     */
-    @Test
-    public void verifyMATLABtempFolderGenerated() throws Exception {
-        project.setDefinition(
-                new CpsFlowDefinition("node { runMATLABBuild() }", true));
-
-        WorkflowRun build = project.scheduleBuild2(0).get();
-        j.assertLogContains(".matlab", build);
-    }
 }

src/test/java/integ/com/mathworks/ci/RunMatlabCommandBuilderTest.java

@@ -377,18 +377,4 @@ public void verifyMultispecialChar() throws Exception {
         jenkins.assertLogContains("Generating MATLAB script with content", build);
         jenkins.assertLogContains(expectedCommand, build);
     }
-    
-    /*
-     * Test to verify if .matlab temp folder generated in workspace.
-     */
-    @Test
-    public void verifyMATLABtmpFolderGenerated() throws Exception {
-        this.buildWrapper.setMatlabBuildWrapperContent(new MatlabBuildWrapperContent(Message.getValue("matlab.custom.location"), getMatlabroot("R2018b")));
-        project.getBuildWrappersList().add(this.buildWrapper);
-        scriptBuilder.setMatlabCommand("pwd");
-        project.getBuildersList().add(this.scriptBuilder);
-        FreeStyleBuild build = project.scheduleBuild2(0).get();
-        File matlabRunner = new File(build.getWorkspace() + File.separator + ".matlab");
-        Assert.assertTrue(matlabRunner.exists());
-    }
 }

src/test/java/integ/com/mathworks/ci/RunMatlabCommandStepTest.java

@@ -149,18 +149,4 @@ public void verifyExceptionForNonZeroExitCode() throws Exception {
         j.assertLogContains(String.format(Message.getValue("matlab.execution.exception.prefix"), 1), build);
         j.assertBuildStatusSuccess(build);
     }
-    
-    /*
-     * Verify .matlab folder is generated 
-     *
-     */
-
-    @Test
-    public void verifyMATLABtempFolderGenerated() throws Exception {
-        project.setDefinition(
-                new CpsFlowDefinition("node { runMATLABCommand(command: 'pwd')}", true));
-
-        WorkflowRun build = project.scheduleBuild2(0).get();
-        j.assertLogContains(".matlab", build);
-    }
 }

src/test/java/integ/com/mathworks/ci/RunMatlabTestsBuilderTest.java

@@ -484,19 +484,6 @@ public void verifyMATLABscratchFileGenerated() throws Exception {
         Assert.assertFalse(matlabRunner.exists());
     }
 
-    /*
-     * Test to verify if .matlab gets created in workspace.
-     */
-    @Test
-    public void verifyMATLABfolderGenerated() throws Exception {
-        this.buildWrapper.setMatlabBuildWrapperContent(new MatlabBuildWrapperContent(Message.getValue("matlab.custom.location"), getMatlabroot("R2018b")));
-        project.getBuildWrappersList().add(this.buildWrapper);
-        project.getBuildersList().add(testBuilder);
-        FreeStyleBuild build = project.scheduleBuild2(0).get();
-        File matlabRunner = new File(build.getWorkspace() + File.separator + ".matlab");
-        Assert.assertTrue(matlabRunner.exists());
-    }
-    
     /*
      * Test to verify Use Parallel check box present.
      */

src/test/java/integ/com/mathworks/ci/RunMatlabTestsStepTest.java

@@ -156,18 +156,6 @@ public void verifyExceptionForNonZeroExitCode() throws Exception {
         j.assertLogContains(String.format(Message.getValue("matlab.execution.exception.prefix"), 1), build);
     }
 
-    /*
-     * Verify .matlab folder created 
-     */
-
-    @Test
-    public void verifyMATLABtempFolderGenerated() throws Exception {
-        project.setDefinition(new CpsFlowDefinition(
-                "node {runMATLABTests(testResultsPDF:'myresult/result.pdf')}", true));
-        WorkflowRun build = project.scheduleBuild2(0).get();
-        j.assertLogContains(".matlab", build);
-    }
-    
     /*@Integ Test
      * Verify default command options for test Filter using selectByFolder option 
      */

src/test/java/unit/com/mathworks/ci/utilities/MatlabCommandRunnerTest.java

@@ -16,6 +16,7 @@
 import hudson.Launcher;
 import hudson.Launcher.ProcStarter;
 import hudson.model.TaskListener;
+import hudson.slaves.WorkspaceList;
 import hudson.util.ArgumentListBuilder;
 
 import org.junit.Test;
@@ -91,8 +92,10 @@ public void constructorUsesParamsForTempFolder() throws IOException, Interrupted
     public void correctTempFolderLocation() throws IOException, InterruptedException {
         runner = new MatlabCommandRunner(params);
         FilePath tmp = runner.getTempFolder();
-        FilePath expected = new FilePath(new File(tempDir.getRoot(), ".matlab"));
+
+        FilePath expected = WorkspaceList.tempDir(new FilePath(tempDir.getRoot()));
 
+        Assert.assertTrue(tmp.exists());
         Assert.assertThat(
                 tmp.getRemote(),
                 startsWith(expected.getRemote()));