fixes #51, Switch internal properties to hidden for simplicity & ui testing

rjackey · rjackey · commit 2380f5f0e6ba · 2023-03-14T08:44:52.000-04:00
diff --git a/widgets/+wt/+apps/BaseApp.m b/widgets/+wt/+apps/BaseApp.m
@@ -2,7 +2,7 @@
         wt.mixin.ErrorHandling
     % Base class for Widgets Toolbox apps
     
-    % Copyright 2020-2021 The MathWorks, Inc.
+    % Copyright 2020-2023 The MathWorks, Inc.
     
     
     %% Properties
@@ -53,8 +53,7 @@
     end %properties
     
     
-    properties (Transient, NonCopyable, ...
-            Access = {?wt.apps.BaseApp, ?matlab.uitest.TestCase} )
+    properties (Transient, NonCopyable, Hidden, SetAccess = protected)
         
         % Last used folder (for file operations)
         LastFolder (1,1) string = pwd
diff --git a/widgets/+wt/+model/BaseModel.m b/widgets/+wt/+model/BaseModel.m
@@ -8,7 +8,7 @@
     %     to enable apps/widgets to listen to model changes
     %    
 
-    % Copyright 2020-2021 The MathWorks, Inc.
+    % Copyright 2020-2023 The MathWorks, Inc.
     
 
     
@@ -23,8 +23,7 @@
     
     
     %% Internal Properties
-    properties ( Transient, NonCopyable, ...
-            Access = {?wt.abstract.BaseWidget, ?matlab.uitest.TestCase} )
+    properties (Transient, NonCopyable, Hidden, SetAccess = private)
         
         % Listeners to public properties
         PropListeners
diff --git a/widgets/+wt/ButtonGrid.m b/widgets/+wt/ButtonGrid.m
@@ -5,7 +5,7 @@
 
     % Array of buttons with a single callback/event
 
-    % Copyright 2020-2022 The MathWorks Inc.
+    % Copyright 2020-2023 The MathWorks Inc.
 
 
     %% Events
@@ -58,9 +58,8 @@
 
 
     %% Internal Properties
-    properties ( Transient, NonCopyable, ...
-            Access = {?matlab.ui.componentcontainer.ComponentContainer, ?matlab.uitest.TestCase} )
-
+    properties (Transient, NonCopyable, Hidden, SetAccess = protected)
+        
         % Buttons (other widgets like ListSelector also access this)
         Button (1,:) matlab.ui.control.Button
 
diff --git a/widgets/+wt/CheckboxList.m b/widgets/+wt/CheckboxList.m
@@ -4,7 +4,7 @@
     
     % List of checkbox items
     
-    % Copyright 2020-2022 The MathWorks Inc.
+    % Copyright 2020-2023 The MathWorks Inc.
     
     
     %% Public properties
@@ -42,8 +42,7 @@
     
     
     %% Internal Properties
-    properties ( Transient, NonCopyable, ...
-            Access = {?matlab.uitest.TestCase, ?matlab.ui.componentcontainer.ComponentContainer} )
+    properties (Transient, NonCopyable, Hidden, SetAccess = protected)
         
         % Item checkboxes
         ItemCheck (1,:) matlab.ui.control.CheckBox
diff --git a/widgets/+wt/ListSelector.m b/widgets/+wt/ListSelector.m
@@ -5,7 +5,7 @@
     
     % Select from an array of items and add them to a list
 
-    % Copyright 2020-2022 The MathWorks Inc.
+    % Copyright 2020-2023 The MathWorks Inc.
 
 
     %% Events
@@ -80,9 +80,8 @@
 
 
     %% Internal Properties
-    properties (Transient, NonCopyable, ...
-            Access = {?matlab.uitest.TestCase, ?matlab.ui.componentcontainer.ComponentContainer})
-
+    properties (Transient, NonCopyable, Hidden, SetAccess = protected)
+        
         % The ListBox control
         ListBox (1,1) matlab.ui.control.ListBox
 
diff --git a/widgets/+wt/ListSelectorTwoPane.m b/widgets/+wt/ListSelectorTwoPane.m
@@ -6,7 +6,7 @@
     
     % Dual lists where selected items are moved from left to right
 
-    % Copyright 2020-2022 The MathWorks Inc.
+    % Copyright 2020-2023 The MathWorks Inc.
 
 
     %% Events
@@ -77,9 +77,8 @@
 
 
     %% Internal Properties
-    properties ( Transient, NonCopyable, ...
-            Access = {?matlab.uitest.TestCase, ?matlab.ui.componentcontainer.ComponentContainer} )
-
+    properties (Transient, NonCopyable, Hidden, SetAccess = protected)
+        
         % The left listbox control
         LeftList (1,1) matlab.ui.control.ListBox
 
diff --git a/widgets/+wt/PasswordField.m b/widgets/+wt/PasswordField.m
@@ -3,7 +3,7 @@
     
     % A password entry field
     
-    % Copyright 2020-2022 The MathWorks Inc.
+    % Copyright 2020-2023 The MathWorks Inc.
     
     
     %% Public properties
@@ -30,8 +30,7 @@
     
     
     %% Internal Properties
-    properties (Transient, NonCopyable, ...
-            Access = {?matlab.uitest.TestCase, ?matlab.ui.componentcontainer.ComponentContainer} )
+    properties (Transient, NonCopyable, Hidden, SetAccess = protected)
         
         % Grid
         Grid (1,1) matlab.ui.container.GridLayout
diff --git a/widgets/+wt/ProgressBar.m b/widgets/+wt/ProgressBar.m
@@ -4,7 +4,7 @@
 
     % A progress bar with status and cancel button
 
-    % Copyright 2020-2022 The MathWorks Inc.
+    % Copyright 2020-2023 The MathWorks Inc.
 
 
     %% Events
@@ -71,9 +71,8 @@
 
 
     %% Internal Properties
-    properties ( Transient, NonCopyable, ...
-            Access = {?matlab.uitest.TestCase, ?matlab.ui.componentcontainer.ComponentContainer} )
-
+    properties (Transient, NonCopyable, Hidden, SetAccess = protected)
+        
         % Progress panel
         ProgressPanel (1,1) matlab.ui.container.Panel
 
diff --git a/widgets/+wt/SliderCheckboxGroup.m b/widgets/+wt/SliderCheckboxGroup.m
@@ -6,7 +6,7 @@
     % A group of sliders with checkboxes, useful for visibility of various
     % layers of imagery
     
-    % Copyright 2020-2022 The MathWorks Inc.
+    % Copyright 2020-2023 The MathWorks Inc.
     
     
     %% Events
@@ -48,8 +48,7 @@
     
     
     %% Internal Properties
-    properties ( Transient, NonCopyable, ...
-            Access = {?matlab.ui.componentcontainer.ComponentContainer, ?matlab.uitest.TestCase} )
+    properties (Transient, NonCopyable, Hidden, SetAccess = protected)
         
         % Grid for Layout
         Grid (1,1) matlab.ui.container.GridLayout
diff --git a/widgets/+wt/SliderSpinner.m b/widgets/+wt/SliderSpinner.m
@@ -5,7 +5,7 @@
 
     % A slider and spinner combination
     
-    % Copyright 2020-2022 The MathWorks Inc.
+    % Copyright 2020-2023 The MathWorks Inc.
     
     
     %% Public properties
@@ -71,8 +71,7 @@
     
     
     %% Internal Properties
-    properties ( Transient, NonCopyable, ...
-            Access = {?matlab.ui.componentcontainer.ComponentContainer, ?matlab.uitest.TestCase} )
+    properties (Transient, NonCopyable, Hidden, SetAccess = protected)
         
         % Grid Layout
         Grid (1,1) matlab.ui.container.GridLayout
diff --git a/widgets/+wt/TaskStatusTable.m b/widgets/+wt/TaskStatusTable.m
@@ -5,7 +5,7 @@
 
     % A table showing status of multiple tasks
     
-    % Copyright 2020-2022 The MathWorks Inc.
+    % Copyright 2020-2023 The MathWorks Inc.
     
     
     %% Public properties
@@ -63,8 +63,7 @@
     
     
     %% Internal Properties
-    properties ( Transient, NonCopyable, ...
-            Access = {?matlab.uitest.TestCase,?matlab.ui.componentcontainer.ComponentContainer} )
+    properties (Transient, NonCopyable, Hidden, SetAccess = protected)
         
         % Grid for task items
         TaskGrid (1,1) matlab.ui.container.GridLayout
diff --git a/widgets/+wt/Toolbar.m b/widgets/+wt/Toolbar.m
@@ -6,7 +6,7 @@
 
     % A configurable toolbar
 
-    % Copyright 2020-2022 The MathWorks Inc.
+    % Copyright 2020-2023 The MathWorks Inc.
 
     %% Events
     events (HasCallbackProperty, NotifyAccess = protected)
@@ -37,9 +37,8 @@
 
 
     %% Internal Properties
-    properties ( Transient, NonCopyable, ...
-            Access = {?matlab.ui.componentcontainer.ComponentContainer, ?matlab.uitest.TestCase} )
-
+    properties (Transient, NonCopyable, Hidden, SetAccess = protected)
+        
         % The listbox control
         ListBox (1,1) matlab.ui.control.ListBox
 
@@ -67,8 +66,8 @@
     end %properties
 
 
-    properties (Dependent, NonCopyable, Access = {?matlab.uitest.TestCase})
-
+    properties (Dependent, NonCopyable, Hidden, SetAccess = private)
+        
         % Indicates which sections are open
         SectionIsOpen (:,1) logical
 
diff --git a/widgets/examples/TemplateBaseApp.m b/widgets/examples/TemplateBaseApp.m
@@ -1,16 +1,13 @@
 classdef TemplateBaseApp < wt.apps.BaseApp
     % Implements a template for a BaseApp
+    
+    % Copyright 2020-2023 The MathWorks Inc.
 
 
     %% Internal Components
     %   Create properties here for each control, layout, or view component
     %   that will be placed directly into the main app window.
-    properties ( Transient, NonCopyable, SetAccess = protected )
-
-        % Once the app is created and debugged, consider also protecting
-        % get access to these properties. Leave them accessible to unit
-        % tests, however. Use this example:
-        % GetAccess = {?matlab.uitest.TestCase, ?wt.apps.BaseApp})
+    properties ( Transient, NonCopyable, Hidden, SetAccess = protected )
 
         % Grid Layouts
         % (BaseApp already brings "Grid", the main Grid layout in the window)
diff --git a/widgets/examples/TemplateBaseSingleSessionApp.m b/widgets/examples/TemplateBaseSingleSessionApp.m
@@ -1,16 +1,13 @@
 classdef TemplateBaseSingleSessionApp < wt.apps.BaseSingleSessionApp
     % Implements a template for a BaseSingleSessionApp
+    
+    % Copyright 2020-2023 The MathWorks Inc.
 
 
     %% Internal Components
     %   Create properties here for each control, layout, or view component
     %   that will be placed directly into the main app window.
-    properties ( Transient, NonCopyable, SetAccess = protected )
-
-        % Once the app is created and debugged, consider also protecting
-        % get access to these properties. Leave them accessible to unit
-        % tests, however. Use this example:
-        % GetAccess = {?matlab.uitest.TestCase, ?wt.apps.BaseApp})
+    properties ( Transient, NonCopyable, Hidden, SetAccess = protected )
 
         % Grid Layouts
         % (BaseApp already brings "Grid", the main Grid layout in the window)
