Merge pull request #121 from mathworks/84-contextualpane-clicking-through-views-too-fast-before-they-render-will-cause-backups-and-hangs-in-jsd

84 contextualpane clicking through views too fast before they render will cause backups and hangs in jsd

Author: rjackey

test/+wt/+test/ContextualView.m

@@ -1,46 +1,46 @@
 classdef ContextualView < wt.test.BaseWidgetTest
     % Implements a unit test for a widget or component
-    
+
     % Copyright 2025 The MathWorks, Inc.
-   
+
 
     %% Class Setup
     methods (TestClassSetup)
-        
+
         function createFigure(testCase)
             % Override the figure creation
-            
+
             % Call superclass method
             testCase.createFigure@wt.test.BaseWidgetTest();
-            
+
             % Set the figure size
             testCase.Figure.Position([3 4]) = [900 700];
-            
+
             % Modify the grid row height
             testCase.Grid.RowHeight = {'1x','1x','1x'};
             testCase.Grid.ColumnWidth = {'1x','1x','1x'};
-            
+
         end %function
-        
+
     end %methods
-    
+
 
     %% Test Method Setup
     methods (TestMethodSetup)
-        
+
         function setup(testCase)
-            
+
             fcn = @()wt.ContextualView(testCase.Grid);
             testCase.Widget = verifyWarningFree(testCase,fcn);
-            
+
         end %function
-        
+
     end %methods
-    
-    
+
+
     %% Test methods
     methods (Test)
-        
+
         function testLaunchViewWithModel(testCase)
             % This tests:
             %   Launching the Animal view
@@ -103,52 +103,14 @@ function testLaunchViewWithModel(testCase)
             testCase.verifyEqual(actVal, expVal, diag)
 
         end %function
-        
-
-        function testChildrenHierarchy(testCase)
-            % Verify the children order of the widget
-            % - widget itself
-            %   - MainGrid
-            %       - ContentGrid (views go here)
-            %       - LoadingImage (visible gets toggled to cover view)
-            %
-            % Verify the loading image is off after setup
-            % Verify the loading image file is on path
-
-            % Verify MainGrid's parent the widget
-            diag = "MainGrid's parent should be the ContextualView widget";
-            actVal = testCase.Widget.Grid.Parent;
-            expVal = testCase.Widget;
-            testCase.verifyEqual(actVal, expVal, diag)
 
-            % Verify MainGrid's children order
-            diag = "MainGrid's children should be the ContentGrid and LoadingImage in order";
-            actVal = testCase.Widget.Grid.Children;
-            expVal = [
-                testCase.Widget.ContentGrid
-                testCase.Widget.LoadingImage
-                ];
-            testCase.verifyEqual(actVal, expVal, diag)
-
-            % Verify loading image is off after setup
-            diag = "LoadingImage should not be visible after setup";
-            val = testCase.Widget.LoadingImage.Visible;
-            testCase.verifyFalse(val, diag)
-
-            % Verify loading image source file exists on path
-            diag = "LoadingImageSource file must exist on path";
-            val = exist(testCase.Widget.LoadingImageSource,"file") == 2;
-            testCase.verifyTrue(val, diag)
-
-        end %function
-        
 
         function testChangingViews(testCase)
             % This tests:
             %   Launching the Animal view
             %   Launching the Enclosure view
             %   Launching the Animal view again
-           
+
 
             % Create a model to display
             model1 = zooexample.model.Animal;
@@ -240,186 +202,7 @@ function testChangingViews(testCase)
             testCase.verifyEqual(actVal, expVal, diag)
 
         end %function
-        
-
-        function testBlockWhileLoadingDuringLaunch(testCase)
-            % Verify loading image shows when launching a pane
-
-            % Create models to display
-            model1 = zooexample.model.Animal;
-            model1.Species = "Lion";
-            model1.Name = "Simba";
-            model1.Sex = "male";
-            model1.BirthDate = "March 9, 1994";
-
-
-            % Prepare to launch the view (turning on the loading image)
-            viewClass = "zooexample.view.Animal";
-            fcn = @()testCase.Widget.prepareToLaunchView(viewClass);
-            testCase.verifyWarningFree(fcn);
-
-
-            % Verify loading image is on
-            diag = "LoadingImage should be visible after prepareToLaunchView";
-            actVal = testCase.Widget.LoadingImage.Visible;
-            expVal = matlab.lang.OnOffSwitchState.on;
-            testCase.verifyEqual(actVal, expVal, diag)
-
-
-            % Launch the view
-            viewClass = "zooexample.view.Animal";
-            fcn = @()testCase.Widget.launchView(viewClass, model1);
-            view1 = testCase.verifyWarningFree(fcn);
-
-            % Verify loading image is off after launch
-            diag = "LoadingImage should not be visible after launch";
-            actVal = testCase.Widget.LoadingImage.Visible;
-            expVal = matlab.lang.OnOffSwitchState.off;
-            testCase.verifyEqual(actVal, expVal, diag)
-
-            % Verify the view's parent
-            diag = "View's parent must be the ContextualView's internal content grid";
-            actVal = view1.Parent;
-            expVal = testCase.Widget.ContentGrid;
-            testCase.verifyEqual(actVal, expVal, diag)
-
-            % Verify the active view
-            diag = "View must be the ContextualView's active view";
-            actVal = testCase.Widget.ActiveView;
-            expVal = view1;
-            testCase.verifyEqual(actVal, expVal, diag)
-
-        end %function
-        
 
-        function testBlockWhileLoadingOff(testCase)
-            % This tests:
-            %   Using prepareToLaunchView
-            %   Toggling off the BlockWhileLoading option
-            %   Customize the loading image source
-
-            % Create models to display
-            model1 = zooexample.model.Animal;
-            model1.Species = "Lion";
-            model1.Name = "Simba";
-            model1.Sex = "male";
-            model1.BirthDate = "March 9, 1994";
-
-            model3 = zooexample.model.Enclosure;
-            model3.Name = "Lions' Den";
-            model3.Location = [10 20];
-            
-
-            % Toggling off the BlockWhileLoading option
-            testCase.Widget.BlockWhileLoading = false;
-
-            % Prepare to launch the view (loading image is OFF)
-            viewClass = "zooexample.view.Animal";
-            fcn = @()testCase.Widget.prepareToLaunchView(viewClass);
-            testCase.verifyWarningFree(fcn);
-
-            % Verify loading image is off
-            diag = "LoadingImage should not be visible with BlockWhileLoading = false";
-            actVal = testCase.Widget.LoadingImage.Visible;
-            expVal = matlab.lang.OnOffSwitchState.off;
-            testCase.verifyEqual(actVal, expVal, diag)
-
-            % Launch the view
-            viewClass = "zooexample.view.Animal";
-            fcn = @()testCase.Widget.launchView(viewClass, model1);
-            testCase.verifyWarningFree(fcn);
-
-            % Verify loading image is off after launch
-            diag = "LoadingImage should not be visible after launch";
-            actVal = testCase.Widget.LoadingImage.Visible;
-            expVal = matlab.lang.OnOffSwitchState.off;
-            testCase.verifyEqual(actVal, expVal, diag)
-
-
-            % Toggling on the BlockWhileLoading option
-            testCase.Widget.BlockWhileLoading = true;
-
-            % Prepare to launch a different view (turning on the loading image)
-            viewClass = "zooexample.view.Enclosure";
-            fcn = @()testCase.Widget.prepareToLaunchView(viewClass);
-            testCase.verifyWarningFree(fcn);
-
-            % Verify loading image is on
-            diag = "LoadingImage should be visible after prepareToLaunchView";
-            actVal = testCase.Widget.LoadingImage.Visible;
-            expVal = matlab.lang.OnOffSwitchState.on;
-            testCase.verifyEqual(actVal, expVal, diag)
-
-            % Launch the view
-            viewClass = "zooexample.view.Enclosure";
-            fcn = @()testCase.Widget.launchView(viewClass, model3);
-            testCase.verifyWarningFree(fcn);
-
-        end %function
-        
-
-        function testBlockWhileLoadingSwitching(testCase)
-            % This tests:
-            %   Switching between views and models
-            %   Launching a new view or switching them shows the loading
-            %   image
-            %   Changing model on the same view does not show the loading
-            %   image
-
-            % Create models to display
-            model1 = zooexample.model.Animal;
-            model1.Species = "Lion";
-            model1.Name = "Simba";
-            model1.Sex = "male";
-            model1.BirthDate = "March 9, 1994";
-
-            model3 = zooexample.model.Enclosure;
-            model3.Name = "Lions' Den";
-            model3.Location = [10 20];
-
-
-            % Launch the first view
-            viewClass = "zooexample.view.Animal";
-            fcn = @()testCase.Widget.launchView(viewClass, model1);
-            testCase.verifyWarningFree(fcn);
-
-
-            % Prepare to launch same view (no loading image)
-            viewClass = "zooexample.view.Animal";
-            fcn = @()testCase.Widget.prepareToLaunchView(viewClass);
-            testCase.verifyWarningFree(fcn);
-
-            % Verify loading image is off
-            diag = "LoadingImage should not be visible when preparing to load same active view";
-            actVal = testCase.Widget.LoadingImage.Visible;
-            expVal = matlab.lang.OnOffSwitchState.off;
-            testCase.verifyEqual(actVal, expVal, diag)
-
-
-            % Prepare to launch different view (expect to have loading image)
-            viewClass = "zooexample.view.Enclosure";
-            fcn = @()testCase.Widget.prepareToLaunchView(viewClass);
-            testCase.verifyWarningFree(fcn);
-
-            % Verify loading image is on
-            diag = "LoadingImage should be visible after prepareToLaunchView with launching new pane";
-            actVal = testCase.Widget.LoadingImage.Visible;
-            expVal = matlab.lang.OnOffSwitchState.on;
-            testCase.verifyEqual(actVal, expVal, diag)
-
-            % Launch the view
-            viewClass = "zooexample.view.Enclosure";
-            fcn = @()testCase.Widget.launchView(viewClass, model3);
-            testCase.verifyWarningFree(fcn);
-
-            % Verify loading image is off after launch
-            diag = "LoadingImage should not be visible after launch";
-            actVal = testCase.Widget.LoadingImage.Visible;
-            expVal = matlab.lang.OnOffSwitchState.off;
-            testCase.verifyEqual(actVal, expVal, diag)
-            
-        end %function
-        
 
         function testClearView(testCase)
             % This tests debugging methods:
@@ -429,7 +212,7 @@ function testClearView(testCase)
             diag = "Expected launchMultipleViews helper function to put component in desired state.";
             fcn = @()testCase.launchMultipleViews();
             testCase.assumeWarningFree(fcn, diag)
-            
+
             % Clear the view
             diag = "Expected clearView to run without warnings.";
             fcn = @()testCase.Widget.clearView();
@@ -451,7 +234,7 @@ function testClearView(testCase)
             testCase.verifyNotEmpty(actVal, diag)
 
         end %function
-        
+
 
         function testRelaunchActiveView(testCase)
             % This tests debugging methods:
@@ -465,7 +248,7 @@ function testRelaunchActiveView(testCase)
             % Get the active view and model
             view3 = testCase.Widget.ActiveView;
             model3 = view3.Model;
-            
+
             % Relaunch the view
             diag = "Expected relaunchActiveView to run without warnings.";
             fcn = @()testCase.Widget.relaunchActiveView();
@@ -491,7 +274,7 @@ function testRelaunchActiveView(testCase)
             actVal = view3A.Model;
             expVal = model3;
             testCase.verifyEqual(actVal, expVal, diag)
-            
+
             % Verify the active view is listed in loaded views
             diag = "View must be listed in the ContextualView's loaded views";
             val = any(view3A == testCase.Widget.LoadedViews);
@@ -503,7 +286,7 @@ function testRelaunchActiveView(testCase)
             testCase.verifyFalse(val, diag)
 
         end %function
-        
+
 
         function testReset(testCase)
             % This tests debugging methods:
@@ -513,7 +296,7 @@ function testReset(testCase)
             diag = "Expected launchMultipleViews helper function to put component in desired state.";
             fcn = @()testCase.launchMultipleViews();
             testCase.assumeWarningFree(fcn, diag)
-            
+
             % Reset the view
             diag = "Expected reset to run without warnings.";
             fcn = @()testCase.Widget.reset();
@@ -535,13 +318,13 @@ function testReset(testCase)
             testCase.verifyEmpty(actVal, diag)
 
         end %function
-         
+
     end %methods (Test)
 
 
     %% Helper methods
     methods (Access = protected)
-    
+
         function launchMultipleViews(testCase)
             % Launches multiple views into the component to have it in a
             % used state
@@ -571,5 +354,5 @@ function launchMultipleViews(testCase)
         end %function
 
     end %methods
-    
+
 end %classdef

test/+wt/+test/ProjectIntegrityChecks.m

@@ -1,14 +1,9 @@
 classdef ProjectIntegrityChecks < matlab.unittest.TestCase
     % Implements a unit test that runs the Project Integrity Checks
 
-    properties(Access = private)
-        DoNotRun = verLessThan("MATLAB", "9.9"); %#ok<VERLESSMATLAB> to support running this in < R2020b
-    end
 
     methods(Test)
         function runProjectChecks(testCase)
-            % do not continue if DoNotRun is set
-            testCase.assumeFalse(testCase.DoNotRun, "Integrity Checks can only be run on R2020b or newer programmatically.")
 
             % find project root folder based on this file (3 folders up)
             prjFolder = fileparts(fileparts(fileparts(fileparts(mfilename("fullpath")))));