Skip to content

Commit 5e5fc72

Browse files
committed
bugfix od adapt function in base filter
1 parent e1baa73 commit 5e5fc72

File tree

5 files changed

+11
-2
lines changed

5 files changed

+11
-2
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
*.png
2+
*.svg
3+
14
.idea/
25

36
to_ignore.py

af_classes.pdf

15.5 KB
Binary file not shown.

docsdir/source/sources/changelog.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Changelog
44
===========
55

6-
**Version 1.2.0** *2022-01-28*
6+
**Version 1.2.0** *Released: 2022-01-28*
77
All adaptive filters were significantly refactored.
88
Added new adaptive filters :ref:`filter-gmcc`, :ref:`filter-llncosh`.
99
Added new detection tool :ref:`detection-ese`.

padasip/filters/base_filter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ def adapt(self, d, x):
163163
"""
164164
y = self.predict(x)
165165
e = d - y
166-
self.w += self.learning_rule(self, e, x)
166+
self.w += self.learning_rule(e, x)
167167

168168
def run(self, d, x):
169169
"""

tests/filters.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@
99

1010
class TestFilters(unittest.TestCase):
1111

12+
def test_base_filter_adapt(self):
13+
filt = pa.filters.FilterLMS(3, mu=1., w="zeros")
14+
x = np.array([2, 4, 3])
15+
filt.adapt(1, x)
16+
self.assertAlmostEqual(filt.w.sum(), 9.0)
17+
1218
def test_filter_gngd(self):
1319
"""
1420
Test of GNGD filter output.

0 commit comments

Comments
 (0)