Fix plt.pause() behaviour #291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #79, it is shown that plt.pause() raises an error when using ipympl.
In that issue, there is discussion recommending removing the two methods that raise the error, as the
FigureCanvasBase.start_event_loop_defaultmethod does not exist. This PR implements that.It turns out that the ipympl Canvas object actually inherits from
FigureCanvasBaseanyway (throughCanvas->FigureCanvasWebAggCore->backend_agg.FigureCanvasAgg->FigureCanvasBase), so removing them or renaming the called methods to remove the_defaultare equivalent.Here is a gif showing the new behaviour with this PR (previous was an error)