version change + test case + incoporation of suggestions on stepwhere and range(..)

Author: instrat

src/mplfinance/_version.py

@@ -1,5 +1,5 @@
 
-version_info = (0, 12, 7, 'alpha', 11)
+version_info = (0, 12, 7, 'alpha', 12)
 
 _specifier_ = {'alpha': 'a','beta': 'b','candidate': 'rc','final': ''}
 

src/mplfinance/plotting.py

@@ -910,12 +910,12 @@ def _addplot_columns(panid,panels,ydata,apdict,xdates,config):
         alpha  = apdict['alpha']
         ax.plot(xdates,ydata,linestyle=ls,color=color,linewidth=width,alpha=alpha)
     elif aptype == 'step':
-        where = apdict['where']
+        stepwhere = apdict['stepwhere']
         ls = apdict['linestyle']
         color  = apdict['color']
         width  = apdict['width'] if apdict['width'] is not None else 1.6*config['_width_config']['line_width']
         alpha  = apdict['alpha']
-        ax.step(range(len(xdates)),ydata,where = where,linestyle=ls,color=color,linewidth=width,alpha=alpha)
+        ax.step(xdates,ydata,where = stepwhere,linestyle=ls,color=color,linewidth=width,alpha=alpha)
     else:
         raise ValueError('addplot type "'+str(aptype)+'" NOT yet supported.')
 
@@ -1003,7 +1003,7 @@ def _valid_addplot_kwargs():
 
     valid_linestyles = ('-','solid','--','dashed','-.','dashdot','.','dotted',None,' ','')
     valid_types = ('line','scatter','bar', 'ohlc', 'candle','step')
-    valid_wheres = ('pre','post','mid')
+    valid_stepwheres = ('pre','post','mid')
 
     vkwargs = {
         'scatter'     : { 'Default'     : False,
@@ -1064,8 +1064,8 @@ def _valid_addplot_kwargs():
         'yscale'      : { 'Default'     : None,
                           'Validator'   : lambda value: _yscale_validator(value) },
 
-        'where'      : { 'Default'     : 'pre',
-                          'Validator'   : lambda value : value in valid_wheres },                  
+        'stepwhere'      : { 'Default'     : 'pre',
+                          'Validator'   : lambda value : value in valid_stepwheres },                  
     }
 
     _validate_vkwargs_dict(vkwargs)

tests/reference_images/addplot11.png

@@ -329,3 +329,28 @@ def test_addplot10(bolldata):
        print('result=',result)
     assert result is None
 
+def test_addplot11(bolldata):
+
+    df = bolldata.iloc[50:130,]
+
+    fname = base+'11.png'
+    tname = os.path.join(tdir,fname)
+    rname = os.path.join(refd,fname)
+    
+    df['trend'] = 0
+    df.loc[df['Close'] < df['Open'], 'trend'] = - 1
+    df.loc[df['Close'] > df['Open'], 'trend'] = 1
+    ap = mpf.make_addplot(df['trend'],panel=1,type='step',ylabel='simple trend')
+    mpf.plot(df,ylabel='OHLC',addplot=ap,savefig=tname)
+
+    tsize = os.path.getsize(tname)
+    print(glob.glob(tname),'[',tsize,'bytes',']')
+
+    rsize = os.path.getsize(rname)
+    print(glob.glob(rname),'[',rsize,'bytes',']')
+
+    result = compare_images(rname,tname,tol=IMGCOMP_TOLERANCE)
+    if result is not None:
+        print('result=',result)
+    assert result is None
+