Skip to content

Commit a0cefdc

Browse files
fix y_on_right==None case (issue #190)
1 parent ba3333a commit a0cefdc

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/mplfinance/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
version_info = (0, 12, 6, 'alpha', 0)
2+
version_info = (0, 12, 6, 'alpha', 1)
33

44
_specifier_ = {'alpha': 'a','beta': 'b','candidate': 'rc','final': ''}
55

src/mplfinance/plotting.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -719,13 +719,11 @@ def _set_ylabels_side(ax_pri,ax_sec,primary_on_right):
719719
ax_pri.yaxis.tick_right()
720720
ax_sec.yaxis.set_label_position('left')
721721
ax_sec.yaxis.tick_left()
722-
elif primary_on_right == False:
722+
else: # treat non-True as False, whether False, None, or anything else.
723723
ax_pri.yaxis.set_label_position('left')
724724
ax_pri.yaxis.tick_left()
725725
ax_sec.yaxis.set_label_position('right')
726726
ax_sec.yaxis.tick_right()
727-
else:
728-
raise ValueError('primary_on_right must be `True` or `False`')
729727

730728
def _plot_mav(ax,config,xdates,prices,apmav=None,apwidth=None):
731729
style = config['style']

0 commit comments

Comments
 (0)