Skip to content

Commit f33c034

Browse files
merge changes from last week
2 parents ff38c24 + 150816f commit f33c034

File tree

5 files changed

+447
-564
lines changed

5 files changed

+447
-564
lines changed

examples/scratch_pad/issues/issue#236_timezone_bug.ipynb

Lines changed: 0 additions & 559 deletions
This file was deleted.

examples/scratch_pad/issues/issue236_timezone_bug.ipynb

Lines changed: 439 additions & 0 deletions
Large diffs are not rendered by default.

src/mplfinance/_arg_validators.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@ def _check_and_prepare_data(data, config):
4040
o, h, l, c, v = columns
4141
cols = [o, h, l, c]
4242

43-
dates = mdates.date2num(data.index.to_pydatetime())
43+
if config['tz_localize']:
44+
dates = mdates.date2num(data.index.tz_localize(None).to_pydatetime())
45+
else: # Just in case someone was depending on this bug (Issue 236)
46+
dates = mdates.date2num(data.index.to_pydatetime())
4447
opens = data[o].values
4548
highs = data[h].values
4649
lows = data[l].values

src/mplfinance/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11

2-
version_info = (0, 12, 7, 'alpha', 3)
2+
version_info = (0, 12, 7, 'alpha', 4)
33

44
_specifier_ = {'alpha': 'a','beta': 'b','candidate': 'rc','final': ''}
55

src/mplfinance/plotting.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -263,10 +263,10 @@ def _valid_plot_kwargs():
263263
'Validator' : lambda value: isinstance(value,mpl_axes.Axes) },
264264

265265
'volume_exponent' : { 'Default' : None,
266-
'Validator' : lambda value: isinstance(value,int) or value == 'legacy' },
266+
'Validator' : lambda value: isinstance(value,int) or value == 'legacy'},
267267

268-
'tzinfo' : { 'Default' : None,
269-
'Validator' : lambda value: isinstance(value,string) },
268+
'tz_localize' : { 'Default' : True,
269+
'Validator' : lambda value: isinstance(value,bool) },
270270
}
271271

272272
_validate_vkwargs_dict(vkwargs)

0 commit comments

Comments
 (0)