Skip to content

Commit 87a1462

Browse files
committed
Tidy filter form
Signed-off-by: Conor MacBride <[email protected]>
1 parent cf297ec commit 87a1462

File tree

2 files changed

+38
-19
lines changed

2 files changed

+38
-19
lines changed

pytest_mpl/summary/templates/filter.html

Lines changed: 35 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,73 +1,89 @@
11
<div class="offcanvas offcanvas-end" tabindex="-1" id="offcanvasFilter" aria-labelledby="offcanvasFilterLabel">
22
<div class="offcanvas-header">
3-
<h6>Filter results</h6>
3+
<h6>Sort and filter results</h6>
44
<button type="button" class="btn-close text-reset" data-bs-dismiss="offcanvas" aria-label="Close"></button>
55
</div>
66
<div class="offcanvas-body">
77
<h5>Sort tests by...</h5>
88
<div class="btn-group m-2 pb-2" role="group" aria-label="Select sorting">
9-
<input type="radio" class="btn-check sort" data-sort="status-sort" data-order="desc" name="sort" id="sortstatus"
9+
<input type="radio" class="btn-check sort" data-sort="status-sort" data-order="desc" name="sort"
10+
id="sortstatus"
1011
autocomplete="off" checked>
1112
<label class="btn btn-outline-secondary" for="sortstatus">status</label>
1213
<input type="radio" class="btn-check sort" data-sort="test-name" name="sort" id="sortname"
1314
autocomplete="off">
1415
<label class="btn btn-outline-secondary" for="sortname">name</label>
15-
<input type="radio" class="btn-check sort" data-sort="rms-sort" data-order="desc" name="sort" id="sortrms" autocomplete="off">
16+
<input type="radio" class="btn-check sort" data-sort="rms-sort" data-order="desc" name="sort" id="sortrms"
17+
autocomplete="off">
1618
<label class="btn btn-outline-secondary" for="sortrms">RMS</label>
1719
</div>
1820
<form id="filterForm" onsubmit="return false;">
1921
<h5>Show tests which have...</h5>
2022
<div class="list-group m-2">
2123
<label class="list-group-item list-group-item-success">
22-
<input class="form-check-input me-1 filter" type="checkbox" value="" id="overall-passed" onclick="applyFilters()">
24+
<input class="form-check-input me-1 filter" type="checkbox" value="" id="overall-passed"
25+
onclick="applyFilters()">
2326
passed
2427
</label>
2528
<label class="list-group-item list-group-item-danger">
26-
<input class="form-check-input me-1 filter" type="checkbox" value="" id="overall-failed" onclick="applyFilters()">
29+
<input class="form-check-input me-1 filter" type="checkbox" value="" id="overall-failed"
30+
onclick="applyFilters()">
2731
failed
2832
</label>
2933
<label class="list-group-item list-group-item-warning">
30-
<input class="form-check-input me-1 filter" type="checkbox" value="" id="overall-skipped" onclick="applyFilters()">
34+
<input class="form-check-input me-1 filter" type="checkbox" value="" id="overall-skipped"
35+
onclick="applyFilters()">
3136
skipped
3237
</label>
3338
</div>
3439
<div class="list-group m-2">
3540
<label class="list-group-item list-group-item-success">
36-
<input class="form-check-input me-1 filter" type="checkbox" value="" id="image-match" onclick="applyFilters()">
41+
<input class="form-check-input me-1 filter" type="checkbox" value="" id="image-match"
42+
onclick="applyFilters()">
3743
matching images
3844
</label>
3945
<label class="list-group-item list-group-item-danger">
40-
<input class="form-check-input me-1 filter" type="checkbox" value="" id="image-diff" onclick="applyFilters()">
46+
<input class="form-check-input me-1 filter" type="checkbox" value="" id="image-diff"
47+
onclick="applyFilters()">
4148
differing images
4249
</label>
4350
</div>
4451
<div class="list-group m-2 mpl-hash">
4552
<label class="list-group-item list-group-item-success">
46-
<input class="form-check-input me-1 filter" type="checkbox" value="" id="hash-match" onclick="applyFilters()">
53+
<input class="form-check-input me-1 filter" type="checkbox" value="" id="hash-match"
54+
onclick="applyFilters()">
4755
matching hashes
4856
</label>
4957
<label class="list-group-item list-group-item-danger">
50-
<input class="form-check-input me-1 filter" type="checkbox" value="" id="hash-diff" onclick="applyFilters()">
58+
<input class="form-check-input me-1 filter" type="checkbox" value="" id="hash-diff"
59+
onclick="applyFilters()">
5160
differing hashes
5261
</label>
5362
</div>
5463
<div class="list-group m-2">
5564
<label class="list-group-item mpl-hash list-group-item-warning">
56-
<input class="form-check-input me-1 filter" type="checkbox" value="" id="hash-missing" onclick="applyFilters()">
65+
<input class="form-check-input me-1 filter" type="checkbox" value="" id="hash-missing"
66+
onclick="applyFilters()">
5767
no baseline hash
5868
</label>
5969
<label class="list-group-item list-group-item-warning">
60-
<input class="form-check-input me-1 filter" type="checkbox" value="" id="image-missing" onclick="applyFilters()">
70+
<input class="form-check-input me-1 filter" type="checkbox" value="" id="image-missing"
71+
onclick="applyFilters()">
6172
no baseline image
6273
</label>
6374
</div>
64-
<button type="submit" class="btn btn-primary m-2" data-bs-dismiss="offcanvas">Apply</button>
65-
<button type="submit" class="btn btn-secondary m-2" onclick="resetFilters()">Reset</button>
66-
<div class="btn-group m-2" role="group" aria-label="Select condition">
67-
<input type="radio" class="btn-check" name="condition" id="conditionand" value="and" autocomplete="off" onclick="applyFilters()" checked>
68-
<label class="btn btn-outline-secondary" for="conditionand">AND</label>
69-
<input type="radio" class="btn-check" name="condition" id="conditionor" value="or" autocomplete="off" onclick="applyFilters()">
70-
<label class="btn btn-outline-secondary" for="conditionor">OR</label>
75+
<div class="d-flex">
76+
<button type="submit" class="btn btn-primary m-2" data-bs-dismiss="offcanvas">Apply</button>
77+
<button type="submit" class="btn btn-outline-secondary m-2" onclick="resetFilters()">Reset</button>
78+
<div class="spacer"></div>
79+
<div class="btn-group m-2" role="group" aria-label="Select condition">
80+
<input type="radio" class="btn-check" name="condition" id="conditionand" value="and"
81+
autocomplete="off" onclick="applyFilters()" checked>
82+
<label class="btn btn-outline-secondary" for="conditionand">AND</label>
83+
<input type="radio" class="btn-check" name="condition" id="conditionor" value="or"
84+
autocomplete="off" onclick="applyFilters()">
85+
<label class="btn btn-outline-secondary" for="conditionor">OR</label>
86+
</div>
7187
</div>
7288
</form>
7389
</div>

pytest_mpl/summary/templates/styles.css

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ body.no-hash-test .mpl-hash {
1414
.nav-filtertools .nav-searchbar {
1515
flex: 10;
1616
}
17+
#filterForm .spacer {
18+
flex: 1;
19+
}
1720
@media (min-width: 576px) {
1821
.nav-filtertools div.spacer {
1922
display: block;

0 commit comments

Comments
 (0)