Skip to content

Commit 3e3883f

Browse files
authored
Update to latest GMSL (#314)
1 parent 54796f2 commit 3e3883f

File tree

7 files changed

+23
-16
lines changed

7 files changed

+23
-16
lines changed

go.mod

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ require (
1010
github.com/docker/go-connections v0.4.0
1111
github.com/gorilla/mux v1.8.0
1212
github.com/matrix-org/gomatrix v0.0.0-20210324163249-be2af5ef2e16
13-
github.com/matrix-org/gomatrixserverlib v0.0.0-20220106115324-39c7d37db009
13+
github.com/matrix-org/gomatrixserverlib v0.0.0-20220214133635-20632dd262ed
1414
github.com/matrix-org/util v0.0.0-20200807132607-55161520e1d4
1515
github.com/morikuni/aec v1.0.0 // indirect
1616
github.com/sirupsen/logrus v1.8.1
17-
github.com/tidwall/gjson v1.12.1
17+
github.com/tidwall/gjson v1.14.0
1818
github.com/tidwall/sjson v1.2.4
19-
golang.org/x/crypto v0.0.0-20211215153901-e495a2d5b3d3 // indirect
19+
golang.org/x/crypto v0.0.0-20220214200702-86341886e292 // indirect
2020
golang.org/x/net v0.0.0-20220127200216-cd36cc0744dd // indirect
2121
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c // indirect
2222
golang.org/x/sys v0.0.0-20220209214540-3681064d5158 // indirect

go.sum

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -438,6 +438,8 @@ github.com/matrix-org/gomatrix v0.0.0-20210324163249-be2af5ef2e16 h1:ZtO5uywdd5d
438438
github.com/matrix-org/gomatrix v0.0.0-20210324163249-be2af5ef2e16/go.mod h1:/gBX06Kw0exX1HrwmoBibFA98yBk/jxKpGVeyQbff+s=
439439
github.com/matrix-org/gomatrixserverlib v0.0.0-20220106115324-39c7d37db009 h1:RV3hT9eHpBSjg0m8W44bgonVUrJI866FkfrW6lf03a0=
440440
github.com/matrix-org/gomatrixserverlib v0.0.0-20220106115324-39c7d37db009/go.mod h1:qFvhfbQ5orQxlH9vCiFnP4dW27xxnWHdNUBKyj/fbiY=
441+
github.com/matrix-org/gomatrixserverlib v0.0.0-20220214133635-20632dd262ed h1:R8EiLWArq7KT96DrUq1xq9scPh8vLwKKeCTnORPyjhU=
442+
github.com/matrix-org/gomatrixserverlib v0.0.0-20220214133635-20632dd262ed/go.mod h1:qFvhfbQ5orQxlH9vCiFnP4dW27xxnWHdNUBKyj/fbiY=
441443
github.com/matrix-org/util v0.0.0-20190711121626-527ce5ddefc7/go.mod h1:vVQlW/emklohkZnOPwD3LrZUBqdfsbiyO3p1lNV8F6U=
442444
github.com/matrix-org/util v0.0.0-20200807132607-55161520e1d4 h1:eCEHXWDv9Rm335MSuB49mFUK44bwZPFSDde3ORE3syk=
443445
github.com/matrix-org/util v0.0.0-20200807132607-55161520e1d4/go.mod h1:vVQlW/emklohkZnOPwD3LrZUBqdfsbiyO3p1lNV8F6U=
@@ -613,6 +615,8 @@ github.com/tchap/go-patricia v2.2.6+incompatible/go.mod h1:bmLyhP68RS6kStMGxByiQ
613615
github.com/tidwall/gjson v1.6.8/go.mod h1:zeFuBCIqD4sN/gmqBzZ4j7Jd6UcA2Fc56x7QFsv+8fI=
614616
github.com/tidwall/gjson v1.12.1 h1:ikuZsLdhr8Ws0IdROXUS1Gi4v9Z4pGqpX/CvJkxvfpo=
615617
github.com/tidwall/gjson v1.12.1/go.mod h1:/wbyibRr2FHMks5tjHJ5F8dMZh3AcwJEMf5vlfC0lxk=
618+
github.com/tidwall/gjson v1.14.0 h1:6aeJ0bzojgWLa82gDQHcx3S0Lr/O51I9bJ5nv6JFx5w=
619+
github.com/tidwall/gjson v1.14.0/go.mod h1:/wbyibRr2FHMks5tjHJ5F8dMZh3AcwJEMf5vlfC0lxk=
616620
github.com/tidwall/match v1.0.3/go.mod h1:eRSPERbgtNPcGhD8UCthc6PmLEQXEWd3PRB5JTxsfmM=
617621
github.com/tidwall/match v1.1.1 h1:+Ho715JplO36QYgwN9PGYNhgZvoUSc9X2c80KVTi+GA=
618622
github.com/tidwall/match v1.1.1/go.mod h1:eRSPERbgtNPcGhD8UCthc6PmLEQXEWd3PRB5JTxsfmM=
@@ -683,6 +687,8 @@ golang.org/x/crypto v0.0.0-20210220033148-5ea612d1eb83/go.mod h1:jdWPYTVW3xRLrWP
683687
golang.org/x/crypto v0.0.0-20210322153248-0c34fe9e7dc2/go.mod h1:T9bdIzuCu7OtxOm1hfPfRQxPLYneinmdGuTeoZ9dtd4=
684688
golang.org/x/crypto v0.0.0-20211215153901-e495a2d5b3d3 h1:0es+/5331RGQPcXlMfP+WrnIIS6dNnNRe0WB02W0F4M=
685689
golang.org/x/crypto v0.0.0-20211215153901-e495a2d5b3d3/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
690+
golang.org/x/crypto v0.0.0-20220214200702-86341886e292 h1:f+lwQ+GtmgoY+A2YaQxlSOnDjXcQ7ZRLWOHbC6HtRqE=
691+
golang.org/x/crypto v0.0.0-20220214200702-86341886e292/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
686692
golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
687693
golang.org/x/exp v0.0.0-20190306152737-a1d7652674e8/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
688694
golang.org/x/exp v0.0.0-20190510132918-efd6b22b2522/go.mod h1:ZjyILWgesfNpC6sMxTJOJm9Kp84zZh5NQWvqDGG3Qr8=

internal/federation/handle.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ func SendJoinRequestsHandler(s *Server, w http.ResponseWriter, req *http.Request
107107
// return state and auth chain
108108
b, err := json.Marshal(gomatrixserverlib.RespSendJoin{
109109
Origin: gomatrixserverlib.ServerName(s.serverName),
110-
AuthEvents: authEvents,
111-
StateEvents: stateEvents,
110+
AuthEvents: gomatrixserverlib.NewEventJSONsFromEvents(authEvents),
111+
StateEvents: gomatrixserverlib.NewEventJSONsFromEvents(stateEvents),
112112
})
113113
if err != nil {
114114
w.WriteHeader(500)

internal/federation/server.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -291,13 +291,13 @@ func (s *Server) MustJoinRoom(t *testing.T, deployment *docker.Deployment, remot
291291
if err != nil {
292292
t.Fatalf("MustJoinRoom: failed to sign event: %v", err)
293293
}
294-
sendJoinResp, err := fedClient.SendJoin(context.Background(), gomatrixserverlib.ServerName(remoteServer), joinEvent, roomVer)
294+
sendJoinResp, err := fedClient.SendJoin(context.Background(), gomatrixserverlib.ServerName(remoteServer), joinEvent)
295295
if err != nil {
296296
t.Fatalf("MustJoinRoom: send_join failed: %v", err)
297297
}
298-
298+
stateEvents := sendJoinResp.StateEvents.UntrustedEvents(roomVer)
299299
room := newRoom(roomVer, roomID)
300-
for _, ev := range sendJoinResp.StateEvents {
300+
for _, ev := range stateEvents {
301301
room.replaceCurrentState(ev)
302302
}
303303
room.AddEvent(joinEvent)

tests/federation_event_auth_test.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,24 +77,25 @@ func TestEventAuth(t *testing.T) {
7777
getEventAuth := func(t *testing.T, eventID string, wantAuthEventIDs []string) {
7878
t.Helper()
7979
t.Logf("/event_auth for %s - want %v", eventID, wantAuthEventIDs)
80-
resp, err := srv.FederationClient(deployment).GetEventAuth(context.Background(), "hs1", room.Version, roomID, eventID)
80+
eventAuthResp, err := srv.FederationClient(deployment).GetEventAuth(context.Background(), "hs1", room.Version, roomID, eventID)
8181
must.NotError(t, "failed to /event_auth", err)
82-
if len(resp.AuthEvents) == 0 {
82+
if len(eventAuthResp.AuthEvents) == 0 {
8383
t.Fatalf("/event_auth returned 0 auth events")
8484
}
85-
if len(resp.AuthEvents) != len(wantAuthEventIDs) {
85+
gotAuthEvents := eventAuthResp.AuthEvents.UntrustedEvents(room.Version)
86+
if len(gotAuthEvents) != len(wantAuthEventIDs) {
8687
msg := "got:\n"
87-
for _, e := range resp.AuthEvents {
88+
for _, e := range gotAuthEvents {
8889
msg += e.EventID() + " : " + string(e.JSON()) + "\n\n"
8990
}
90-
t.Fatalf("got %d auth events, wanted %d.\n%s\nwant: %s", len(resp.AuthEvents), len(wantAuthEventIDs), msg, wantAuthEventIDs)
91+
t.Fatalf("got %d valid auth events (%d total), wanted %d.\n%s\nwant: %s", len(gotAuthEvents), len(eventAuthResp.AuthEvents), len(wantAuthEventIDs), msg, wantAuthEventIDs)
9192
}
9293
// make sure all the events match
9394
wantIDs := map[string]bool{}
9495
for _, id := range wantAuthEventIDs {
9596
wantIDs[id] = true
9697
}
97-
for _, e := range resp.AuthEvents {
98+
for _, e := range gotAuthEvents {
9899
delete(wantIDs, e.EventID())
99100
}
100101
if len(wantIDs) > 0 {

tests/federation_room_event_auth_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ func TestInboundFederationRejectsEventsWithRejectedAuthEvents(t *testing.T) {
9898
_, _ = w.Write([]byte("{}"))
9999
return
100100
}
101-
res := gomatrixserverlib.RespEventAuth{AuthEvents: authEvents}
101+
res := gomatrixserverlib.RespEventAuth{AuthEvents: gomatrixserverlib.NewEventJSONsFromEvents(authEvents)}
102102
responseBytes, _ := json.Marshal(&res)
103103
w.WriteHeader(200)
104104
_, _ = w.Write(responseBytes)

tests/federation_room_join_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ func TestBannedUserCannotSendJoin(t *testing.T) {
294294
must.NotError(t, "JoinEvent.Build", err)
295295

296296
// SendJoin should return a 403.
297-
_, err = fedClient.SendJoin(context.Background(), "hs1", joinEvent, makeJoinResp.RoomVersion)
297+
_, err = fedClient.SendJoin(context.Background(), "hs1", joinEvent)
298298
if err == nil {
299299
t.Errorf("SendJoin returned 200, want 403")
300300
} else if httpError, ok := err.(gomatrix.HTTPError); ok {

0 commit comments

Comments
 (0)